Staging: pi433: Fix line over 80 characters issue
PATCH v3 1/1 Staging: pi433: Fix line over 80 characters issue
Delete extra whitespace and tab space and use one tab space to remove the checkpatch.pl warning:
WARNING: line over 80 characters
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message
--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/pi433/pi433_if.c +4 -4
@@ -45,10 +45,10 @@#include "pi433_if.h" #include "rf69.h" -#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS)/*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900/* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536/* 65536 = 2^16 */ +#define NUM_DIO 2static dev_t pi433_dev;static DEFINE_IDR (pi433_idr);
Signature · 1 line
2.7.4
Greg KH
maintainerQuoted 6 lines · Debleena Sen
Delete extra whitespace and tab space and use one tab space to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>
Quoted 7 lines
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
The "changes in" lines go below the --- line, not above it :(
(note, one kernel subsystem does want it above the line, the graphics developers. But they are crazy anyway and like doing things differently, so don't worry about them just yet...)
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 6 lines · Debleena Sen
Delete extra whitespace and tab space and use one tab space to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>Quoted 7 lines
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)The "changes in" lines go below the --- line, not above it :(
Quoted 8 lines
(note, one kernel subsystem does want it above the line, the graphics developers. But they are crazy anyway and like doing things differently, so don't worry about them just yet...)
thanks,
greg k-h
How do I put them below "---"?
I tried to but couldn't understand how :'((
Greg KH
maintainerQuoted 23 lines · Debleena Sen
Quoted 21 lines · Greg KH
Quoted 6 lines · Debleena Sen
Delete extra whitespace and tab space and use one tab space to remove the checkpatch.pl warning:
WARNING: line over 80 charactersSigned-off-by Debleena Sen <[email protected]>Quoted 7 lines
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message--- drivers/staging/pi433/pi433_if.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)The "changes in" lines go below the --- line, not above it :(
(note, one kernel subsystem does want it above the line, the graphics developers. But they are crazy anyway and like doing things differently, so don't worry about them just yet...)
Quoted 7 lines
Quoted 4 lines
thanks,
greg k-h
How do I put them below "---"?
I tried to but couldn't understand how :'((
You have to edit the patch itself, after you run 'git format-patch'.
thanks,
greg k-h