remove amdgpu_vrr_atom
PATCH 1/1 remove amdgpu_vrr_atom
it doesn't work as expected
--- src/amdgpu_kms.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
src/amdgpu_kms.c +2 -6
@@ -66,7 +66,6 @@ static DevPrivateKeyRec amdgpu_window_private_key;static DevScreenPrivateKeyRec amdgpu_client_private_key;DevScreenPrivateKeyRec amdgpu_device_private_key; -static Atom amdgpu_vrr_atom;static Bool amdgpu_property_vectors_wrapped;static Bool restore_property_vector;static int (*saved_change_property) (ClientPtr client);
@@ -136,7 +135,7 @@ amdgpu_change_property(ClientPtr client)if (ret != Success)return ret; -if (stuff->property == amdgpu_vrr_atom && +if (!strcmp (NameForAtom (stuff->property),"_VARIABLE_REFRESH" ) &&xf86ScreenToScrn (window->drawable.pScreen)->PreInit == AMDGPUPreInit_KMS && stuff->format ==32 && stuff->nUnits ==1 ) {uint32_t *value = (uint32_t *)(stuff +1 );
@@ -171,7 +170,7 @@ amdgpu_delete_property(ClientPtr client)if (ret != Success)return ret; -if (stuff->property == amdgpu_vrr_atom && +if (!strcmp (NameForAtom (stuff->property),"_VARIABLE_REFRESH" ) &&xf86ScreenToScrn (window->drawable.pScreen)->PreInit == AMDGPUPreInit_KMS)amdgpu_vrr_property_update (window, FALSE);
@@ -2187,9 +2186,6 @@ Bool AMDGPUScreenInit_KMS(ScreenPtr pScreen, int argc, char **argv) ProcVector[X_DeleteProperty] = amdgpu_delete_property; amdgpu_property_vectors_wrapped = TRUE; } - - amdgpu_vrr_atom =MakeAtom ("_VARIABLE_REFRESH" , -strlen ("_VARIABLE_REFRESH" ), TRUE); }drmmode_init (pScrn, &info->drmmode);
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Flora,
note that xf86-video-amdgpu patches are reviewed as GitLab merge requests these days, as documented in README.md:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/merge_requests
Quoted 1 line · Flora
it doesn't work as expected
Why is that? Maybe you ran into the Mesa bug fixed by
https://gitlab.freedesktop.org/mesa/mesa/commit/c0a540f32067cc8cb126d9aa1eb12a11cf15373a?merge_request_iid=202
, or a similar bug elsewhere?
Signature · 6 lines
Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Drop amd-gfx.
Hi Michel,
Thanks for your info.
Hi Hui,
Could you make similar changes in ugl?
-----Original Message-----
From: Michel Dänzer <[email protected]>
Sent: Thursday, March 07, 2019 5:05 PM
To: Cui, Flora <[email protected]>; [email protected]
Subject: Re: [PATCH] remove amdgpu_vrr_atom
Hi Flora,
note that xf86-video-amdgpu patches are reviewed as GitLab merge requests these days, as documented in README.md:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/merge_requests
Quoted 1 line · Flora
it doesn't work as expected
Why is that? Maybe you ran into the Mesa bug fixed by
https://gitlab.freedesktop.org/mesa/mesa/commit/c0a540f32067cc8cb126d9aa1eb12a11cf15373a?merge_request_iid=202
, or a similar bug elsewhere?
Signature · 6 lines
Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx