staging: rtl8712: Replace NULL comparisons
PATCH 1/1 staging: rtl8712: Replace NULL comparisons
Replace all NULL comparisons in the file
to get rid of checkpatch warnings
--- drivers/staging/rtl8712/rtl8712_recv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8712/rtl8712_recv.c +5 -5
@@ -135,7 +135,7 @@ int r8712_free_recvframe(union recv_frame *precvframe,spin_lock_irqsave (&pfree_recv_queue->lock, irqL);list_del_init (&(precvframe->u.hdr.list));list_add_tail (&(precvframe->u.hdr.list), &pfree_recv_queue->queue); -if (padapter !=NULL ) { +if (padapter) {if (pfree_recv_queue == &precvpriv->free_recv_queue) precvpriv->free_recvframe_cnt++; }
@@ -273,7 +273,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,/* 0~(n-1) fragment frame * enqueue to defraf_g */ -if (pdefrag_q !=NULL ) { +if (pdefrag_q) {if (fragnum ==0 ) {/*the first fragment*/ if (!list_empty (&pdefrag_q->queue)) {
@@ -299,7 +299,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,/* the last fragment frame * enqueue the last fragment */ -if (pdefrag_q !=NULL ) { +if (pdefrag_q) { phead = &pdefrag_q->queue;list_add_tail (&pfhdr->list, phead);/*call recvframe_defrag to defrag*/
@@ -313,7 +313,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter, prtnframe =NULL ; } } -if ((prtnframe !=NULL ) && (prtnframe->u.hdr.attrib.privacy)) { +if ((prtnframe) && (prtnframe->u.hdr.attrib.privacy)) {/* after defrag we must check tkip mic code */ if (r8712_recvframe_chkmic (padapter, prtnframe) == _FAIL) {r8712_free_recvframe (prtnframe, pfree_recv_queue);
@@ -889,7 +889,7 @@ static void process_link_qual(struct _adapter *padapter,struct rx_pkt_attrib *pattrib;struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data; -if (prframe ==NULL || padapter ==NULL ) +if (!prframe || !padapter)return ; pattrib = &prframe->u.hdr.attrib;if (pattrib->signal_qual !=0 ) {
Signature · 1 line
2.7.4
Quoted 40 lines · Daniela Mormocea
Replace all NULL comparisons in the file
to get rid of checkpatch warningsSigned-off-by Daniela Mormocea <[email protected]>--- drivers/staging/rtl8712/rtl8712_recv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/rtl8712/rtl8712_recv.c +3
-3@@ -135,7 +135,7 @@ int r8712_free_recvframe(union recv_frame *precvframe,spin_lock_irqsave (&pfree_recv_queue->lock, irqL);list_del_init (&(precvframe->u.hdr.list));list_add_tail (&(precvframe->u.hdr.list), &pfree_recv_queue->queue); -if (padapter !=NULL ) { +if (padapter) {if (pfree_recv_queue == &precvpriv->free_recv_queue) precvpriv->free_recvframe_cnt++; }@@ -273,7 +273,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,/* 0~(n-1) fragment frame * enqueue to defraf_g */ -if (pdefrag_q !=NULL ) { +if (pdefrag_q) {if (fragnum ==0 ) {/*the first fragment*/ if (!list_empty (&pdefrag_q->queue)) {@@ -299,7 +299,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,/* the last fragment frame * enqueue the last fragment */ -if (pdefrag_q !=NULL ) { +if (pdefrag_q) { phead = &pdefrag_q->queue;list_add_tail (&pfhdr->list, phead);/*call recvframe_defrag to defrag*/
drivers/staging/rtl8712/rtl8712_recv.c union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter, · line 316
Quoted 5 lines
drivers/staging/rtl8712/rtl8712_recv.c +1
-1@@ -313,7 +313,7 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter, prtnframe =NULL ; } } -if ((prtnframe !=NULL ) && (prtnframe->u.hdr.attrib.privacy)) { +if ((prtnframe) && (prtnframe->u.hdr.attrib.privacy)) {
You don't need the parentheses on prtnfram either.
julia
Quoted 22 lines
drivers/staging/rtl8712/rtl8712_recv.c +1
-2/* after defrag we must check tkip mic code */ if (r8712_recvframe_chkmic (padapter, prtnframe) == _FAIL) {r8712_free_recvframe (prtnframe, pfree_recv_queue);@@ -889,7 +889,7 @@ static void process_link_qual(struct _adapter *padapter,struct rx_pkt_attrib *pattrib;struct smooth_rssi_data *sqd = &padapter->recvpriv.signal_qual_data; -if (prframe ==NULL || padapter ==NULL ) +if (!prframe || !padapter)return ; pattrib = &prframe->u.hdr.attrib;if (pattrib->signal_qual !=0 ) { --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551963249-12892-1-git-send-email-daniela.mormocea%40gmail.com.
For more options, visit https://groups.google.com/d/optout.