drm/amd/amdgpu: fix incorrect translation about the PCIe MLW info
Subsystems (2)
PATCH 1/1 drm/amd/amdgpu: fix incorrect translation about the PCIe MLW info
Max Link Width's full mask is 0x3f,
and it's highest bit express X16.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +2 -10
@@ -3763,15 +3763,6 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) }else {switch (platform_link_width) {case PCIE_LNK_X32 : - adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X32 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 ); -break ; -case PCIE_LNK_X16 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |
@@ -3779,13 +3770,14 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev)CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X1);break ; -case PCIE_LNK_X12 : +case PCIE_LNK_X16 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 );break ; +case PCIE_LNK_X12 :case PCIE_LNK_X8 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 |
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1552969591-13386-1-git-send-email-Jack.Gui-5C7GfCeVMHo@public.gmane.org
Quoted 30 lines · Chengming Gui
Max Link Width's full mask is
0x3f,
and it's highest bit express X16.Signed-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-9@@ -3763,15 +3763,6 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) }else {switch (platform_link_width) {case PCIE_LNK_X32 : - adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X32 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 ); -break ; -case PCIE_LNK_X16 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) · line 3773
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1@@ -3779,13 +3770,14 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev)CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X1);break ; -case PCIE_LNK_X12 : +case PCIE_LNK_X16 :
Not sure I understand this change or the one below. If we have a x16 link, why don't you want CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 set?
Alex
Quoted 13 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 |CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 );break ; +case PCIE_LNK_X12 :case PCIE_LNK_X8 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_Pkr6FAHjZpZdYzK74qykV0YBVkP1taci1QP7yQQ=7u1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Hi Alex,
I will rethink the patch.
Polaris10 encounted issue about the PCIe dpm feature (some platform, not all). If we update pcie table with X16 link width, system will hang, But update with X8, our driver will modprobe successfully.
The link width got from the config register is real X16.
Could you give me some insight for this?
BR,
Jack Gui
-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Tuesday, March 19, 2019 10:43 PM
To: Gui, Jack <[email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH] drm/amd/amdgpu: fix incorrect translation about the PCIe MLW info
Quoted 34 lines · Chengming Gui
Max Link Width's full mask is
0x3f,
and it's highest bit express X16.Signed-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-9@@ -3763,15 +3763,6 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) }else {switch (platform_link_width) {case PCIE_LNK_X32 : - adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X32 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 ); -break ; -case PCIE_LNK_X16 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X8| @@ -3779,13 +3770,14 @@ static voidamdgpu_device_get_pcie_info(struct amdgpu_device *adev)CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X1); break;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) · line 3773
Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1-case PCIE_LNK_X12 : +case PCIE_LNK_X16 :
Not sure I understand this change or the one below. If we have a x16 link, why don't you want CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 set?
Alex
Quoted 10 lines
adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X1);
break;
+ case PCIE_LNK_X12:
case PCIE_LNK_X8:
adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 |Quoted 8 lines
CAIL_PCIE_LINK_WIDTH_SUPPORT_X4|
--
2.7.4_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): MN2PR12MB35821A29C60457C092C5C2528B410-rweVpJHSKTr2mYjuiDFEwwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Hi Jack,
Is the failure happens at link width training at X12?
Thanks
Feifei
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Gui, Jack
Sent: Wednesday, March 20, 2019 4:22 PM
To: Alex Deucher <[email protected]>
Cc: amd-gfx list <[email protected]>
Subject: RE: [PATCH] drm/amd/amdgpu: fix incorrect translation about the PCIe MLW info
Hi Alex,
I will rethink the patch.
Polaris10 encounted issue about the PCIe dpm feature (some platform, not all).
If we update pcie table with X16 link width, system will hang, But update with X8, our driver will modprobe successfully. The link width got from the config register is real X16.
Could you give me some insight for this?
BR,
Jack Gui
-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Tuesday, March 19, 2019 10:43 PM
To: Gui, Jack <[email protected]>
Cc: amd-gfx list <[email protected]>
Subject: Re: [PATCH] drm/amd/amdgpu: fix incorrect translation about the PCIe MLW info
Quoted 35 lines · Chengming Gui
Max Link Width's full mask is
0x3f,
and it's highest bit express X16.Signed-off-by Chengming Gui <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0
-9@@ -3763,15 +3763,6 @@ static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) }else {switch (platform_link_width) {case PCIE_LNK_X32 : - adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X32 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | -CAIL_PCIE_LINK_WIDTH_SUPPORT_X1 ); -break ; -case PCIE_LNK_X16 : adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 |
CAIL_PCIE_LINK_WIDTH_SUPPORT_X12|
CAIL_PCIE_LINK_WIDTH_SUPPORT_X8| @@ -3779,13 +3770,14 @@ static voidamdgpu_device_get_pcie_info(struct amdgpu_device *adev)CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X1); break;
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev) · line 3773
Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1
-1-case PCIE_LNK_X12 : +case PCIE_LNK_X16 :
Not sure I understand this change or the one below. If we have a x16 link, why don't you want CAIL_PCIE_LINK_WIDTH_SUPPORT_X16 set?
Alex
Quoted 11 lines
adev->pm.pcie_mlw_mask = (CAIL_PCIE_LINK_WIDTH_SUPPORT_X12 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X8 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X4 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X2 | CAIL_PCIE_LINK_WIDTH_SUPPORT_X1); break; + case PCIE_LNK_X12: case PCIE_LNK_X8: adev->pm.pcie_mlw_mask =(
CAIL_PCIE_LINK_WIDTH_SUPPORT_X8|
Quoted 8 lines
CAIL_PCIE_LINK_WIDTH_SUPPORT_X4|
--
2.7.4_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx