Convert Pico i.MX7 to DM
Subsystems (2)
v2 cover Convert Pico i.MX7 to DM
This series convert Pico i.MX7 and variant board to DM. The following options have been enabled:
-CONFIG_DM_GPIO
-CONFIG_DM_EMMC
---
Change in v2:
- add missing dtb in Makefile
Joris Offouga (5):
Arm: imx7d-pico: Import all Linux device tree for Pico i.MX7D SOM
pico-imx7d: defconfig: Add DT file hooks
pico-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
pico-imx7d: Convert DM MMC
pico-imx7d: Increase u-boot size for dfu request
arch/arm/dts/Makefile | 5 +- arch/arm/dts/imx7d-pico-hobbit.dts | 105 ++++++ arch/arm/dts/imx7d-pico-pi.dts | 93 +++++ arch/arm/dts/imx7d-pico.dtsi | 590 +++++++++++++++++++++++++++++++ board/technexion/pico-imx7d/pico-imx7d.c | 42 +-- board/technexion/pico-imx7d/spl.c | 38 ++ configs/pico-hobbit-imx7d_defconfig | 7 +- configs/pico-imx7d_defconfig | 7 +- configs/pico-pi-imx7d_defconfig | 7 +- include/configs/pico-imx7d.h | 2 +- 10 files changed, 852 insertions(+), 44 deletions(-) create mode 100644 arch/arm/dts/imx7d-pico-hobbit.dts create mode 100644 arch/arm/dts/imx7d-pico-pi.dts create mode 100644 arch/arm/dts/imx7d-pico.dtsi
Signature · 1 line
2.7.4
PATCH v2 1/5 Arm: imx7d-pico: Import all Linux device tree for Pico i.MX7D SOM
This patch imports the Linux kernel base board imx7d-pico.dtsi, pi board imx7d-pico-pi.dts and hobbit board imx7d-pico-hobbit.dts from Linux v5.1-rc1.
--- arch/arm/dts/Makefile | 5 +- arch/arm/dts/imx7d-pico-hobbit.dts | 105 +++++++ arch/arm/dts/imx7d-pico-pi.dts | 93 ++++++ arch/arm/dts/imx7d-pico.dtsi | 586 +++++++++++++++++++++++++++++++++++++ 4 files changed, 788 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/imx7d-pico-hobbit.dts create mode 100644 arch/arm/dts/imx7d-pico-pi.dts create mode 100644 arch/arm/dts/imx7d-pico.dtsi
arch/arm/dts/Makefile +4 -1
@@ -544,7 +544,10 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \ imx7d-sdb-qspi.dtb \ imx7-colibri-emmc.dtb \ imx7-colibri-rawnand.dtb \ - imx7s-warp.dtb + imx7s-warp.dtb \ + imx7d-pico-pi.dtb \ + imx7d-pico-hobbit.dtb + dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
arch/arm/dts/imx7d-pico-hobbit.dts new file +105 -0
106 lines not on this page · raw message
arch/arm/dts/imx7d-pico-pi.dts new file +93 -0
94 lines not on this page · raw message
arch/arm/dts/imx7d-pico.dtsi new file +586 -0
587 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v2 1/5 Arm: imx7d-pico: Import all Linux device tree for Pico i.MX7D SOM
Quoted 4 lines
This patch imports the Linux kernel base board
imx7d-pico.dtsi, pi boardimx7d-pico-pi.dtsand hobbit boardimx7d-pico-hobbit.dtsfrom Linux v5.1-rc1.Signed-off-by Joris Offouga <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
In reply to Joris OffougaThis patch adds DT file hooks for Pico i.MX7D SOM and variant boards
--- configs/pico-hobbit-imx7d_defconfig | 3 ++- configs/pico-imx7d_defconfig | 3 ++- configs/pico-pi-imx7d_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-)
configs/pico-hobbit-imx7d_defconfig +2 -1
@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit" CONFIG_BOUNCE_BUFFER=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_USB_HOST_SUPPORT=y
@@ -58,4 +60,3 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y CONFIG_VIDEO=y -CONFIG_OF_LIBFDT=y
configs/pico-imx7d_defconfig +2 -1
@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="ask" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico" CONFIG_BOUNCE_BUFFER=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_USB_HOST_SUPPORT=y
@@ -58,4 +60,3 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y CONFIG_VIDEO=y -CONFIG_OF_LIBFDT=y
configs/pico-pi-imx7d_defconfig +2 -1
@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-pi.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi" CONFIG_BOUNCE_BUFFER=y CONFIG_SPL_I2C_SUPPORT=y CONFIG_SPL_USB_HOST_SUPPORT=y
@@ -58,4 +60,3 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 CONFIG_CI_UDC=y CONFIG_VIDEO=y -CONFIG_OF_LIBFDT=y
Signature · 1 line
2.7.4
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Quoted 14 lines · Joris Offouga
This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
Signed-off-by Joris Offouga <[email protected]>--- configs/pico-hobbit-imx7d_defconfig | 3 ++- configs/pico-imx7d_defconfig | 3 ++- configs/pico-pi-imx7d_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-)configs/pico-hobbit-imx7d_defconfig +0
-0
configs/pico-hobbit-imx7d_defconfig CONFIG_NR_DRAM_BANKS=1 · line 20
Quoted 5 lines
configs/pico-hobbit-imx7d_defconfig +2
-0@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"
^--- two much "o"
I fix this myself by merging.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Quoted 23 lines · Stefano Babic
Review
Quoted 10 lines · Joris Offouga
This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
Signed-off-by Joris Offouga <[email protected]>--- configs/pico-hobbit-imx7d_defconfig | 3 ++- configs/pico-imx7d_defconfig | 3 ++- configs/pico-pi-imx7d_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/configs/pico-hobbit-imx7d_defconfig
configs/pico-hobbit-imx7d_defconfig CONFIG_NR_DRAM_BANKS=1 · line 20
Quoted 9 lines
index f58d517..75eab28 100644
configs/pico-hobbit-imx7d_defconfig +2
-0@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"^--- two much "o"
Quoted 2 lines
I fix this myself by merging.
Thanks
Quoted 13 lines
Best regards,
Stefano Babic--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
In reply to Stefano BabicQuoted 22 lines · Stefano Babic
Quoted 14 lines · Joris Offouga
This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
Signed-off-by Joris Offouga <[email protected]>--- configs/pico-hobbit-imx7d_defconfig | 3 ++- configs/pico-imx7d_defconfig | 3 ++- configs/pico-pi-imx7d_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-)configs/pico-hobbit-imx7d_defconfig +0
-0configs/pico-hobbit-imx7d_defconfig CONFIG_NR_DRAM_BANKS=1 · line 20
Quoted 5 lines
configs/pico-hobbit-imx7d_defconfig +2
-0@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"^--- two much "o"
Quoted 3 lines
I fix this myself by merging.
However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there is no pico-imx7d.dts, but CONFIG_DEFAULT_DEVICE_TREE is set. Am I missing something ?
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Quoted 24 lines · Stefano Babic
Quoted 11 lines · Stefano Babic
Review
Quoted 10 lines · Joris Offouga
This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
Signed-off-by Joris Offouga <[email protected]>--- configs/pico-hobbit-imx7d_defconfig | 3 ++- configs/pico-imx7d_defconfig | 3 ++- configs/pico-pi-imx7d_defconfig | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/configs/pico-hobbit-imx7d_defconfig
Quoted 11 lines
configs/pico-hobbit-imx7d_defconfig CONFIG_NR_DRAM_BANKS=1 · line 20
Quoted 9 lines
index f58d517..75eab28 100644
configs/pico-hobbit-imx7d_defconfig +2
-0@@ -16,6 +16,8 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" +CONFIG_OF_CONTROL=y +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"^--- two much "o"
Quoted 8 lines
Quoted 3 lines
I fix this myself by merging.
However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there is no
pico-imx7d.dts, butCONFIG_DEFAULT_DEVICE_TREEis set. Am I missing something ?
No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
Joris Offouga
Quoted 12 lines
Best regards,
Stefano Babic--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Quoted 34 lines · Joris OFFOUGA
Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <[email protected] <mailto:[email protected]>> a écrit :
On 25/04/19 11:00, Stefano Babic wrote:
> On 04/04/19 14:00, Joris Offouga wrote:
>> This patch adds DT file hooks for Pico i.MX7D SOM and variant boards >>
>> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
>> ---
>> configs/pico-hobbit-imx7d_defconfig | 3 ++-
>> configs/pico-imx7d_defconfig | 3 ++-
>> configs/pico-pi-imx7d_defconfig | 3 ++-
>> 3 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/pico-hobbit-imx7d_defconfig b/configs/pico-hobbit-imx7d_defconfig
>> index f58d517..75eab28 100644
>> --- a/configs/pico-hobbit-imx7d_defconfig
>> +++ b/configs/pico-hobbit-imx7d_defconfig
>> @@ -16,6 +16,8 @@CONFIG_NR_DRAM_BANKS=1
>>CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" >>CONFIG_BOOTCOMMAND="runfindfdt; run finduuid; rundistro_bootcmd" >>CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb"
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"
> ^--- two much "o" >
> I fix this myself by merging.
>
>
Quoted 6 lines
However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there is no
pico-imx7d.dts, butCONFIG_DEFAULT_DEVICE_TREEis set. Am I missing something ?No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
I suppose this, but then something in the build is broken, If I run buildman, a pico-imx7d board is searched. In fact, there is a configs/pico-imx7d_defconfig. If this is just SOM, this file has no reason to exist.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Le 25/04/2019 à 11:26, Stefano Babic a écrit :
Quoted 38 lines · Joris OFFOUGA
Quoted 37 lines
Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <[email protected] <mailto:[email protected]>> a écrit :
On 25/04/19 11:00, Stefano Babic wrote:
> On 04/04/19 14:00, Joris Offouga wrote:
>> This patch adds DT file hooks for Pico i.MX7D SOM and variant boards >>
>> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
>> ---
>> configs/pico-hobbit-imx7d_defconfig | 3 ++-
>> configs/pico-imx7d_defconfig | 3 ++-
>> configs/pico-pi-imx7d_defconfig | 3 ++-
>> 3 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/pico-hobbit-imx7d_defconfig b/configs/pico-hobbit-imx7d_defconfig
>> index f58d517..75eab28 100644
>> --- a/configs/pico-hobbit-imx7d_defconfig
>> +++ b/configs/pico-hobbit-imx7d_defconfig
>> @@ -16,6 +16,8 @@CONFIG_NR_DRAM_BANKS=1
>>CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" >>CONFIG_BOOTCOMMAND="runfindfdt; run finduuid; rundistro_bootcmd" >>CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb"
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"
> ^--- two much "o" >
> I fix this myself by merging.
>
>However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there is no
pico-imx7d.dts, butCONFIG_DEFAULT_DEVICE_TREEis set. Am I missing something ?
Quoted 6 lines
Quoted 2 lines
No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
I suppose this, but then something in the build is broken, If I run buildman, a pico-imx7d board is searched. In fact, there is a configs/pico-imx7d_defconfig. If this is just SOM, this file has no reason to exist.
For pico_imx7d_defconfig, i setCONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi.dtb"
You have to ask Fabio and Otavio I did not grow on it when I did the dm conversion, they asked me to convert everything even som
Best Regards,
Joris Offouga
Quoted 4 lines
Best regards,
Stefano Babic
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Quoted 46 lines · Joris Offouga
Le 25/04/2019 à 11:26, Stefano Babic a écrit :
Quoted 44 lines · Joris OFFOUGA
Quoted 43 lines
Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <[email protected] <mailto:[email protected]>> a écrit :
On 25/04/19 11:00, Stefano Babic wrote:
> On 04/04/19 14:00, Joris Offouga wrote:
>> This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
>>
>> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
>> ---
>> configs/pico-hobbit-imx7d_defconfig | 3 ++-
>> configs/pico-imx7d_defconfig | 3 ++-
>> configs/pico-pi-imx7d_defconfig | 3 ++-
>> 3 files changed, 6 insertions(+), 3 deletions(-) >>
>> diff --git a/configs/pico-hobbit-imx7d_defconfig b/configs/pico-hobbit-imx7d_defconfig
>> index f58d517..75eab28 100644
>> --- a/configs/pico-hobbit-imx7d_defconfig
>> +++ b/configs/pico-hobbit-imx7d_defconfig
>> @@ -16,6 +16,8 @@CONFIG_NR_DRAM_BANKS=1
>>CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg" >>CONFIG_BOOTCOMMAND="runfindfdt; run finduuid; rundistro_bootcmd"
>>CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" >> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit"
> ^--- two much "o" >
> I fix this myself by merging.
>
>However, this fix pico-hobbit-imx7d, but not pico-imx7d. In fact, there
is nopico-imx7d.dts, butCONFIG_DEFAULT_DEVICE_TREEis set. Am I missing something ?No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
Quoted 8 lines
Quoted 4 lines
I suppose this, but then something in the build is broken, If I run buildman, a pico-imx7d board is searched. In fact, there is a configs/pico-imx7d_defconfig. If this is just SOM, this file has no reason to exist.
For
pico_imx7d_defconfig, i setCONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi.dtb"
This is not what I see in your patch
http://patchwork.ozlabs.org/patch/1077223/:
+CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico"
I fix myself in the defconfig.
Quoted 2 lines
You have to ask Fabio and Otavio I did not grow on it when I did the dm conversion, they asked me to convert everything even som
Just SOM it is quite weird if there is not an evaluation board to support it. Anyway, I fix the name, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
Le 25/04/2019 à 12:28, Stefano Babic a écrit :
Quoted 52 lines · Joris Offouga
Quoted 42 lines
Le 25/04/2019 à 11:26, Stefano Babic a écrit :
Quoted 41 lines · Joris OFFOUGA
Quoted 40 lines
Le jeu. 25 avr. 2019 à 11:12, Stefano Babic <[email protected] <mailto:[email protected]>> a écrit :
On 25/04/19 11:00, Stefano Babic wrote:
> On 04/04/19 14:00, Joris Offouga wrote:
>> This patch adds DT file hooks for Pico i.MX7D SOM and variant
boards
>>
>> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
>> --->> configs/pico-hobbit-imx7d_defconfig | 3 ++- >> configs/pico-imx7d_defconfig | 3 ++- >> configs/pico-pi-imx7d_defconfig | 3 ++->> 3 files changed, 6 insertions(+), 3 deletions(-) >>
>> diff --git a/configs/pico-hobbit-imx7d_defconfig b/configs/pico-hobbit-imx7d_defconfig
>> index f58d517..75eab28 100644
>> --- a/configs/pico-hobbit-imx7d_defconfig
>> +++ b/configs/pico-hobbit-imx7d_defconfig
>> @@ -16,6 +16,8 @@CONFIG_NR_DRAM_BANKS=1
>>CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg"
>>CONFIG_BOOTCOMMAND="runfindfdt; run finduuid; rundistro_bootcmd"
>>CONFIG_DEFAULT_FDT_FILE="imx7d-pico-hobbit.dtb" >> +CONFIG_OF_CONTROL=y
>> +CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-hoobit" > ^--- two much "o" >
> I fix this myself by merging.
>
>However, this fix pico-hobbit-imx7d, but not pico-imx7d. In
fact, there
is nopico-imx7d.dts, butCONFIG_DEFAULT_DEVICE_TREEis set. Am I missing something ?Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
No it's just som he does not need to CONFIG_DEFAULT_DEVICE_TREE Best regards,
I suppose this, but then something in the build is broken, If I run buildman, a pico-imx7d board is searched. In fact, there is a configs/pico-imx7d_defconfig. If this is just SOM, this file has no reason to exist.
For
pico_imx7d_defconfig, i setCONFIG_DEFAULT_DEVICE_TREE="imx7d-pico-pi.dtb"
Quoted 6 lines
This is not what I see in your patch
http://patchwork.ozlabs.org/patch/1077223/:+CONFIG_DEFAULT_DEVICE_TREE="imx7d-pico"
I fix myself in the defconfig.
Sorry for the mistake and thanks.
Quoted 4 lines
Quoted 2 lines
You have to ask Fabio and Otavio I did not grow on it when I did the dm conversion, they asked me to convert everything even som
Just SOM it is quite weird if there is not an evaluation board to support it. Anyway, I fix the name, thanks.
Thanks Stefano
Quoted 3 lines
Best regards,
Stefano Babic
Best regards,
Joris Offouga
Quoted 1 line
Fabio Estevam
reviewerPATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
In reply to Stefano BabicHi Stefano,
Quoted 2 lines · Stefano Babic
Just SOM it is quite weird if there is not an evaluation board to support it. Anyway, I fix the name, thanks.
Yes, for U-Boot purpose we can either use:
imx7d-pico-pi or imx7d-pico-hobbit for the CONFIG_DEFAULT_DEVICE_TREE option.
Both will work fine.
Thanks for fixing it.
PATCH v2 2/5 pico-imx7d: defconfig: Add DT file hooks
In reply to Joris OffougaQuoted 2 lines
This patch adds DT file hooks for Pico i.MX7D SOM and variant boards
Signed-off-by Joris Offouga <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 3/5 pico-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
In reply to Joris OffougaThis patch is necessary for convert this board to dm driver model
DM GPIO requires gpio_request() to be called explicitly before doing any gpio operation
--- board/technexion/pico-imx7d/pico-imx7d.c | 4 +++- configs/pico-hobbit-imx7d_defconfig | 3 +++ configs/pico-imx7d_defconfig | 3 +++ configs/pico-pi-imx7d_defconfig | 3 +++ 4 files changed, 12 insertions(+), 1 deletion(-)
board/technexion/pico-imx7d/pico-imx7d.c +3 -1
@@ -165,7 +165,7 @@ static iomux_v3_cfg_t const fec1_pads[] = {static void setup_iomux_fec (void ) {imx_iomux_v3_setup_multiple_pads (fec1_pads,ARRAY_SIZE (fec1_pads)); - +gpio_request (FEC1_RST_GPIO ,"phy_rst" );gpio_direction_output (FEC1_RST_GPIO ,0 );udelay (500 );gpio_set_value (FEC1_RST_GPIO ,1 );
@@ -291,6 +291,8 @@ static iomux_v3_cfg_t const lcd_pads[] = {void setup_lcd (void ) {imx_iomux_v3_setup_multiple_pads (lcd_pads,ARRAY_SIZE (lcd_pads)); +gpio_request (IMX_GPIO_NR (1 ,11 ),"lcd_brightness" ); +gpio_request (IMX_GPIO_NR (1 ,6 ),"lcd_enable" );/* Set Brightness to high */ gpio_direction_output (IMX_GPIO_NR (1 ,11 ) ,1 );/* Set LCD enable to high */
configs/pico-hobbit-imx7d_defconfig +3 -0
@@ -27,6 +27,9 @@ CONFIG_SPL_USB_SDP_SUPPORT=y CONFIG_CMD_BOOTMENU=y # CONFIG_CMD_IMI is not set # CONFIG_CMD_XIMG is not set +CONFIG_PINCTRL=y +CONFIG_PINCTRL_IMX7=y +CONFIG_DM_GPIO=y CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y
configs/pico-imx7d_defconfig +3 -0
@@ -27,6 +27,9 @@ CONFIG_SPL_USB_SDP_SUPPORT=y CONFIG_CMD_BOOTMENU=y # CONFIG_CMD_IMI is not set # CONFIG_CMD_XIMG is not set +CONFIG_PINCTRL=y +CONFIG_PINCTRL_IMX7=y +CONFIG_DM_GPIO=y CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y
configs/pico-pi-imx7d_defconfig +3 -0
@@ -27,6 +27,9 @@ CONFIG_SPL_USB_SDP_SUPPORT=y CONFIG_CMD_BOOTMENU=y # CONFIG_CMD_IMI is not set # CONFIG_CMD_XIMG is not set +CONFIG_PINCTRL=y +CONFIG_PINCTRL_IMX7=y +CONFIG_DM_GPIO=y CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y
Signature · 1 line
2.7.4
PATCH v2 3/5 pico-imx7d: defconfig Enable DM gpio pinctrl and pinctrl_imx7
Quoted 4 lines
This patch is necessary for convert this board to dm driver model DM GPIO requires
gpio_request()to be called explicitly before doing any gpio operationSigned-off-by Joris Offouga <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 4/5 pico-imx7d: Convert DM MMC
In reply to Joris OffougaThis patch enable convert DM MMC for imx7d-pico board and variant.
Before the DM conversion only usdhc3 was enabled and therefore it appeared as MMC 0 to u-boot. After enabling MMC DM though usdhc3 defaults to MMC 2, which left unattended would drive changes to existing pico-pi bootscripts and environment variables that rely on mmc 0.
Setup the alias of mmc0 and usdhc3 so that existing pico-imx7d boot code will work unmodified.
When converting to DM_MMC it is necessary that SPL initializes eMMC by itself, so move the original eMMC initialization from U-Boot proper to SPL.
--- arch/arm/dts/imx7d-pico.dtsi | 4 ++++ board/technexion/pico-imx7d/pico-imx7d.c | 38 -------------------------------- board/technexion/pico-imx7d/spl.c | 38 ++++++++++++++++++++++++++++++++ configs/pico-hobbit-imx7d_defconfig | 1 + configs/pico-imx7d_defconfig | 1 + configs/pico-pi-imx7d_defconfig | 1 + 6 files changed, 45 insertions(+), 38 deletions(-)
arch/arm/dts/imx7d-pico.dtsi +4 -0
@@ -8,6 +8,10 @@ / { + aliases { + mmc0 = &usdhc3; + }; + /* Will be filled by the bootloader */ memory at 80000000 { device_type = "memory";
board/technexion/pico-imx7d/pico-imx7d.c +0 -38
@@ -13,10 +13,8 @@#include <asm/mach-imx/mxc_i2c.h> #include <asm/io.h> #include <common.h> -#include <fsl_esdhc.h> #include <i2c.h> #include <miiphy.h> -#include <mmc.h> #include <netdev.h> #include <usb.h> #include <power/pmic.h>
@@ -28,9 +26,6 @@ DECLARE_GLOBAL_DATA_PTR;#define UART_PAD_CTRL (PAD_CTL_DSE_3P3V_49OHM | \ PAD_CTL_PUS_PU100KOHM | PAD_CTL_HYS) -#define USDHC_PAD_CTRL (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \ - PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM) -#define ENET_PAD_CTRL (PAD_CTL_PUS_PU100KOHM | PAD_CTL_DSE_3P3V_49OHM)#define ENET_PAD_CTRL_MII (PAD_CTL_DSE_3P3V_32OHM)
@@ -126,20 +121,6 @@ static iomux_v3_cfg_t const uart5_pads[] = { MX7D_PAD_I2C4_SDA__UART5_DCE_TX | MUX_PAD_CTRL(UART_PAD_CTRL), }; -static iomux_v3_cfg_t const usdhc3_emmc_pads[] = { -MX7D_PAD_SD3_CLK__SD3_CLK |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_CMD__SD3_CMD |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA0__SD3_DATA0 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA1__SD3_DATA1 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA2__SD3_DATA2 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA3__SD3_DATA3 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA4__SD3_DATA4 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA5__SD3_DATA5 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA6__SD3_DATA6 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_SD3_DATA7__SD3_DATA7 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -MX7D_PAD_GPIO1_IO14__GPIO1_IO14 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), -}; -#ifdef CONFIG_FEC_MXC static iomux_v3_cfg_t const fec1_pads[] = { MX7D_PAD_SD2_CD_B__ENET1_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL_MII),
@@ -224,25 +205,6 @@ static void setup_iomux_uart(void)imx_iomux_v3_setup_multiple_pads (uart5_pads,ARRAY_SIZE (uart5_pads)); } -static struct fsl_esdhc_cfg usdhc_cfg[1 ] = { - {USDHC3_BASE_ADDR }, -}; - -int board_mmc_getcd (struct mmc *mmc) -{ -/* Assume uSDHC3 emmc is always present */ -return 1 ; -} - -int board_mmc_init (bd_t *bis) -{ -imx_iomux_v3_setup_multiple_pads ( - usdhc3_emmc_pads,ARRAY_SIZE (usdhc3_emmc_pads)); - usdhc_cfg[0 ].sdhc_clk =mxc_get_clock (MXC_ESDHC3_CLK ); - -return fsl_esdhc_initialize (bis, &usdhc_cfg[0 ]); -} -int board_early_init_f (void ) {setup_iomux_uart ();
board/technexion/pico-imx7d/spl.c +38 -0
@@ -5,11 +5,15 @@* Author: Richard Hu <[email protected]> */ +#include <asm/arch/clock.h> #include <asm/arch/imx-regs.h> #include <asm/arch/crm_regs.h> +#include <asm/arch/mx7-pins.h> #include <asm/arch/sys_proto.h> #include <asm/arch-mx7/mx7-ddr.h> +#include <asm/mach-imx/iomux-v3.h> #include <asm/gpio.h> +#include <fsl_esdhc.h> #include <spl.h> #if defined(CONFIG_SPL_BUILD )
@@ -119,4 +123,38 @@ void board_init_f(ulong dummy)void reset_cpu (ulong addr) { } + +#define USDHC_PAD_CTRL (PAD_CTL_DSE_3P3V_32OHM | PAD_CTL_SRE_SLOW | \ + PAD_CTL_HYS | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM) + +static iomux_v3_cfg_t const usdhc3_pads[] = { +MX7D_PAD_SD3_CLK__SD3_CLK |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_CMD__SD3_CMD |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA0__SD3_DATA0 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA1__SD3_DATA1 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA2__SD3_DATA2 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA3__SD3_DATA3 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA4__SD3_DATA4 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA5__SD3_DATA5 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA6__SD3_DATA6 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_SD3_DATA7__SD3_DATA7 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +MX7D_PAD_GPIO1_IO14__GPIO1_IO14 |MUX_PAD_CTRL (USDHC_PAD_CTRL ), +}; + +static struct fsl_esdhc_cfg usdhc_cfg[1 ] = { + {USDHC3_BASE_ADDR }, +}; + +int board_mmc_getcd (struct mmc *mmc) +{ +/* Assume uSDHC3 emmc is always present */ +return 1 ; +} + +int board_mmc_init (bd_t *bis) +{ +imx_iomux_v3_setup_multiple_pads (usdhc3_pads,ARRAY_SIZE (usdhc3_pads)); + usdhc_cfg[0 ].sdhc_clk =mxc_get_clock (MXC_ESDHC3_CLK ); +return fsl_esdhc_initialize (bis, &usdhc_cfg[0 ]); +}#endif
configs/pico-hobbit-imx7d_defconfig +1 -0
@@ -34,6 +34,7 @@ CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y CONFIG_CMD_GPIO=y +CONFIG_DM_MMC=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y
configs/pico-imx7d_defconfig +1 -0
@@ -30,6 +30,7 @@ CONFIG_CMD_BOOTMENU=y CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX7=y CONFIG_DM_GPIO=y +CONFIG_DM_MMC=y CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y
configs/pico-pi-imx7d_defconfig +1 -0
@@ -34,6 +34,7 @@ CONFIG_CMD_SPL=y CONFIG_CMD_SPL_WRITE_SIZE=0x20000 CONFIG_CMD_DFU=y CONFIG_CMD_GPIO=y +CONFIG_DM_MMC=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y
Signature · 1 line
2.7.4
PATCH v2 4/5 pico-imx7d: Convert DM MMC
Quoted 10 lines
This patch enable convert DM MMC for imx7d-pico board and variant. Before the DM conversion only usdhc3 was enabled and therefore it appeared as MMC 0 to u-boot. After enabling MMC DM though usdhc3 defaults to MMC 2, which left unattended would drive changes to existing pico-pi bootscripts and environment variables that rely on mmc 0.
Setup the alias of mmc0 and usdhc3 so that existing pico-imx7d boot code will work unmodified.
When converting toDM_MMCit is necessary that SPL initializes eMMC by itself, so move the original eMMC initialization from U-Boot proper to SPL.
Quoted 2 lines
Signed-off-by Joris Offouga <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v2 5/5 pico-imx7d: Increase u-boot size for dfu request
In reply to Joris OffougaAfter DM conversion, the size of U-Boot binary to increase. Previous size is 480K after DM Conversion the new size is 557K
So it's necessary to increase the dfu request for store u-boot-dtb.img in eMMC.
--- include/configs/pico-imx7d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/pico-imx7d.h +1 -1
@@ -46,7 +46,7 @@#define CONFIG_DFU_ENV_SETTINGS \ "dfu_alt_info=" \ "spl raw 0x2 0x400;" \ - "u-boot raw 0x8a 0x400;" \ + "u-boot raw 0x8a 0x1000;" \ "/boot/zImage ext4 0 1;" \ "/boot/imx7d-pico-hobbit.dtb ext4 0 1;" \ "/boot/imx7d-pico-pi.dtb ext4 0 1;" \
Signature · 1 line
2.7.4
PATCH v2 5/5 pico-imx7d: Increase u-boot size for dfu request
Quoted 4 lines
After DM conversion, the size of U-Boot binary to increase. Previous size is 480K after DM Conversion the new size is 557K
So it's necessary to increase the dfu request for store u-boot-dtb.img in eMMC.Signed-off-by Joris Offouga <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerv2 cover Convert Pico i.MX7 to DM
In reply to Joris OffougaHi Joris,
Quoted 11 lines · Joris Offouga
This series convert Pico i.MX7 and variant board to DM. The following options have been enabled:
(quoted diff) +0
-2-CONFIG_DM_GPIO -CONFIG_DM_EMMCSigned-off-by Joris Offouga <[email protected]>---
Change in v2:
- add missing dtb inMakefile
Thanks for working on this series.
My previous Tested-by tag still applies here as well :-)
For the entire series:
v2 cover Convert Pico i.MX7 to DM
Le ven. 5 avr. 2019 à 15:07, Fabio Estevam <[email protected]> a écrit :
Quoted 2 lines
Hi Joris,
Hi Fabio,
Quoted 8 lines
Quoted 6 lines · Joris Offouga
This series convert Pico i.MX7 and variant board to DM. The following options have been enabled:
(quoted diff) +0
-2-CONFIG_DM_GPIO -CONFIG_DM_EMMC
Quoted 8 lines
Quoted 5 lines
Signed-off-by Joris Offouga <[email protected]>---
Change in v2:
- add missing dtb inMakefileThanks for working on this series.
It was a pleasure I learned a lot �
Quoted 7 lines
My previous Tested-by tag still applies here as well :-)
For the entire series:
Tested-by Fabio Estevam <[email protected]>
Thanks Fabio,
v2 cover Convert Pico i.MX7 to DM
Hi Stefano
I think this series should be applied for 2019.04 ?
BR
Joris
Le 05/04/2019 à 15:28, Joris OFFOUGA a écrit :
Quoted 39 lines
Le ven. 5 avr. 2019 à 15:07, Fabio Estevam <[email protected] <mailto:[email protected]>> a écrit :
Hi Joris,
Hi Fabio,
On Thu, Apr 4, 2019 at 9:01 AM Joris Offouga <offougajoris at gmail.com <mailto:[email protected]>> wrote:
>
> This series convert Pico i.MX7 and variant board to DM. > The following options have been enabled:
> -CONFIG_DM_GPIO
> -CONFIG_DM_EMMC
>
> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
> ---
>
> Change in v2:
> - add missing dtb inMakefileThanks for working on this series.
It was a pleasure I learned a lot �
My previous Tested-by tag still applies here as well :-)
For the entire series:
Tested-by Fabio Estevam <[email protected]<mailto:[email protected]>>
Thanks Fabio,
v2 cover Convert Pico i.MX7 to DM
Quoted 3 lines · jorisoffouga
Hi Stefano
I think this series should be applied for 2019.04 ?
2019.04 is out, this goes to 2019.07
Stefano
Quoted 45 lines
BR
Joris
Le 05/04/2019 à 15:28, Joris OFFOUGA a écrit :
Quoted 39 lines
Le ven. 5 avr. 2019 à 15:07, Fabio Estevam <[email protected] <mailto:[email protected]>> a écrit :
Hi Joris,
Hi Fabio,Â
On Thu, Apr 4, 2019 at 9:01 AM Joris Offouga <offougajoris at gmail.com <mailto:[email protected]>> wrote:
>
> This series convert Pico i.MX7 and variant board to DM. > The following options have been enabled:
> -CONFIG_DM_GPIO
> -CONFIG_DM_EMMC
>
> Signed-off-by: Joris Offouga <[email protected] <mailto:[email protected]>>
> ---
>
> Change in v2:
> - add missing dtb inMakefileThanks for working on this series.
It was a pleasure I learned a lot �
My previous Tested-by tag still applies here as well :-)
For the entire series:
Tested-by Fabio Estevam <[email protected]<mailto:[email protected]>>
Thanks Fabio,Â
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerv2 cover Convert Pico i.MX7 to DM
Hi Stefano,
Quoted 7 lines · Stefano Babic
Quoted 3 lines · jorisoffouga
Hi Stefano
I think this series should be applied for 2019.04 ?
2019.04 is out, this goes to 2019.07
It seems this series was missed in your first pull request to Tom?
We would like to continue the DM conversion work, so please consider including this series in your next pull request.
Thanks
v2 cover Convert Pico i.MX7 to DM
Quoted 14 lines · Fabio Estevam
Hi Stefano,
On Mon, Apr 15, 2019 at 5:16 AM Stefano Babic <[email protected] <mailto:[email protected]>> wrote:
On 15/04/19 10:02, jorisoffouga wrote: > Hi Stefano > > I think this series should be applied for 2019.04 ? 2019.04 is out, this goes to 2019.07
Quoted 2 lines
It seems this series was missed in your first pull request to Tom?
It was, there is an older series about pico-imx7d that I have to take a look before applying this.
Quoted 2 lines
We would like to continue the DM conversion work, so please consider including this series in your next pull request.
Sure.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================