ath10k: Fix the wrong value of enums for wmi tlv stats id
PATCH 1/1 ath10k: Fix the wrong value of enums for wmi tlv stats id
The enum value for WMI_TLV_STAT_PDEV, WMI_TLV_STAT_VDEV and WMI_TLV_STAT_PEER is wrong, due to which the vdev stats are not received from firmware in wmi_update_stats event.
Fix the enum values for above stats to receive all stats from firmware in WMI_TLV_UPDATE_STATS_EVENTID.
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/wmi.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/ath10k/wmi.h +4 -3
@@ -4535,9 +4535,10 @@ enum wmi_10_4_stats_id { };enum wmi_tlv_stats_id { -WMI_TLV_STAT_PDEV =BIT (0 ), -WMI_TLV_STAT_VDEV =BIT (1 ), -WMI_TLV_STAT_PEER =BIT (2 ), +WMI_TLV_STAT_PEER =BIT (0 ), +WMI_TLV_STAT_AP =BIT (1 ), +WMI_TLV_STAT_PDEV =BIT (2 ), +WMI_TLV_STAT_VDEV =BIT (3 ),WMI_TLV_STAT_PEER_EXTD =BIT (10 ), };
Signature · 7 lines
1.9.1 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 4 lines · Adrian Chadd
What about QCA6174 that uses TLV? Does this change its behaviour?
-a
No, it will not break QCA6174, as earlier also same enum values (wmi_stats_id) were used for TLV targets,
enum wmi_stats_id {
WMI_STAT_PEER = BIT(0),
WMI_STAT_AP = BIT(1),
WMI_STAT_PDEV = BIT(2),
WMI_STAT_VDEV = BIT(3),
WMI_STAT_BCNFLT = BIT(4),
WMI_STAT_VDEV_RATE = BIT(5),
};In the change f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990), enum values for wmi_tlv_stats_id were wrongly added.
Thanks,
Surabhi Vishnoi
Quoted 39 lines
Quoted 36 lines · Surabhi Vishnoi
The enum value for
WMI_TLV_STAT_PDEV,WMI_TLV_STAT_VDEVandWMI_TLV_STAT_PEERis wrong, due to which the vdev stats are not received from firmware inwmi_update_statsevent.Fix the enum values for above stats to receive all stats from firmware in
WMI_TLV_UPDATE_STATS_EVENTID.Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes f40a307eb92c ("ath10k: Fill rx duration for each peer in
fw_statsfor WCN3990)Signed-off-by Surabhi Vishnoi <[email protected]>---
drivers/net/wireless/ath/ath10k/wmi.h| 7 ++++---1 file changed, 4 insertions(+), 3 deletions(-)drivers/net/wireless/ath/ath10k/wmi.h +4
-3@@ -4535,9 +4535,10 @@ enum wmi_10_4_stats_id { };enum wmi_tlv_stats_id { -WMI_TLV_STAT_PDEV =BIT (0 ), -WMI_TLV_STAT_VDEV =BIT (1 ), -WMI_TLV_STAT_PEER =BIT (2 ), +WMI_TLV_STAT_PEER =BIT (0 ), +WMI_TLV_STAT_AP =BIT (1 ), +WMI_TLV_STAT_PDEV =BIT (2 ), +WMI_TLV_STAT_VDEV =BIT (3 ),WMI_TLV_STAT_PEER_EXTD =BIT (10 ), };
Quoted 2 lines
Quoted 2 lines
--
1.9.1
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 7 lines · Surabhi Vishnoi
The enum value for
WMI_TLV_STAT_PDEV,WMI_TLV_STAT_VDEVandWMI_TLV_STAT_PEERis wrong, due to which the vdev stats are not received from firmware inwmi_update_statsevent.Fix the enum values for above stats to receive all stats from firmware in
WMI_TLV_UPDATE_STATS_EVENTID.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990)Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9280f4fc06f4 ath10k: Fix the wrong value of enums for wmi tlv stats id
Signature · 3 lines
https://patchwork.kernel.org/patch/10890577/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 7 lines · Surabhi Vishnoi
The enum value for
WMI_TLV_STAT_PDEV,WMI_TLV_STAT_VDEVandWMI_TLV_STAT_PEERis wrong, due to which the vdev stats are not received from firmware inwmi_update_statsevent.Fix the enum values for above stats to receive all stats from firmware in
WMI_TLV_UPDATE_STATS_EVENTID.
Quoted 6 lines
Tested HW: WCN3990
Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1Fixes f40a307eb92c ("ath10k: Fill rx duration for each peer in fw_stats for WCN3990)Signed-off-by Surabhi Vishnoi <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
9280f4fc06f4 ath10k: Fix the wrong value of enums for wmi tlv stats id
Signature · 9 lines
https://patchwork.kernel.org/patch/10890577/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k