package/gettext-tiny: Fix cyclic dependency with iconv
PATCH 1/2 package/gettext-tiny: Fix cyclic dependency with iconv
From: Vadim Kochan <[email protected]>
target's libiconv is added into host dependency which makes cyclic dependency, anyway this dependency is not needed because of assumption that iconv should be provided by the host.
--- package/gettext-tiny/gettext-tiny.mk | 4 ---- 1 file changed, 4 deletions(-)
package/gettext-tiny/gettext-tiny.mk +0 -4
@@ -49,10 +49,6 @@ define HOST_GETTEXT_TINY_COPY_EXTRA_FILES endef HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES -ifeq ($(BR2_ENABLE_LOCALE),) -HOST_GETTEXT_TINY_DEPENDENCIES = libiconv -endif - define HOST_GETTEXT_TINY_BUILD_CMDS $(HOST_MAKE_ENV) $(MAKE) -C $(@D) \ $(HOST_CONFIGURE_OPTS) \
Signature · 1 line
2.7.4
PATCH 1/2 package/gettext-tiny: Fix cyclic dependency with iconv
Hi Vadim,
Quoted 7 lines
-----Original Message-----
From: Vadim Kochan <[email protected]>
Sent: Tuesday, April 9, 2019 4:55 PM
To: buildroot at buildroot.org
Cc: Vadim Kochan <[email protected]>; Alexey Brodkin <[email protected]>
Subject: [PATCH 1/2] package/gettext-tiny: Fix cyclic dependency with iconv
Quoted 8 lines
From: Vadim Kochan <[email protected]>
target's libiconv is added into host dependency which makes cyclic dependency, anyway this dependency is not needed because of assumption that iconv should be provided by the host.
Signed-off-by Vadim Kochan <[email protected]>---
Thanks for fixing this one!
Thomas Petazzoni
AppliedPATCH 1/2 package/gettext-tiny: Fix cyclic dependency with iconv
In reply to Vadim KochanQuoted 10 lines · On Tue, 9 Apr 2019 16:55:04 +0300 Vadim Kochan <[email protected]> wrote:
From: Vadim Kochan <[email protected]>
target's libiconv is added into host dependency which makes cyclic dependency, anyway this dependency is not needed because of assumption that iconv should be provided by the host.
Signed-off-by Vadim Kochan <[email protected]>--- package/gettext-tiny/gettext-tiny.mk | 4 ---- 1 file changed, 4 deletions(-)
Applied to master after significantly reworking the commit log. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com