Skip to contentSkip to conversation

FAILED: patch "[PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on" failed to apply to 4.14-stable tree

PATCH [email protected] 2 participants 3 messages Apr 15, 2019

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From a8772e5d826d0f61f8aa9c284b3ab49035d5273d Mon Sep 17 00:00:00 2001
From: Tomohiro Mayama <[email protected]>
Date: Sun, 10 Mar 2019 01:10:12 +0900
Subject: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on
rk3328-rock64

This patch makes USB ports functioning again.

Fixes 955bebde057e ("arm64: dts: rockchip: add rk3328-rock64 board")
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +1 -2
index 2157a528276b..79b4d1d4b5d6 100644
@@ -46,8 +46,7 @@
 
 	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
 		compatible = "regulator-fixed";
-		enable-active-high;
-		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&usb20_host_drv>;
 		regulator-name = "vcc_host1_5v";
#1 lore raw
Quoted 5 lines · On 15/04/2019 16:56, [email protected] wrote:

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Ah, I guess this depends on ef05bcb60c1a ("arm64: dts: rockchip: fix vcc_host1_5v pin assign on rk3328-rock64"), which doesn't look to have been tagged for stable.

Robin.

Quoted 37 lines

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From a8772e5d826d0f61f8aa9c284b3ab49035d5273d Mon Sep 17 00:00:00 2001
From: Tomohiro Mayama <[email protected]>
Date: Sun, 10 Mar 2019 01:10:12 +0900
Subject: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on
rk3328-rock64

This patch makes USB ports functioning again.

Fixes 955bebde057e ("arm64: dts: rockchip: add rk3328-rock64 board")
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +1 -2
index 2157a528276b..79b4d1d4b5d6 100644
@@ -46,8 +46,7 @@
 
  	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
  		compatible = "regulator-fixed";
-		enable-active-high;
-		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
  		pinctrl-names = "default";
  		pinctrl-0 = <&usb20_host_drv>;
  		regulator-name = "vcc_host1_5v";
author maintainer
#2 lore raw
Quoted 10 lines · Robin Murphy
Quoted 5 lines · On 15/04/2019 16:56, [email protected] wrote:

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Ah, I guess this depends on ef05bcb60c1a ("arm64: dts: rockchip: fix vcc_host1_5v pin assign on rk3328-rock64"), which doesn't look to have been tagged for stable.

That worked, thanks!

greg k-h