drivers: iio: accel: Switch hardcoded function name with a reference to __func__ making the code more maintainable
PATCH 1/1 drivers: iio: accel: Switch hardcoded function name with a reference to __func__ making the code more maintainable
It fixes the following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using function's name, in a string
Signed-off-by Mohan Kumar <[email protected]>
--- drivers/iio/accel/bmc150-accel-core.c | 2 +- drivers/iio/accel/kxcjk-1013.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/iio/accel/bmc150-accel-core.c +1 -1
@@ -394,7 +394,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)if (ret <0 ) {dev_err (dev, -"Failed: bmc150_accel_set_power_state for %d\n" , on); +"Failed: %s for %d\n" , __func__, on);if (on)pm_runtime_put_noidle (dev);
drivers/iio/accel/kxcjk-1013.c +1 -1
@@ -451,7 +451,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) }if (ret <0 ) {dev_err (&data->client->dev, -"Failed: kxcjk1013_set_power_state for %d\n" , on); +"Failed: %s for %d\n" , __func__, on);if (on)pm_runtime_put_noidle (&data->client->dev);return ret;
Signature · 1 line
2.7.4
Jonathan Cameron
maintainerQuoted 6 lines · On Fri, 19 Apr 2019 11:36:51 +0300 Mohan Kumar <[email protected]> wrote:
It fixes the following checkpatch.pl warning:
WARNING: Prefer using '"%s...",
__func__' to using function's name, in a stringSigned-off-by Mohan Kumar <[email protected]>
Patch is good, but please check other patches for the area git log --oneline -- drivers/iio to get the standard formatting for descriptions. The patch title is also a bit to long.
I've edited that and applied the patch to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks
Jonathan
Quoted 31 lines
--- drivers/iio/accel/bmc150-accel-core.c | 2 +- drivers/iio/accel/kxcjk-1013.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/iio/accel/bmc150-accel-core.c +1
-1@@ -394,7 +394,7 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)if (ret <0 ) {dev_err (dev, -"Failed: bmc150_accel_set_power_state for %d\n" , on); +"Failed: %s for %d\n" , __func__, on);if (on)pm_runtime_put_noidle (dev);drivers/iio/accel/kxcjk-1013.c +1
-1@@ -451,7 +451,7 @@ static int kxcjk1013_set_power_state(struct kxcjk1013_data *data, bool on) }if (ret <0 ) {dev_err (&data->client->dev, -"Failed: kxcjk1013_set_power_state for %d\n" , on); +"Failed: %s for %d\n" , __func__, on);if (on)pm_runtime_put_noidle (&data->client->dev);return ret;