Skip to contentSkip to conversation

vim: Rework to not rely on relative directories

PATCH Superseded Tom Rini 3 participants 14 messages Apr 21, 2019 – Apr 24, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/2 vim: Rework to not rely on relative directories

The vim recipe has all of the code inside the "src" subdirectory but other things we rely on, such as the license file in a subdirectory relative to the src. However, as there is a top-level "configure" script that moves us down to the src directory, we can rework the recipe to be overall more simple and regularly laid out if we use that.

---
 meta/recipes-support/vim/vim-tiny_8.1.1017.bb |  2 +-
 meta/recipes-support/vim/vim_8.1.1017.bb      | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)
meta/recipes-support/vim/vim-tiny_8.1.1017.bb +1 -1
index 8b1fb7b1158d..74464833adb5 100644
@@ -8,7 +8,7 @@ ALTERNATIVE_${PN}_remove = "xxd"
 PACKAGECONFIG += "tiny"
 
 do_install() {
-    install -D -m 0755 ${S}/vim ${D}/${bindir}/vim.tiny
+    install -D -m 0755 ${S}/src/vim ${D}/${bindir}/vim.tiny
 }
 
 ALTERNATIVE_PRIORITY = "90"
meta/recipes-support/vim/vim_8.1.1017.bb +10 -8
index 7627d2844b79..4e3e663c5429 100644
@@ -6,16 +6,16 @@ DEPENDS = "ncurses gettext-native"
 # vimdiff doesn't like busybox diff
 RSUGGESTS_${PN} = "diffutils"
 LICENSE = "vim"
-LIC_FILES_CHKSUM = "file://../runtime/doc/uganda.txt;endline=287;md5=f1f82b42360005c70b8c19b0ef493f72"
+LIC_FILES_CHKSUM = "file://runtime/doc/uganda.txt;endline=287;md5=f1f82b42360005c70b8c19b0ef493f72"
 
 SRC_URI = "git://github.com/vim/vim.git \
-           file://disable_acl_header_check.patch;patchdir=.. \
-           file://vim-add-knob-whether-elf.h-are-checked.patch;patchdir=.. \
-           file://0001-src-Makefile-improve-reproducibility.patch;patchdir=.. \
+           file://disable_acl_header_check.patch \
+           file://vim-add-knob-whether-elf.h-are-checked.patch \
+           file://0001-src-Makefile-improve-reproducibility.patch \
 "
 SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
 
-S = "${WORKDIR}/git/src"
+S = "${WORKDIR}/git"
 
 VIMDIR = "vim${@d.getVar('PV').split('.')[0]}${@d.getVar('PV').split('.')[1]}"
 
@@ -25,13 +25,15 @@ CLEANBROKEN = "1"
 
 # vim configure.in contains functions which got 'dropped' by autotools.bbclass
 do_configure () {
+    cd src
     rm -f auto/*
     touch auto/config.mk
     aclocal
     autoconf
+    cd ..
     oe_runconf
-    touch auto/configure
-    touch auto/config.mk auto/config.h
+    touch src/auto/configure
+    touch src/auto/config.mk src/auto/config.h
 }
 
 #Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
@@ -76,7 +78,7 @@ do_install() {
     chmod -x ${D}${datadir}/${BPN}/${VIMDIR}/tools/*.py
 
     # Install example vimrc from runtime files
-    install -m 0644 ../runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
+    install -m 0644 runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
 
     # we use --with-features=big as default
     mv ${D}${bindir}/${BPN} ${D}${bindir}/${BPN}.${BPN}
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 vim: Update to 8.1.1198

This brings us to the current version of vim.

---
 meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1198.bb} | 0
 meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb} (98%)
meta/recipes-support/vim/vim-tiny_8.1.1198.bb renamed from meta/recipes-support/vim/vim-tiny_8.1.1017.bb +0 -0
similarity index 100%
rename from meta/recipes-support/vim/vim-tiny_8.1.1017.bb
rename to meta/recipes-support/vim/vim-tiny_8.1.1198.bb
meta/recipes-support/vim/vim_8.1.1198.bb renamed from meta/recipes-support/vim/vim_8.1.1017.bb +1 -1
similarity index 98%
rename from meta/recipes-support/vim/vim_8.1.1017.bb
rename to meta/recipes-support/vim/vim_8.1.1198.bb
index 4e3e663c5429..d7b864ee8b94 100644
@@ -13,7 +13,7 @@ SRC_URI = "git://github.com/vim/vim.git \
            file://vim-add-knob-whether-elf.h-are-checked.patch \
            file://0001-src-Makefile-improve-reproducibility.patch \
 "
-SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
+SRCREV = "958eabe5e53673fc39186432ff98b3656663beeb"
 
 S = "${WORKDIR}/git"
 
Signature · 1 line
2.7.4
#2 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 5 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}

(98%)

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Cheers,

Richard

author
#3 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 15 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 5 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}

(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that springs to mind.

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

Signature · 1 line
Tom
#4 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 23 lines · Tom Rini
Quoted 15 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 5 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}

(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that springs to mind.

Quoted 4 lines

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586- poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build machine setups but not more minimal ones?

The build configuration hasn't changed, just the new version upgrade and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures (no-x11 is also a world failure).

Cheers,

Richard

author
#5 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 35 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 23 lines · Tom Rini
Quoted 15 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 5 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}

(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that springs to mind.

Quoted 4 lines

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

Quoted 8 lines

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586- poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build machine setups but not more minimal ones?

Hmm, could be. I assume there's not currently a minimal Docker (or, whatever) image to grab and build off of (I just spent some time setting up such a thing for U-Boot) ? It looks like I can setup a minimal Fedora chroot without too much work, so I'll pencil in some time to make that, install the normal documented must-haves and see what I can make blow up. Thanks!

Signature · 1 line
Tom
author
#6 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

In reply to [email protected]
Quoted 41 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 23 lines · Tom Rini
Quoted 15 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 5 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}

(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that springs to mind.

Quoted 4 lines

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586- poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

Quoted 7 lines

So perhaps there is host contamination and this works one some build machine setups but not more minimal ones?

The build configuration hasn't changed, just the new version upgrade and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures (no-x11 is also a world failure).

Current poky master-next + my patches (and bitbake -k'ing around gobject-introspection-native failing to configure over passing -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented additional packages off of
https://www.openembedded.org/wiki/Getting_started

Signature · 1 line
Tom
#7 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 54 lines · Tom Rini
Quoted 5 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 4 lines · Tom Rini
Quoted 3 lines · Richard Purdie
Quoted 2 lines · Tom Rini

This brings us to the current version of vim.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb =>

vim_8.1.1198.bb}

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

(98%)

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Quoted 3 lines
Quoted 3 lines

Does the current version even work in this case? Digging down into

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b

Quoted 20 lines
Quoted 7 lines

there's a certain level of "how does that even work today then?" that springs to mind.

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586- poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

Quoted 7 lines

So perhaps there is host contamination and this works one some build machine setups but not more minimal ones?

The build configuration hasn't changed, just the new version upgrade and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures (no-x11 is also a world failure).

Quoted 6 lines

Current poky master-next + my patches (and bitbake -k'ing around gobject-introspection-native failing to configure over passing -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented additional packages off of
https://www.openembedded.org/wiki/Getting_started

Or you could use a CROPS container?
https://hub.docker.com/r/crops/poky/

Quoted 8 lines

--
Tom
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#8 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 56 lines · Tim Orling
Quoted 54 lines · Tom Rini
Quoted 5 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 4 lines · Tom Rini
Quoted 3 lines · Richard Purdie
Quoted 2 lines · Tom Rini

This brings us to the current version of vim.

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb =>

vim_8.1.1198.bb}

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

(98%)

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Quoted 3 lines
Quoted 3 lines

Does the current version even work in this case? Digging down into

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b

Quoted 27 lines
Quoted 7 lines

there's a certain level of "how does that even work today then?" that springs to mind.

I need a few more details to know how to reproduce this locally as I don't see whatever must be in site.conf/etc to turn regular poky into no-x11. The errors are also around iconv stuff so maybe nls is also removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586- poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build machine setups but not more minimal ones?

The build configuration hasn't changed, just the new version upgrade and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures (no-x11 is also a world failure).

Quoted 8 lines
Quoted 5 lines

Current poky master-next + my patches (and bitbake -k'ing around gobject-introspection-native failing to configure over passing -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented additional packages off of
https://www.openembedded.org/wiki/Getting_started

Or you could use a CROPS container?
https://hub.docker.com/r/crops/poky/

No, only in that I was looking to replicate a hopefully known failing env (of which RP pointed to Centos and Fedora builders).

Signature · 1 line
Tom
#9 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

In reply to Tom Rini
Quoted 63 lines · Tom Rini
Quoted 54 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 27 lines · Tom Rini
Quoted 17 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 7 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb =>
vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb =>

vim_8.1.1198.bb}
(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that
springs to mind.

Quoted 7 lines

I need a few more details to know how to reproduce this locally as I
don't see whatever must be in site.conf/etc to turn regular poky into
no-x11. The errors are also around iconv stuff so maybe nls is also
removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

Quoted 2 lines

/home/pokybuild/yocto-worker/qemux86-
world/build/build/tmp/work/i586-

poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt:
Cannot
convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.

Quoted 1 line

make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build
machine setups but not more minimal ones?

Quoted 6 lines

The build configuration hasn't changed, just the new version upgrade
and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures
(no-x11 is also a world failure).

Quoted 5 lines

Current poky master-next + my patches (and bitbake -k'ing around gobject-introspection-native failing to configure over passing -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented additional packages off of
https://www.openembedded.org/wiki/Getting_started

Something odd is going on as I tried this on my local build system and that failed the same way as the autobuilder. That is an ubuntu 18.04 system, nothing special. I guess this means I should try and figure out why it breaks. I still suspect something about the native locales installed...

The gobject-introspection-native issue was dropped from -next fwiw.

What does "locale -a" show for you?

Cheers,

Richard

author
#10 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 70 lines · On Wed, Apr 24, 2019 at 08:40:01AM +0100, [email protected]…
Quoted 63 lines · Tom Rini
Quoted 54 lines · On Tue, Apr 23, 2019 at 11:22:14PM +0100, [email protected]…
Quoted 27 lines · Tom Rini
Quoted 17 lines · Richard Purdie
Quoted 8 lines · Tom Rini

This brings us to the current version of vim.

---
meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
tiny_8.1.1198.bb} | 0
meta/recipes-support/vim/{vim_8.1.1017.bb =>
vim_8.1.1198.bb} | 2 +-

Quoted 7 lines
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb =>
vim-
tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb =>

vim_8.1.1198.bb}
(98%)

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case? Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that
springs to mind.

Quoted 7 lines

I need a few more details to know how to reproduce this locally as I
don't see whatever must be in site.conf/etc to turn regular poky into
no-x11. The errors are also around iconv stuff so maybe nls is also
removed here? Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

Quoted 2 lines

/home/pokybuild/yocto-worker/qemux86-
world/build/build/tmp/work/i586-

poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt:
Cannot
convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and iconv() does not support this conversion.

Quoted 1 line

make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build
machine setups but not more minimal ones?

Quoted 6 lines

The build configuration hasn't changed, just the new version upgrade
and the other patch. I suppose its possible it depends which of our workers its built upon but that seems unlikely for two world failures
(no-x11 is also a world failure).

Quoted 5 lines

Current poky master-next + my patches (and bitbake -k'ing around gobject-introspection-native failing to configure over passing -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented additional packages off of
https://www.openembedded.org/wiki/Getting_started

Quoted 5 lines

Something odd is going on as I tried this on my local build system and that failed the same way as the autobuilder. That is an ubuntu 18.04 system, nothing special. I guess this means I should try and figure out why it breaks. I still suspect something about the native locales installed...

Very strange, yeah.

Quoted 1 line

The gobject-introspection-native issue was dropped from -next fwiw.

OK.

Quoted 1 line

What does "locale -a" show for you?

On Fedora Core 29:
C
C.utf8
en_AG
en_AG.utf8
en_AU
en_AU.iso88591
en_AU.utf8
en_BW
en_BW.iso88591
en_BW.utf8
en_CA
en_CA.iso88591
en_CA.utf8
en_DK
en_DK.iso88591
en_DK.utf8
en_GB
en_GB.iso88591
en_GB.iso885915
en_GB.utf8
en_HK
en_HK.iso88591
en_HK.utf8
en_IE
en_IE@euro
en_IE.iso88591
en_IE.iso885915@euro
en_IE.utf8
en_IL
en_IL.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ
en_NZ.iso88591
en_NZ.utf8
en_PH
en_PH.iso88591
en_PH.utf8
en_SC.utf8
en_SG
en_SG.iso88591
en_SG.utf8
en_US
en_US.iso88591
en_US.iso885915
en_US.utf8
en_ZA
en_ZA.iso88591
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW
en_ZW.iso88591
en_ZW.utf8
POSIX

And then my Ubuntu 16.04 regular build env:
C
C.UTF-8
en_AG
en_AG.utf8
en_AU.utf8
en_BW.utf8
en_CA.utf8
en_DK.utf8
en_GB.utf8
en_HK.utf8
en_IE.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ.utf8
en_PH.utf8
en_SG.utf8
en_US.utf8
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW.utf8
POSIX

Signature · 1 line
Tom
#11 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 81 lines · Tom Rini
Quoted 1 line · On Wed, Apr 24, 2019 at 08:40:01AM +0100, [email protected]…

What does "locale -a" show for you?

On Fedora Core 29:
C
C.utf8
en_AG
en_AG.utf8
en_AU
en_AU.iso88591
en_AU.utf8
en_BW
en_BW.iso88591
en_BW.utf8
en_CA
en_CA.iso88591
en_CA.utf8
en_DK
en_DK.iso88591
en_DK.utf8
en_GB
en_GB.iso88591
en_GB.iso885915
en_GB.utf8
en_HK
en_HK.iso88591
en_HK.utf8
en_IE
en_IE@euro
en_IE.iso88591
en_IE.iso885915@euro
en_IE.utf8
en_IL
en_IL.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ
en_NZ.iso88591
en_NZ.utf8
en_PH
en_PH.iso88591
en_PH.utf8
en_SC.utf8
en_SG
en_SG.iso88591
en_SG.utf8
en_US
en_US.iso88591
en_US.iso885915
en_US.utf8
en_ZA
en_ZA.iso88591
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW
en_ZW.iso88591
en_ZW.utf8
POSIX

And then my Ubuntu 16.04 regular build env:
C
C.UTF-8
en_AG
en_AG.utf8
en_AU.utf8
en_BW.utf8
en_CA.utf8
en_DK.utf8
en_GB.utf8
en_HK.utf8
en_IE.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ.utf8

Quoted 8 lines

en_PH.utf8
en_SG.utf8
en_US.utf8
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW.utf8
POSIX

Does vim build cleanly on the 16.04 box? My working theory was the lack of iso88591 locale variants may be causing some kind of issue...

Failing that can you send me the log.do_compile from a successful build offlist and I can compare to my failing one (or send you my failing compile log).

Cheers,

Richard

author
#12 lore raw

Re: [PATCH 2/2] vim: Update to 8.1.1198

Quoted 91 lines · On Wed, Apr 24, 2019 at 02:50:51PM +0100, [email protected]…
Quoted 81 lines · Tom Rini
Quoted 1 line · On Wed, Apr 24, 2019 at 08:40:01AM +0100, [email protected]…

What does "locale -a" show for you?

On Fedora Core 29:
C
C.utf8
en_AG
en_AG.utf8
en_AU
en_AU.iso88591
en_AU.utf8
en_BW
en_BW.iso88591
en_BW.utf8
en_CA
en_CA.iso88591
en_CA.utf8
en_DK
en_DK.iso88591
en_DK.utf8
en_GB
en_GB.iso88591
en_GB.iso885915
en_GB.utf8
en_HK
en_HK.iso88591
en_HK.utf8
en_IE
en_IE@euro
en_IE.iso88591
en_IE.iso885915@euro
en_IE.utf8
en_IL
en_IL.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ
en_NZ.iso88591
en_NZ.utf8
en_PH
en_PH.iso88591
en_PH.utf8
en_SC.utf8
en_SG
en_SG.iso88591
en_SG.utf8
en_US
en_US.iso88591
en_US.iso885915
en_US.utf8
en_ZA
en_ZA.iso88591
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW
en_ZW.iso88591
en_ZW.utf8
POSIX

And then my Ubuntu 16.04 regular build env:
C
C.UTF-8
en_AG
en_AG.utf8
en_AU.utf8
en_BW.utf8
en_CA.utf8
en_DK.utf8
en_GB.utf8
en_HK.utf8
en_IE.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ.utf8

Quoted 8 lines

en_PH.utf8
en_SG.utf8
en_US.utf8
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW.utf8
POSIX

Quoted 2 lines

Does vim build cleanly on the 16.04 box? My working theory was the lack of iso88591 locale variants may be causing some kind of issue...

Yup. I do a nodistro build of my changes before posting to be sure it builds somewhere at least.

Quoted 3 lines

Failing that can you send me the log.do_compile from a successful build offlist and I can compare to my failing one (or send you my failing compile log).

Coming up in a moment.

Signature · 1 line
Tom
author
#13 lore raw

[RFC DO NOT APPLY][PATCH 3/2] vim: Add a work-around for some locale issues

In reply to Tom Rini

We do not support fully / correctly the certain locales. Attempting to use these with msgfmt in order to update the ".desktop" files exposes this problem and leads to the compile failing.

---
 meta/recipes-support/vim/vim_8.1.1198.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
meta/recipes-support/vim/vim_8.1.1198.bb +10 -0
index d7b864ee8b94..6b17a3c90e68 100644
@@ -36,6 +36,16 @@ do_configure () {
     touch src/auto/config.mk src/auto/config.h
 }
 
+do_compile() {
+    # We do not support fully / correctly the following locales.  Attempting
+    # to use these with msgfmt in order to update the ".desktop" files exposes
+    # this problem and leads to the compile failing.
+    for LOCALE in cs fr ko pl sk zh_CN zh_TW;do
+        echo -n > src/po/${LOCALE}.po
+    done
+    autotools_do_compile
+}
+
 #Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
 PACKAGECONFIG ??= ""
 PACKAGECONFIG += " \
Signature · 1 line
2.7.4