FAILED: patch "[PATCH] crypto: chacha20poly1305 - set cra_name correctly" failed to apply to 4.4-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 5e27f38f1f3f45a0c938299c3a34a2d2db77165a Mon Sep 17 00:00:00 2001
From: Eric Biggers <[email protected]>
Date: Sun, 31 Mar 2019 13:04:16 -0700
Subject: [PATCH] crypto: chacha20poly1305 - set cra_name correctly
If the rfc7539 template is instantiated with specific implementations, e.g. "rfc7539(chacha20-generic,poly1305-generic)" rather than "rfc7539(chacha20,poly1305)", then the implementation names end up included in the instance's cra_name. This is incorrect because it then prevents all users from allocating "rfc7539(chacha20,poly1305)", if the highest priority implementations of chacha20 and poly1305 were selected. Also, the self-tests aren't run on an instance allocated in this way.
Fix it by setting the instance's cra_name from the underlying algorithms' actual cra_names, rather than from the requested names. This matches what other templates do.
crypto/chacha20poly1305.c +2 -2
@@ -645,8 +645,8 @@ static int chachapoly_create(struct crypto_template *tmpl, struct rtattr **tb, err = -ENAMETOOLONG ;if (snprintf (inst->alg.base.cra_name,CRYPTO_MAX_ALG_NAME , -"%s(%s,%s)" , name, chacha_name, - poly_name) >=CRYPTO_MAX_ALG_NAME ) +"%s(%s,%s)" , name, chacha->base.cra_name, + poly->cra_name) >=CRYPTO_MAX_ALG_NAME ) goto out_drop_chacha; if (snprintf(inst->alg.base.cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s(%s,%s)", name, chacha->base.cra_driver_name,