Skip to contentSkip to conversation

Update arch/csky for buildroot

PATCH Superseded guoren at kernel.org 2 participants 29 messages May 29, 2019 C-sky architecture

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

guoren at kernel.org

author maintainer
#0 lore raw

v3 cover Update arch/csky for buildroot

From: Guo Ren <[email protected]>

This is the 3th patchset for arch/csky update for buildroot, it includes:

- Support VDSP
- Support new CPU ck860
- Support toolchain build in buildroot
- Add qemu defconfigs

Changes in V3:
- Fixup the sequence logic of patches
- Fixup binutils version select
- Fixup gdb.mk
- Fixup glibc.hash to seperate dir

Changes in V2:
- Seperate gcc gdb glibc gdb from one patch

Guo Ren (10):
arch/csky: Use VDSP instead of DSP
arch/csky: Add ck860 supported
arch/csky: Add FLOAT_ABI compiler options
arch/csky: Add ABI variable for toolchain build
package/binutils: Add C-SKY support
package/gcc: Add C-SKY support
package/gdb: Add C-SKY support
package/glibc: Add C-SKY support
configs/qemu_cskyXXX_virt: new defconfig
arch/csky: Enable csky toolchain build

 .gitlab-ci.yml                                     |   4 +
 arch/Config.in                                     |   1 -
 arch/Config.in.csky                                |  26 +-
 arch/arch.mk.csky                                  |  26 +
 board/qemu/csky/610_defconfig                      | 526 ++++++++++++++++++++
 board/qemu/csky/807_defconfig                      | 531 ++++++++++++++++++++
 board/qemu/csky/810_defconfig                      | 531 ++++++++++++++++++++
 board/qemu/csky/860_defconfig                      | 533 +++++++++++++++++++++
 configs/qemu_csky610_virt_defconfig                |  29 ++
 configs/qemu_csky807_virt_defconfig                |  30 ++
 configs/qemu_csky810_virt_defconfig                |  30 ++
 configs/qemu_csky860_virt_defconfig                |  30 ++
 package/Makefile.in                                |   9 +
 package/binutils/Config.in.host                    |  11 +-
 package/binutils/binutils.hash                     |   2 +
 package/binutils/binutils.mk                       |   7 +
 package/gcc/Config.in.host                         |  13 +
 package/gcc/gcc.hash                               |   2 +
 package/gcc/gcc.mk                                 |   3 +
 package/gdb/Config.in.host                         |   2 +
 package/gdb/gdb.hash                               |   2 +
 package/gdb/gdb.mk                                 |   6 +
 .../glibc.hash                                     |   2 +
 package/glibc/glibc.mk                             |   3 +
 toolchain/toolchain-buildroot/Config.in            |   2 +-
 25 files changed, 2343 insertions(+), 18 deletions(-)
 create mode 100644 arch/arch.mk.csky
 create mode 100644 board/qemu/csky/610_defconfig
 create mode 100644 board/qemu/csky/807_defconfig
 create mode 100644 board/qemu/csky/810_defconfig
 create mode 100644 board/qemu/csky/860_defconfig
 create mode 100644 configs/qemu_csky610_virt_defconfig
 create mode 100644 configs/qemu_csky807_virt_defconfig
 create mode 100644 configs/qemu_csky810_virt_defconfig
 create mode 100644 configs/qemu_csky860_virt_defconfig
 create mode 100644 package/glibc/7630ed2fa60caea98f500e4a7a51b88f9bf1e176/glibc.hash
Signature · 1 line
2.7.4
author maintainer
#1 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

From: Guo Ren <[email protected]>

Use VDSP enhanced instructions Co-processor instead of DSP.

---
 arch/Config.in.csky | 17 +++--------------
 arch/arch.mk.csky   | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 14 deletions(-)
 create mode 100644 arch/arch.mk.csky
arch/Config.in.csky +3 -14
index e88e4e2..3817a2d 100644
@@ -23,9 +23,9 @@ config BR2_CSKY_FPU
 	  Floating-Point Coprocessor or if you don't need FPU support
 	  for your user-space programs.
 
-config BR2_CSKY_DSP
-	bool "Enable DSP enhanced instructions"
-	depends on BR2_ck810 || BR2_ck807
+config BR2_CSKY_VDSP
+	bool "Enable VDSP enhanced instructions Co-processor"
+	depends on BR2_CSKY_FPU
 
 config BR2_ARCH
 	default "csky"
@@ -33,16 +33,5 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "LITTLE"
 
-config BR2_GCC_TARGET_CPU
-	default "ck610"		if (BR2_ck610 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
-	default "ck807"		if (BR2_ck807 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
-	default "ck807e"	if (BR2_ck807 && !BR2_CSKY_FPU &&  BR2_CSKY_DSP)
-	default "ck807f"	if (BR2_ck807 &&  BR2_CSKY_FPU && !BR2_CSKY_DSP)
-	default "ck807ef"	if (BR2_ck807 &&  BR2_CSKY_FPU &&  BR2_CSKY_DSP)
-	default "ck810"		if (BR2_ck810 && !BR2_CSKY_FPU && !BR2_CSKY_DSP)
-	default "ck810e"	if (BR2_ck810 && !BR2_CSKY_FPU &&  BR2_CSKY_DSP)
-	default "ck810f"	if (BR2_ck810 &&  BR2_CSKY_FPU && !BR2_CSKY_DSP)
-	default "ck810ef"	if (BR2_ck810 &&  BR2_CSKY_FPU &&  BR2_CSKY_DSP)
-
 config BR2_READELF_ARCH_NAME
 	default "CSKY"
arch/arch.mk.csky new file +24 -0
new file mode 100644
index 0000000..f2c90eb
@@ -0,0 +1,24 @@
+#
+# Configure the GCC_TARGET_ARCH variable and append the
+# appropriate C-SKY ISA extensions.
+#
+
+ifeq ($(BR2_csky),y)
+
+ifeq ($(BR2_ck610),y)
+GCC_TARGET_CPU := ck610
+else ifeq ($(BR2_ck807),y)
+GCC_TARGET_CPU := ck807
+else ifeq ($(BR2_ck810),y)
+GCC_TARGET_CPU := ck810
+endif
+
+ifeq ($(BR2_CSKY_FPU),y)
+GCC_TARGET_CPU := $(GCC_TARGET_CPU)f
+endif
+
+ifeq ($(BR2_CSKY_VDSP),y)
+GCC_TARGET_CPU := $(GCC_TARGET_CPU)v
+endif
+
+endif
Signature · 1 line
2.7.4
author maintainer
#13 lore raw

PATCH v3 2/10 arch/csky: Add ck860 supported

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

ck860 is newest CPU core of C-SKY with high performance & SMP supported.

---
 arch/Config.in.csky | 5 ++++-
 arch/arch.mk.csky   | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)
arch/Config.in.csky +4 -1
index 3817a2d..af9bbd5 100644
@@ -13,11 +13,14 @@ config BR2_ck807
 config BR2_ck810
 	bool "ck810"
 
+config BR2_ck860
+	bool "ck860"
+
 endchoice
 
 config BR2_CSKY_FPU
 	bool "Enable FPU coprocessor"
-	depends on BR2_ck810 || BR2_ck807
+	depends on BR2_ck810 || BR2_ck807 || BR2_ck860
 	help
 	  You can say N here if your C-SKY CPU doesn't have a
 	  Floating-Point Coprocessor or if you don't need FPU support
arch/arch.mk.csky +2 -0
index f2c90eb..fb59ae2 100644
@@ -11,6 +11,8 @@ else ifeq ($(BR2_ck807),y)
 GCC_TARGET_CPU := ck807
 else ifeq ($(BR2_ck810),y)
 GCC_TARGET_CPU := ck810
+else ifeq ($(BR2_ck860),y)
+GCC_TARGET_CPU := ck860
 endif
 
 ifeq ($(BR2_CSKY_FPU),y)
Signature · 1 line
2.7.4
author maintainer
#14 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

This is only for abiv2 and abiv1 don't support FPU.

---
 arch/Config.in.csky | 4 ++++
 1 file changed, 4 insertions(+)
arch/Config.in.csky +4 -0
index af9bbd5..a967d2f 100644
@@ -30,6 +30,10 @@ config BR2_CSKY_VDSP
 	bool "Enable VDSP enhanced instructions Co-processor"
 	depends on BR2_CSKY_FPU
 
+config BR2_GCC_TARGET_FLOAT_ABI
+	default "soft"		if !BR2_CSKY_FPU
+	default "hard"		if BR2_CSKY_FPU
+
 config BR2_ARCH
 	default "csky"
 
Signature · 1 line
2.7.4
author maintainer
#22 lore raw

PATCH v3 4/10 arch/csky: Add ABI variable for toolchain build

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

C-SKY toolchain build need it to seperate abiv1 & abiv2.

---
 package/Makefile.in | 9 +++++++++
 1 file changed, 9 insertions(+)
package/Makefile.in +9 -0
index dc818a2..f05b9cc 100644
@@ -70,6 +70,15 @@ ABI := $(ABI)hf
 endif
 endif
 
+# For C-SKY abiv1 & abiv2
+ifeq ($(BR2_csky),y)
+ifeq ($(BR2_ck610),y)
+ABI = abiv1
+else
+ABI = abiv2
+endif
+endif
+
 # For FSL PowerPC there's SPE
 ifeq ($(BR2_powerpc_SPE),y)
 ABI = spe
Signature · 1 line
2.7.4
author maintainer
#23 lore raw

PATCH v3 5/10 package/binutils: Add C-SKY support

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Add binutils build for C-SKY Architecture.

---
 package/binutils/Config.in.host | 11 ++++++++++-
 package/binutils/binutils.hash  |  2 ++
 package/binutils/binutils.mk    |  7 +++++++
 3 files changed, 19 insertions(+), 1 deletion(-)
package/binutils/Config.in.host +10 -1
index c3c3beb..d2ca8af 100644
@@ -7,28 +7,37 @@ config BR2_PACKAGE_HOST_BINUTILS_SUPPORTS_CFI
 
 choice
 	prompt "Binutils Version"
-	default BR2_BINUTILS_VERSION_2_31_X if !BR2_arc
+	default BR2_BINUTILS_VERSION_2_31_X if !BR2_arc && !BR2_csky
 	default BR2_BINUTILS_VERSION_ARC if BR2_arc
+	default BR2_BINUTILS_VERSION_CSKY if BR2_csky
 	help
 	  Select the version of binutils you wish to use.
 
 config BR2_BINUTILS_VERSION_2_30_X
 	bool "binutils 2.30"
+	depends on !BR2_csky
 
 config BR2_BINUTILS_VERSION_2_31_X
 	bool "binutils 2.31.1"
+	depends on !BR2_csky
 
 config BR2_BINUTILS_VERSION_2_32_X
 	bool "binutils 2.32"
+	depends on !BR2_csky
 
 config BR2_BINUTILS_VERSION_ARC
 	bool "binutils arc (2.31)"
 	depends on BR2_arc
+
+config BR2_BINUTILS_VERSION_CSKY
+	bool "binutils csky"
+	depends on BR2_csky
 endchoice
 
 config BR2_BINUTILS_VERSION
 	string
 	default "arc-2018.09-release"	if BR2_BINUTILS_VERSION_ARC
+	default "c66d8bbcebfddf713b2b436e1b135e6b125a55a5" if BR2_BINUTILS_VERSION_CSKY
 	default "2.30"		if BR2_BINUTILS_VERSION_2_30_X
 	default "2.31.1"	if BR2_BINUTILS_VERSION_2_31_X
 	default "2.32"		if BR2_BINUTILS_VERSION_2_32_X
package/binutils/binutils.hash +2 -0
index 039e368..9f8b419 100644
@@ -5,3 +5,5 @@ sha512  d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724a
 
 # Locally calculated (fetched from Github)
 sha512  a96dfcea6064fcd1aac1333ac0d631491bed8b0be9bdcf62f1447909c8f30d2cb8d9323ffeb7c9ad6b326ecddb72e3d28281684e73343189d0a4a37a11aef62f  binutils-gdb-arc-2018.09-release.tar.gz
+# Locally calculated (fetched from https://github.com/c-sky/binutils-gdb)
+sha512  979552d4b3a4f31e9f3b9a7027321bd4eb3ac6c2d8deac1720e94e54f81d736db09c53c5d87c301010e307b64127e14400a036c7a35e5d63a954a4edd9cc8e2c  binutils-c66d8bbcebfddf713b2b436e1b135e6b125a55a5.tar.gz
package/binutils/binutils.mk +7 -0
index c70ba13..6d2b710 100644
@@ -20,6 +20,13 @@ BINUTILS_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,binutils-gdb,
 BINUTILS_SOURCE = binutils-gdb-$(BINUTILS_VERSION).tar.gz
 BINUTILS_FROM_GIT = y
 endif
+
+ifeq ($(BR2_csky),y)
+BINUTILS_SITE = $(call github,c-sky,binutils-gdb,$(BINUTILS_VERSION))
+BINUTILS_SOURCE = binutils-$(BINUTILS_VERSION).tar.gz
+BINUTILS_FROM_GIT = y
+endif
+
 BINUTILS_SITE ?= $(BR2_GNU_MIRROR)/binutils
 BINUTILS_SOURCE ?= binutils-$(BINUTILS_VERSION).tar.xz
 BINUTILS_EXTRA_CONFIG_OPTIONS = $(call qstrip,$(BR2_BINUTILS_EXTRA_CONFIG_OPTIONS))
Signature · 1 line
2.7.4
author maintainer
#24 lore raw

PATCH v3 6/10 package/gcc: Add C-SKY support

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Add gcc build for C-SKY Architecture.

---
 package/gcc/Config.in.host | 13 +++++++++++++
 package/gcc/gcc.hash       |  2 ++
 package/gcc/gcc.mk         |  3 +++
 3 files changed, 18 insertions(+)
package/gcc/Config.in.host +13 -0
index 8e22a4c..c3aceff 100644
@@ -3,6 +3,7 @@ comment "GCC Options"
 choice
 	prompt "GCC compiler Version"
 	default BR2_GCC_VERSION_ARC if BR2_arc
+	default BR2_GCC_VERSION_CSKY if BR2_csky
 	default BR2_GCC_VERSION_OR1K if BR2_or1k
 	default BR2_GCC_VERSION_7_X
 	help
@@ -14,6 +15,12 @@ config BR2_GCC_VERSION_ARC
 	depends on BR2_arc
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
+config BR2_GCC_VERSION_CSKY
+	bool "gcc csky"
+	# Only supported architecture
+	depends on BR2_csky
+	select BR2_TOOLCHAIN_GCC_AT_LEAST_6
+
 config BR2_GCC_VERSION_OR1K
 	bool "gcc or1k (5.x)"
 	# Only supported architecture
@@ -25,6 +32,7 @@ config BR2_GCC_VERSION_4_9_X
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5
 	# Broken or unsupported architectures
 	depends on !BR2_arc
+	depends on !BR2_csky
 	depends on !BR2_or1k
 	# musl on microblaze, ppc64 and mips64 unsupported
 	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_microblazeel || BR2_microblazebe))
@@ -39,6 +47,7 @@ config BR2_GCC_VERSION_5_X
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6
 	# Broken or unsupported architectures
 	depends on !BR2_arc
+	depends on !BR2_csky
 	depends on !BR2_or1k
 	# musl on ppc64 and mips64 unsupported
 	depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le))
@@ -52,6 +61,7 @@ config BR2_GCC_VERSION_6_X
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7
 	# Broken or unsupported architectures
 	depends on !BR2_arc
+	depends on !BR2_csky
 	depends on !BR2_or1k
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_6
 
@@ -59,12 +69,14 @@ config BR2_GCC_VERSION_7_X
 	bool "gcc 7.x"
 	depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_8
 	# Broken or unsupported architectures
+	depends on !BR2_csky
 	depends on !BR2_or1k
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_7
 
 config BR2_GCC_VERSION_8_X
 	bool "gcc 8.x"
 	# Broken or unsupported architectures
+	depends on !BR2_csky
 	depends on !BR2_or1k
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
@@ -85,6 +97,7 @@ config BR2_GCC_VERSION
 	default "8.3.0"     if BR2_GCC_VERSION_8_X
 	default "arc-2018.09-release" if BR2_GCC_VERSION_ARC
 	default "or1k-musl-5.4.0-20170218" if BR2_GCC_VERSION_OR1K
+	default "48152afb96c59733d5bc79e3399bb7b3d4b44266" if BR2_GCC_VERSION_CSKY
 
 config BR2_EXTRA_GCC_CONFIG_OPTIONS
 	string "Additional gcc options"
package/gcc/gcc.hash +2 -0
index 4f1e7f9..780484d 100644
@@ -13,3 +13,5 @@ sha512  1811337ae3add9680cec64968a2509d085b6dc5b6783fc1e8c295e3e47416196fd1a3ad8
 sha512  4d12c3ac27b9de9c533be3b8964cf23d21bf6933b5073183e1affe714b0ff33f9d6169e3b55a5c505d7dae33c9bb4f8b0d110461e3a124182d8c8d51b66b8e45  gcc-arc-2018.09-release.tar.gz
 # Locally calculated (fetched from Github)
 sha512  2de7cf47333a4092b02d3bb98f4206f14966f1d139a724d09cf3b22f8a43ae0c704f33e6477d6367a03c29b265480dc900169e9d417006c5d46f0ae446b8c6f1  gcc-or1k-musl-5.4.0-20170218.tar.gz
+# Locally calculated (fetched from https://github.com/c-sky/gcc)
+sha512  1c3564fd6573dce13451a73015e7d88fecbb214dc1df96607976255b1d8b9e60318405333f4f218eea8d07e3675a802b66eff6df3921d505c4036481512792c2  gcc-48152afb96c59733d5bc79e3399bb7b3d4b44266.tar.gz
package/gcc/gcc.mk +3 -0
index 5901624..abc29c7 100644
@@ -16,6 +16,9 @@ GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
 else ifeq ($(BR2_or1k),y)
 GCC_SITE = $(call github,openrisc,or1k-gcc,$(GCC_VERSION))
 GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
+else ifeq ($(BR2_csky),y)
+GCC_SITE = $(call github,c-sky,gcc,$(GCC_VERSION))
+GCC_SOURCE = gcc-$(GCC_VERSION).tar.gz
 else
 GCC_SITE = $(BR2_GNU_MIRROR:/=)/gcc/gcc-$(GCC_VERSION)
 # From version 5.5.0, 6.4.0, 7.2.0 and 8.1.0 a bz2 release tarball is not
Signature · 1 line
2.7.4
author maintainer
#25 lore raw

PATCH v3 7/10 package/gdb: Add C-SKY support

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Add gdb build for C-SKY Architecture:

- Support host-gdb
- Support gdbserver for target

---
 package/gdb/Config.in.host | 2 ++
 package/gdb/gdb.hash       | 2 ++
 package/gdb/gdb.mk         | 6 ++++++
 3 files changed, 10 insertions(+)
package/gdb/Config.in.host +2 -0
index 969168f..76a0eca 100644
@@ -48,6 +48,7 @@ choice
 	prompt "GDB debugger Version"
 	default BR2_GDB_VERSION_8_1
 	depends on !BR2_arc
+	depends on !BR2_csky
 	help
 	  Select the version of gdb you wish to use.
 
@@ -95,6 +96,7 @@ config BR2_PACKAGE_GDB_NEEDS_CXX11
 config BR2_GDB_VERSION
 	string
 	default "arc-2018.09-release-gdb" if BR2_arc
+	default "4ecb98fbc2f94dbe01b69384afbc515107de73df" if BR2_csky
 	default "7.12.1"   if BR2_GDB_VERSION_7_12
 	default "8.0.1"    if BR2_GDB_VERSION_8_0
 	default "8.1.1"    if BR2_GDB_VERSION_8_1 || !BR2_PACKAGE_HOST_GDB
package/gdb/gdb.hash +2 -0
index 1104da5..90a60b0 100644
@@ -6,3 +6,5 @@ sha512  2aa81cfd389bb48c35d7d9f95cc10e88b4f7ad4597bdde0f8f1fd312f60f10d9fb2cc6e5
 
 # Locally calculated (fetched from Github)
 sha512  8303e399e396f5c15dc976e48503fc7d45a720dd1a470443f755c5f2458d092b4392e7ae582abc251bc4b43a778ad784f764286a2a05abfc1649cbeeeb6e7d15 	gdb-arc-2018.09-release-gdb.tar.gz
+# Locally calculated (fetched from https://github.com/c-sky/binutils-gdb)
+sha512  c421e1f3c0d6cfb3c04544573c0c4b0075c8d8e3d563c6c234fcc1e4c2167ab203d1e57aec3b58abd348dc46f8cf9b47b753d3a43dba3ea970c9c9a6bd78c07b	gdb-4ecb98fbc2f94dbe01b69384afbc515107de73df.tar.gz
package/gdb/gdb.mk +6 -0
index a926961..46d745a 100644
@@ -14,6 +14,12 @@ GDB_SOURCE = gdb-$(GDB_VERSION).tar.gz
 GDB_FROM_GIT = y
 endif
 
+ifeq ($(BR2_csky),y)
+GDB_SITE = $(call github,c-sky,binutils-gdb,$(GDB_VERSION))
+GDB_SOURCE = gdb-$(GDB_VERSION).tar.gz
+GDB_FROM_GIT = y
+endif
+
 GDB_LICENSE = GPL-2.0+, LGPL-2.0+, GPL-3.0+, LGPL-3.0+
 GDB_LICENSE_FILES = COPYING COPYING.LIB COPYING3 COPYING3.LIB
 
Signature · 1 line
2.7.4
author maintainer
#26 lore raw

PATCH v3 8/10 package/glibc: Add C-SKY support

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Add glibc build for C-SKY Architecture.

---
 package/glibc/7630ed2fa60caea98f500e4a7a51b88f9bf1e176/glibc.hash | 2 ++
 package/glibc/glibc.mk                                            | 3 +++
 toolchain/toolchain-buildroot/Config.in                           | 2 +-
 3 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 package/glibc/7630ed2fa60caea98f500e4a7a51b88f9bf1e176/glibc.hash
package/glibc/7630ed2fa60caea98f500e4a7a51b88f9bf1e176/glibc.hash new file +2 -0
new file mode 100644
index 0000000..a61bd65
@@ -0,0 +1,2 @@
+# Locally calculated (fetched from https://github.com/c-sky/glibc)
+sha512 9deb2deceefe347d72de13510a5baa3de00f94c684f3b25e136ca3660f61e65a69f2115abb488c2ab0fa93cda8535853ce1e13e186efcc8434ecc4049efd82b5  glibc-7630ed2fa60caea98f500e4a7a51b88f9bf1e176.tar.gz
package/glibc/glibc.mk +3 -0
index 0345f1f..c4ddf8b 100644
@@ -10,6 +10,9 @@ GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VE
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
 GLIBC_SITE = $(call github,riscv,riscv-glibc,$(GLIBC_VERSION))
+else ifeq ($(BR2_csky),y)
+GLIBC_VERSION = 7630ed2fa60caea98f500e4a7a51b88f9bf1e176
+GLIBC_SITE = $(call github,c-sky,glibc,$(GLIBC_VERSION))
 else
 # Generate version string using:
 #   git describe --match 'glibc-*' --abbrev=40 origin/release/MAJOR.MINOR/master | cut -d '-' -f 2-
toolchain/toolchain-buildroot/Config.in +1 -1
index beb17a2..d9f16e2 100644
@@ -48,7 +48,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT)
+		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
Signature · 1 line
2.7.4
author maintainer
#27 lore raw

PATCH v3 9/10 configs/qemu_cskyXXX_virt: new defconfig

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Add C-SKY defconfig for QEMU virt machine.

Tested with https://gitlab.com/c-sky/buildroot/pipelines

---
 .gitlab-ci.yml                      |   4 +
 board/qemu/csky/610_defconfig       | 526 +++++++++++++++++++++++++++++++++++
 board/qemu/csky/807_defconfig       | 531 +++++++++++++++++++++++++++++++++++
 board/qemu/csky/810_defconfig       | 531 +++++++++++++++++++++++++++++++++++
 board/qemu/csky/860_defconfig       | 533 ++++++++++++++++++++++++++++++++++++
 configs/qemu_csky610_virt_defconfig |  29 ++
 configs/qemu_csky807_virt_defconfig |  30 ++
 configs/qemu_csky810_virt_defconfig |  30 ++
 configs/qemu_csky860_virt_defconfig |  30 ++
 9 files changed, 2244 insertions(+)
 create mode 100644 board/qemu/csky/610_defconfig
 create mode 100644 board/qemu/csky/807_defconfig
 create mode 100644 board/qemu/csky/810_defconfig
 create mode 100644 board/qemu/csky/860_defconfig
 create mode 100644 configs/qemu_csky610_virt_defconfig
 create mode 100644 configs/qemu_csky807_virt_defconfig
 create mode 100644 configs/qemu_csky810_virt_defconfig
 create mode 100644 configs/qemu_csky860_virt_defconfig
.gitlab-ci.yml +4 -0
index 374dbfe..4fa3473 100644
@@ -248,6 +248,10 @@ qemu_aarch64_virt_defconfig: { extends: .defconfig }
 qemu_arm_versatile_defconfig: { extends: .defconfig }
 qemu_arm_versatile_nommu_defconfig: { extends: .defconfig }
 qemu_arm_vexpress_defconfig: { extends: .defconfig }
+qemu_csky610_virt_defconfig: { extends: .defconfig }
+qemu_csky807_virt_defconfig: { extends: .defconfig }
+qemu_csky810_virt_defconfig: { extends: .defconfig }
+qemu_csky860_virt_defconfig: { extends: .defconfig }
 qemu_m68k_mcf5208_defconfig: { extends: .defconfig }
 qemu_m68k_q800_defconfig: { extends: .defconfig }
 qemu_microblazebe_mmu_defconfig: { extends: .defconfig }
board/qemu/csky/610_defconfig new file +526 -0

526 lines not on this page · raw message

board/qemu/csky/807_defconfig new file +531 -0

531 lines not on this page · raw message

board/qemu/csky/810_defconfig new file +531 -0

531 lines not on this page · raw message

board/qemu/csky/860_defconfig new file +533 -0

533 lines not on this page · raw message

configs/qemu_csky610_virt_defconfig new file +29 -0
new file mode 100644
index 0000000..85b31d1
@@ -0,0 +1,29 @@
+# Architecture
+BR2_csky=y
+BR2_ck610=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/csky/610_defconfig"
+
+# Packages on board
+BR2_PACKAGE_LINUX_TOOLS_PERF=y
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_GDB=y
+BR2_PACKAGE_BASH=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_UTIL_LINUX=y
+BR2_PACKAGE_UTIL_LINUX_LIBBLKID=y
configs/qemu_csky807_virt_defconfig new file +30 -0
new file mode 100644
index 0000000..c3247f0
@@ -0,0 +1,30 @@
+# Architecture
+BR2_csky=y
+BR2_ck807=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/csky/807_defconfig"
+
+# Packages on board
+BR2_PACKAGE_LINUX_TOOLS_PERF=y
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_GDB=y
+BR2_PACKAGE_BASH=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_UTIL_LINUX=y
+BR2_PACKAGE_UTIL_LINUX_LIBBLKID=y
configs/qemu_csky810_virt_defconfig new file +30 -0
new file mode 100644
index 0000000..acd2be0
@@ -0,0 +1,30 @@
+# Architecture
+BR2_csky=y
+BR2_ck810=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/csky/810_defconfig"
+
+# Packages on board
+BR2_PACKAGE_LINUX_TOOLS_PERF=y
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_GDB=y
+BR2_PACKAGE_BASH=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_UTIL_LINUX=y
+BR2_PACKAGE_UTIL_LINUX_LIBBLKID=y
configs/qemu_csky860_virt_defconfig new file +30 -0
new file mode 100644
index 0000000..118ad51
@@ -0,0 +1,30 @@
+# Architecture
+BR2_csky=y
+BR2_ck860=y
+
+# System
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_TARGET_ROOTFS_INITRAMFS=y
+
+# Toolchain
+BR2_OPTIMIZE_2=y
+BR2_SHARED_STATIC_LIBS=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+BR2_PACKAGE_HOST_GDB=y
+BR2_TARGET_OPTIMIZATION="-mbacktrace"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0.12"
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/csky/860_defconfig"
+
+# Packages on board
+BR2_PACKAGE_LINUX_TOOLS_PERF=y
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_GDB=y
+BR2_PACKAGE_BASH=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_UTIL_LINUX=y
+BR2_PACKAGE_UTIL_LINUX_LIBBLKID=y
Signature · 1 line
2.7.4
author maintainer
#28 lore raw

PATCH v3 10/10 arch/csky: Enable csky toolchain build

In reply to guoren at kernel.org

From: Guo Ren <[email protected]>

Now csky toolchain could be built in buildroot.

---
 arch/Config.in | 1 -
 1 file changed, 1 deletion(-)
arch/Config.in +0 -1
index d82803c..db1199c 100644
@@ -77,7 +77,6 @@ config BR2_aarch64_be
 
 config BR2_csky
 	bool "csky"
-	select BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT
 	select BR2_ARCH_HAS_MMU_MANDATORY
 	help
 	  csky is processor IP from china.
Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to guoren at kernel.org

Hello Guo,

Thanks for this new iteration. I apologize, but unfortunately it's still not good, and doesn't match the suggestions I did.

Quoted 3 lines · On Wed, 29 May 2019 15:18:39 +0800 guoren at kernel.org wrote:

From: Guo Ren <[email protected]>

Use VDSP enhanced instructions Co-processor instead of DSP.

Your commit log should explain why.

Quoted 4 lines
---
 arch/Config.in.csky | 17 +++--------------
 arch/arch.mk.csky   | 24 ++++++++++++++++++++++++

The change to using arch.mk.csky should be done separately. So this commit should be split into two:

- One switching to using arch.mk.sky, without changing DSP -> VDSP

- A follow-up one changing DSP -> VDSP, with a commit log that explains why you make this chang

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#15 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to guoren at kernel.org

Hello,

Quoted 5 lines · On Wed, 29 May 2019 15:18:41 +0800 guoren at kernel.org wrote:

From: Guo Ren <[email protected]>

This is only for abiv2 and abiv1 don't support FPU.

What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#16 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 2 lines · On Wed, 29 May 2019 15:18:41 +0800 guoren at kernel.org wrote:

From: Guo Ren <[email protected]>

Quoted 7 lines
Quoted 3 lines

This is only for abiv2 and abiv1 don't support FPU.

What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log.

abiv1 contain: ck610
abiv2 contain: ck807 ck810 ck860

Abiv1 is almost the same as mcore and it's ELF_CODE is 39 Abiv2 is C-SKY own ISA and it's ELF_CODE is 252

We don't support FPU in abiv1, because its opcode width is only 16-bits and we don't want
to continue developing it.

Best Regards
Guo Ren

author maintainer
#3 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Thomas Petazzoni

OK, two pathes.

Quoted 35 lines · Thomas Petazzoni

Hello Guo,

Thanks for this new iteration. I apologize, but unfortunately it's still not good, and doesn't match the suggestions I did.

Quoted 3 lines · On Wed, 29 May 2019 15:18:39 +0800 guoren at kernel.org wrote:

From: Guo Ren <[email protected]>

Use VDSP enhanced instructions Co-processor instead of DSP.

Your commit log should explain why.

Quoted 4 lines
---
 arch/Config.in.csky | 17 +++--------------
 arch/arch.mk.csky   | 24 ++++++++++++++++++++++++

The change to using arch.mk.csky should be done separately. So this commit should be split into two:

- One switching to using arch.mk.sky, without changing DSP -> VDSP

- A follow-up one changing DSP -> VDSP, with a commit log that explains why you make this chang

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

author maintainer
#21 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to Thomas Petazzoni
Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 2 lines · On Wed, 29 May 2019 15:18:41 +0800 guoren at kernel.org wrote:

From: Guo Ren <[email protected]>

Quoted 7 lines
Quoted 3 lines

This is only for abiv2 and abiv1 don't support FPU.

What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log.

BR2_GCC_TARGET_FLOAT_ABI=soft-float is OK for ck610

Best Regards
Guo Ren

#4 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Guo Ren

Hello Guo,

Quoted 1 line · On Wed, 29 May 2019 15:30:45 +0800 Guo Ren <[email protected]> wrote:

OK, two pathes.

Not just two patches: also a better commit log for the DSP -> VDSP change.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#17 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to Guo Ren

Hello,

Quoted 11 lines · On Wed, 29 May 2019 15:30:14 +0800 Guo Ren <[email protected]> wrote:
Quoted 3 lines

What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log.

abiv1 contain: ck610
abiv2 contain: ck807 ck810 ck860

Abiv1 is almost the same as mcore and it's ELF_CODE is 39 Abiv2 is C-SKY own ISA and it's ELF_CODE is 252

We don't support FPU in abiv1, because its opcode width is only 16-bits and we don't want to continue developing it.

Ah, and indeed BR2_CSKY_FPU cannot be selected for BR2_ck610.

Please explain all of this in the commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#5 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Thomas Petazzoni
Quoted 10 lines · Thomas Petazzoni

Hello Guo,

Quoted 1 line · On Wed, 29 May 2019 15:30:45 +0800 Guo Ren <[email protected]> wrote:

OK, two pathes.

Not just two patches: also a better commit log for the DSP -> VDSP change.

I want these two patches:

1. Remove DSP, because it's no use in current buildroot.
2. Add VDSP support

Here is my commit log for Introduce VDSP feature:

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Is that OK?

author maintainer
#18 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to Thomas Petazzoni
Quoted 15 lines · Thomas Petazzoni

Hello,

Quoted 9 lines · On Wed, 29 May 2019 15:30:14 +0800 Guo Ren <[email protected]> wrote:
Quoted 3 lines

What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log.

abiv1 contain: ck610
abiv2 contain: ck807 ck810 ck860

Abiv1 is almost the same as mcore and it's ELF_CODE is 39 Abiv2 is C-SKY own ISA and it's ELF_CODE is 252

Quoted 7 lines
Quoted 2 lines

We don't support FPU in abiv1, because its opcode width is only 16-bits and we don't want to continue developing it.

Ah, and indeed BR2_CSKY_FPU cannot be selected for BR2_ck610.

Please explain all of this in the commit log. Thanks!

OK, change the commit log with:

C-SKY CPU is seperated into two ABIs:
- abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610)
- abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU:
807, 810, 860)

So we don't care BR2_GCC_TARGET_FLOAT_ABI for abiv1, because it based on CSKY_FPU and it'll
never be selected by ck610.

#6 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Guo Ren

Hello,

Quoted 7 lines · On Wed, 29 May 2019 16:12:25 +0800 Guo Ren <[email protected]> wrote:
Quoted 2 lines

Not just two patches: also a better commit log for the DSP -> VDSP change.

I want these two patches:

1. Remove DSP, because it's no use in current buildroot.
2. Add VDSP support

OK, but then please split in yet another patch the fact of using arch.mk.csky to build the GCC_TARGET_CPU variable.

Quoted 6 lines

Here is my commit log for Introduce VDSP feature:

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Is that OK?

Yes. But please add a proper commit log in the patch removing the DSP option.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#19 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

In reply to Guo Ren

Hello Guo,

Quoted 10 lines · On Wed, 29 May 2019 16:30:43 +0800 Guo Ren <[email protected]> wrote:

OK, change the commit log with:

C-SKY CPU is seperated into two ABIs:
- abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610)
- abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU:
807, 810, 860)

So we don't care BR2_GCC_TARGET_FLOAT_ABI for abiv1, because it based on CSKY_FPU and it'll
never be selected by ck610.

This last part is not correct: BR2_GCC_TARGET_FLOAT_ABI *will* have a value for abiv1. Except the value will always be "soft" because there's no FPU support in ck610, which is the only core using abiv1. So saying "We don't care about BR2_GCC_TARGET_FLOAT_ABI for abiv1" is not correct.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#20 lore raw

PATCH v3 3/10 arch/csky: Add FLOAT_ABI compiler options

Thx,

Quoted 13 lines · Thomas Petazzoni

Hello Guo,

Quoted 7 lines · On Wed, 29 May 2019 16:30:43 +0800 Guo Ren <[email protected]> wrote:

OK, change the commit log with:

C-SKY CPU is seperated into two ABIs:
- abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610)
- abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU:
807, 810, 860)

Quoted 8 lines
Quoted 3 lines

So we don't care BR2_GCC_TARGET_FLOAT_ABI for abiv1, because it based on CSKY_FPU and it'll
never be selected by ck610.

This last part is not correct: BR2_GCC_TARGET_FLOAT_ABI *will* have a value for abiv1. Except the value will always be "soft" because there's no FPU support in ck610, which is the only core using abiv1. So saying "We don't care about BR2_GCC_TARGET_FLOAT_ABI for abiv1" is not correct.

Yes, Approved and I'll change it like this:

C-SKY CPU is seperated into two ABIs:
- abiv1: mcore based ELF_NUM:39 and do not support FPU & VDSP. (CPU: 610)
- abiv2: C-SKY own ISA with ELF_NUM:252 and support FPU & VDSP. (CPU:
807, 810, 860)

BR2_GCC_TARGET_FLOAT_ABI *will* have a value for abiv1. Except the value will always be "soft"
because there's no FPU support in ck610, which is the only core using abiv1.

Best Regards
Guo Ren

author maintainer
#7 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Thomas Petazzoni
Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · On Wed, 29 May 2019 16:12:25 +0800 Guo Ren <[email protected]> wrote:
Quoted 2 lines

Not just two patches: also a better commit log for the DSP -> VDSP change.

Quoted 7 lines
Quoted 4 lines

I want these two patches:

1. Remove DSP, because it's no use in current buildroot.
2. Add VDSP support

OK, but then please split in yet another patch the fact of using arch.mk.csky to build the GCC_TARGET_CPU variable.

I changemind and I'll follow the above patches which you prior mentioned

- One switching to using arch.mk.sky, without changing DSP -> VDSP
- A follow-up one changing DSP -> VDSP, with a commit log that explains why you make this chang

Quoted 10 lines
Quoted 7 lines

Here is my commit log for Introduce VDSP feature:

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Is that OK?

Yes. But please add a proper commit log in the patch removing the DSP option.

DSP -> VDSP, with a commit log, like this:

Subject: Change DSP to VDSP for -mcpu

DSP is no use in current buildroot and gcc default enable the DSP feature for C-SKY.
So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx.

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Best Regards
Guo Ren

author maintainer
#8 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

Quoted 38 lines · Guo Ren
Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · On Wed, 29 May 2019 16:12:25 +0800 Guo Ren <[email protected]> wrote:
Quoted 2 lines

Not just two patches: also a better commit log for the DSP -> VDSP change.

Quoted 7 lines
Quoted 4 lines

I want these two patches:

1. Remove DSP, because it's no use in current buildroot.
2. Add VDSP support

OK, but then please split in yet another patch the fact of using arch.mk.csky to build the GCC_TARGET_CPU variable.

I changemind and I'll follow the above patches which you prior mentioned

- One switching to using arch.mk.sky, without changing DSP -> VDSP
- A follow-up one changing DSP -> VDSP, with a commit log that explains why you make this chang

Quoted 10 lines
Quoted 7 lines

Here is my commit log for Introduce VDSP feature:

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Is that OK?

Yes. But please add a proper commit log in the patch removing the DSP option.

DSP -> VDSP, with a commit log, like this:

Quoted 8 lines

Subject: Change DSP to VDSP for -mcpu

DSP is no use in current buildroot and gcc default enable the DSP feature for C-SKY.
So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx.

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be support by abiv2 (ck807, ck810, ck860).

Correct: It is supported by abiv2.

#9 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

In reply to Guo Ren

Hello,

Quoted 3 lines · On Wed, 29 May 2019 17:02:29 +0800 Guo Ren <[email protected]> wrote:

DSP is no use in current buildroot and gcc default enable the DSP feature for C-SKY.
So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx.

"DSP is no use in current Buildroot" is not correct. The option exists, and it changes the BR2_GCC_TARGET_CPU value. So it *is* used: it adds "e" to BR2_GCC_TARGET_CPU. So this explanation is not really good/sufficient.

I am willing to help you formulate this properly, but since I still don't understand why you are dropping the DSP option, I can't really help by proposing a better wording.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#10 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

Hello,

Quoted 10 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · On Wed, 29 May 2019 17:02:29 +0800 Guo Ren <[email protected]> wrote:

DSP is no use in current buildroot and gcc default enable the DSP feature for C-SKY.
So DSP is part of our standard ISA, we needn't put it in -mcpu=xxx.

Quoted 8 lines

"DSP is no use in current Buildroot" is not correct. The option exists, and it changes the BR2_GCC_TARGET_CPU value. So it *is* used: it adds "e" to BR2_GCC_TARGET_CPU. So this explanation is not really good/sufficient.

I am willing to help you formulate this properly, but since I still don't understand why you are dropping the DSP option, I can't really help by proposing a better wording.

DSP extention is no longer used for C-SKY and there is no defconfig use "e" extension in buildroot.
I have regretted submitting it to the buildroot.

Change commit log, like this:

Subject: Change DSP to VDSP for -mcpu

DSP extention is no longer used for C-SKY gcc and there is no defconfig use "e" extension
in buildroot.

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be supported by abiv2 (ck807, ck810, ck860).

Is that OK?

Best Regards
Guo Ren

#11 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

Hello,

Quoted 5 lines · On Wed, 29 May 2019 17:45:19 +0800 Guo Ren <[email protected]> wrote:
Quoted 3 lines

I am willing to help you formulate this properly, but since I still don't understand why you are dropping the DSP option, I can't really help by proposing a better wording.

DSP extention is no longer used for C-SKY and there is no defconfig use "e" extension in buildroot.

Not having a defconfig doesn't mean something is not supported. There are tons of features in Buildroot that are not enabled by defconfig, and still we do support them.

Quoted 7 lines

Change commit log, like this:

Subject: Change DSP to VDSP for -mcpu

DSP extention is no longer used for C-SKY gcc and there is no defconfig use "e" extension
in buildroot.

Again, the defconfig aspect is irrelevant. Only the fact the extension is no longer used for C-SKY is relevant.

Quoted 4 lines

VDSP is C-SKY enhanced extension instruction set for SIMD, AI and DSP operation. It could be supported by abiv2 (ck807, ck810, ck860).

Is that OK?

Yes, with the change above.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#12 lore raw

PATCH v3 1/10 arch/csky: Use VDSP instead of DSP

Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · On Wed, 29 May 2019 17:45:19 +0800 Guo Ren <[email protected]> wrote:
Quoted 3 lines

I am willing to help you formulate this properly, but since I still don't understand why you are dropping the DSP option, I can't really help by proposing a better wording.

Quoted 6 lines
Quoted 2 lines

DSP extention is no longer used for C-SKY and there is no defconfig use "e" extension in buildroot.

Not having a defconfig doesn't mean something is not supported. There are tons of features in Buildroot that are not enabled by defconfig, and still we do support them.

Agree, remove defconfig sentence.

Best Regards
Guo Ren