Skip to contentSkip to conversation

ath11k: cleanup in core and qmi components

PATCH In review Karthikeyan Periyasamy 2 participants 2 messages Jun 10, 2019 – Jun 12, 2019 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: cleanup in core and qmi components

Removed unused define ATH11K_TARGET_NAME and ATH11K_FW_READY_TIMEOUT_HZ. Modify the api name from ath11k_qmi_firmware_indication() to ath11k_core_qmi_firmware_ready() because its a core module functionality.

---
 drivers/net/wireless/ath/ath11k/core.c | 4 ++--
 drivers/net/wireless/ath/ath11k/core.h | 6 +-----
 drivers/net/wireless/ath/ath11k/qmi.c  | 2 +-
 3 files changed, 4 insertions(+), 8 deletions(-)
drivers/net/wireless/ath/ath11k/core.c +2 -2
index e3e6b64..928d47b 100644
@@ -582,7 +582,7 @@ static int ath11k_core_start(struct ath11k_base *sc,
 	return ret;
 }
 
-int ath11k_qmi_firmware_indication(struct ath11k_base *ab)
+int ath11k_core_qmi_firmware_ready(struct ath11k_base *ab)
 {
 	int ret;
 
@@ -644,7 +644,7 @@ static int ath11k_core_reconfigure_on_crash(struct ath11k_base *sc)
 
 	clear_bit(ATH11K_FLAG_CRASH_FLUSH, &sc->dev_flags);
 
-	ret = ath11k_qmi_firmware_indication(sc);
+	ret = ath11k_core_qmi_firmware_ready(sc);
 	if (ret)
 		goto err_hal_srng_deinit;
 
drivers/net/wireless/ath/ath11k/core.h +1 -5
index 6fc2942..7ebb5a4 100644
@@ -22,10 +22,6 @@
 
 #define SM(_v, _f) (((_v) << _f##_LSB) & _f##_MASK)
 
-#define ATH11K_TARGET_NAME "q6v5-wcss"
-
-#define ATH11K_FW_READY_TIMEOUT_HZ (5 * HZ)
-
 #define ATH11K_TX_MGMT_NUM_PENDING_MAX	512
 
 /* Map from pdev index to hw mac index */
@@ -813,7 +809,7 @@ struct ath11k_peer *ath11k_peer_find_by_addr(struct ath11k_base *ab,
 					     const u8 *addr);
 struct ath11k_peer *ath11k_peer_find_by_id(struct ath11k_base *ab,
 						  int peer_id);
-int ath11k_qmi_firmware_indication(struct ath11k_base *ab);
+int ath11k_core_qmi_firmware_ready(struct ath11k_base *ab);
 int ath11k_core_init(struct ath11k_base *ath11k);
 void ath11k_core_deinit(struct ath11k_base *ath11k);
 struct ath11k_base *ath11k_core_alloc(struct device *dev);
drivers/net/wireless/ath/ath11k/qmi.c +1 -1
index 79c6dde..cb9ed9c 100644
@@ -2388,7 +2388,7 @@ static void ath11k_qmi_driver_event_work(struct work_struct *work)
 				break;
 			}
 
-			ath11k_qmi_firmware_indication(ab);
+			ath11k_core_qmi_firmware_ready(ab);
 			ab->qmi.cal_done = 1;
 			set_bit(ATH11K_FLAG_REGISTERED, &ab->dev_flags);
 
Signature · 7 lines
1.9.1


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 6 lines · Karthikeyan Periyasamy

Removed unused define ATH11K_TARGET_NAME and ATH11K_FW_READY_TIMEOUT_HZ. Modify the api name from ath11k_qmi_firmware_indication() to ath11k_core_qmi_firmware_ready() because its a core module functionality.

Patch applied to ath11k-bringup branch of ath.git, thanks.

108e62bbb49f ath11k: cleanup in core and qmi components

Signature · 9 lines
https://patchwork.kernel.org/patch/10984579/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k