Skip to contentSkip to conversation

Patch "net: phylink: set the autoneg state in phylink_phy_change" has been added to the 5.1-stable tree

DISCUSSION Ioana Ciornei 2 participants 2 messages Jun 20, 2019 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 11 lines

Subject: Patch "net: phylink: set the autoneg state in phylink_phy_change" has been added to the 5.1-stable tree

This is a note to let you know that I've just added the patch titled

net: phylink: set the autoneg state in phylink_phy_change

to the 5.1-stable tree which can be found at:

Quoted 8 lines

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git

The filename of the patch is:
net-phylink-set-the-autoneg-state-in-phylink_phy_change.patch
and it can be found in the queue-5.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi all,

Sorry for the late response but this patch should not be added to stables trees since it was already reverted in net-next. More information can be found at: https://marc.info/?l=linux-netdev&m=156104162206869&w=2

Thanks,
Ioana

Quoted 40 lines

From foo@baz Wed 19 Jun 2019 02:33:45 PM CEST
From: Ioana Ciornei <[email protected]>
Date: Thu, 13 Jun 2019 09:37:51 +0300
Subject: net: phylink: set the autoneg state in phylink_phy_change

From: Ioana Ciornei <[email protected]>

[ Upstream commit ef7bfa84725d891bbdb88707ed55b2cbf94942bb ]

The phy_state field of phylink should carry only valid information especially when this can be passed to the .mac_config callback.
Update the an_enabled field with the autoneg state in the phylink_phy_change function.

Fixes 9525ae83959b ("phylink: add phylink infrastructure")
---
 drivers/net/phy/phylink.c |    1 +
 1 file changed, 1 insertion(+)
drivers/net/phy/phylink.c +1 -0
@@ -638,6 +638,7 @@ static void phylink_phy_change(struct ph
 		pl->phy_state.pause |= MLO_PAUSE_ASYM;
 	pl->phy_state.interface = phydev->interface;
 	pl->phy_state.link = up;
+	pl->phy_state.an_enabled = phydev->autoneg;
 	mutex_unlock(&pl->state_mutex);
 
 	phylink_run_resolve(pl);

Patches currently in stable-queue which might be from [email protected] are

queue-5.1/net-phylink-set-the-autoneg-state-in-phylink_phy_change.patch

#2 lore raw
Quoted 17 lines · Ioana Ciornei
Quoted 17 lines

Subject: Patch "net: phylink: set the autoneg state in phylink_phy_change" has been added to the 5.1-stable tree

This is a note to let you know that I've just added the patch titled

net: phylink: set the autoneg state in phylink_phy_change

to the 5.1-stable tree which can be found at:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git

The filename of the patch is:
net-phylink-set-the-autoneg-state-in-phylink_phy_change.patch
and it can be found in the queue-5.1 subdirectory.

Quoted 7 lines
Quoted 2 lines

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hi all,

Sorry for the late response but this patch should not be added to stables trees since it was already reverted in net-next. More information can be found at: https://marc.info/?l=linux-netdev&m=156104162206869&w=2

No problem, I've now dropped it from everywhere, thanks!

greg k-h