Skip to contentSkip to conversation

drm/komeda: Initialize and enable output polling on Komeda

PATCH In review Lowry Li (Arm Technology China) 2 participants 3 messages Jul 26, 2019 – Aug 1, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/komeda: Initialize and enable output polling on Komeda

Initialize and enable output polling on Komeda.

---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +4 -0
index 1462bac..26f2919 100644
@@ -15,6 +15,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_irq.h>
 #include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
 
 #include "komeda_dev.h"
 #include "komeda_framebuffer.h"
@@ -331,6 +332,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
 	if (err)
 		goto uninstall_irq;
 
+	drm_kms_helper_poll_init(drm);
+
 	return kms;
 
 uninstall_irq:
@@ -348,6 +351,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
 	struct drm_device *drm = &kms->base;
 	struct komeda_dev *mdev = drm->dev_private;
 
+	drm_kms_helper_poll_fini(drm);
 	mdev->funcs->disable_irq(mdev);
 	drm_dev_unregister(drm);
 	drm_irq_uninstall(drm);
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#1 lore raw
Quoted 20 lines · Lowry Li (Arm Technology China)

Initialize and enable output polling on Komeda.

---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +1 -0
index 1462bac..26f2919 100644
@@ -15,6 +15,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_irq.h>
 #include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
 
 #include "komeda_dev.h"
 #include "komeda_framebuffer.h"

drivers/gpu/drm/arm/display/komeda/komeda_kms.c struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev) · line 335

Quoted 4 lines
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +1 -0
@@ -331,6 +332,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
 	if (err)
 		goto uninstall_irq;
 
+	drm_kms_helper_poll_init(drm);

Most of the drivers call this before registering the driver. But this is all moot because I can't apply the patch on top of drm-misc-next, so not having full context of what komeda_kms_attach looks like in your tree.

Best regards,
Liviu

Quoted 15 lines
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +2 -0
+
 	return kms;
 
 uninstall_irq:
@@ -348,6 +351,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
 	struct drm_device *drm = &kms->base;
 	struct komeda_dev *mdev = drm->dev_private;
 
+	drm_kms_helper_poll_fini(drm);
 	mdev->funcs->disable_irq(mdev);
 	drm_dev_unregister(drm);
 	drm_irq_uninstall(drm);
Signature · 1 line
1.9.1
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
#2 lore raw

Hi Liviu,

Quoted 24 lines · Liviu Dudau
Quoted 23 lines · Lowry Li (Arm Technology China)

Initialize and enable output polling on Komeda.

---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +1 -0
index 1462bac..26f2919 100644
@@ -15,6 +15,7 @@
 #include <drm/drm_gem_framebuffer_helper.h>
 #include <drm/drm_irq.h>
 #include <drm/drm_vblank.h>
+#include <drm/drm_probe_helper.h>
 
 #include "komeda_dev.h"
 #include "komeda_framebuffer.h"
@@ -331,6 +332,8 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
 	if (err)
 		goto uninstall_irq;
 
Quoted 9 lines

drivers/gpu/drm/arm/display/komeda/komeda_kms.c struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev) · line 335

Quoted 1 line
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +1 -0
+	drm_kms_helper_poll_init(drm);

Most of the drivers call this before registering the driver. But this is all moot because I can't apply the patch on top of drm-misc-next, so not having full context of what komeda_kms_attach looks like in your tree.

Best regards,
Liviu

Yes, will refine this and rebase the code. Thanks a lot.

Best regards,
Lowry

Quoted 25 lines
Quoted 15 lines
drivers/gpu/drm/arm/display/komeda/komeda_kms.c +2 -0
+
 	return kms;
 
 uninstall_irq:
@@ -348,6 +351,7 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
 	struct drm_device *drm = &kms->base;
 	struct komeda_dev *mdev = drm->dev_private;
 
+	drm_kms_helper_poll_fini(drm);
 	mdev->funcs->disable_irq(mdev);
 	drm_dev_unregister(drm);
 	drm_irq_uninstall(drm);
Signature · 1 line
1.9.1
Signature · 8 lines
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
Signature · 6 lines
Regards,
Lowry
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel