Skip to contentSkip to conversation

riscv: qemu: Fix kconfig build warning

PATCH New Bin Meng 3 participants 4 messages Aug 8, 2019 1 message not in the archive RISC-V

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 riscv: qemu: Fix kconfig build warning

When 'make qemu-riscv64_defconfig', there is a build warning:

board/emulation/qemu-riscv/Kconfig:24:
warning: config symbol defined without type

Fix it by specifying the config symbol type to 'hex'.

---

 board/emulation/qemu-riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
board/emulation/qemu-riscv/Kconfig +1 -0
index 1928d6d..7ce1201 100644
@@ -22,6 +22,7 @@ config SPL_TEXT_BASE
 	default 0x80000000
 
 config SPL_OPENSBI_LOAD_ADDR
+	hex
 	default 0x81000000
 
 config BOARD_SPECIFIC_OPTIONS # dummy
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 1/1 riscv: qemu: Fix kconfig build warning

Hi Bin

Quoted 26 lines
Quoted 26 lines

From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Thursday, August 08, 2019 2:05 PM
To: Lukas Auer; Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List
Subject: [PATCH] riscv: qemu: Fix kconfig build warning

When 'make qemu-riscv64_defconfig', there is a build warning:

board/emulation/qemu-riscv/Kconfig:24:
warning: config symbol defined without type

Fix it by specifying the config symbol type to 'hex'.

---

 board/emulation/qemu-riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
board/emulation/qemu-riscv/Kconfig +0 -0
index 1928d6d..7ce1201 100644
@@ -22,6 +22,7 @@ config SPL_TEXT_BASE
      default 0x80000000
 
Quoted 8 lines
Quoted 7 lines
board/emulation/qemu-riscv/Kconfig +1 -1
 config SPL_OPENSBI_LOAD_ADDR
+     hex
      default 0x81000000
 
 config BOARD_SPECIFIC_OPTIONS # dummy
--

2.7.4

Good catch!

But I am wondering why SPL_TEXT_BASE will not have the same warning message? They are declared the same way.
Do you know why ?

author
#3 lore raw

PATCH 1/1 riscv: qemu: Fix kconfig build warning

Hi Rick,

Quoted 38 lines · Rick Chen

Hi Bin

Quoted 26 lines
Quoted 26 lines

From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Thursday, August 08, 2019 2:05 PM
To: Lukas Auer; Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List
Subject: [PATCH] riscv: qemu: Fix kconfig build warning

When 'make qemu-riscv64_defconfig', there is a build warning:

board/emulation/qemu-riscv/Kconfig:24:
warning: config symbol defined without type

Fix it by specifying the config symbol type to 'hex'.

---

 board/emulation/qemu-riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)
board/emulation/qemu-riscv/Kconfig +0 -0
index 1928d6d..7ce1201 100644
@@ -22,6 +22,7 @@ config SPL_TEXT_BASE
      default 0x80000000
 
Quoted 8 lines
Quoted 7 lines
board/emulation/qemu-riscv/Kconfig +1 -1
 config SPL_OPENSBI_LOAD_ADDR
+     hex
      default 0x81000000
 
 config BOARD_SPECIFIC_OPTIONS # dummy
--

2.7.4

Quoted 6 lines

Good catch!

But I am wondering why SPL_TEXT_BASE will not have the same warning message? They are declared the same way.
Do you know why ?

Because SPL_TEXT_BASE has a type defined in common/spl/Kconfig hence Kconfig knows its type.

Quoted 1 line

Regards,
Bin

#4 lore raw

PATCH 1/1 riscv: qemu: Fix kconfig build warning

In reply to Bin Meng
Quoted 5 lines · Bin Meng

When 'make qemu-riscv64_defconfig', there is a build warning:

board/emulation/qemu-riscv/Kconfig:24:
warning: config symbol defined without type

Quoted 8 lines

Fix it by specifying the config symbol type to 'hex'.

---

 board/emulation/qemu-riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Ah, I missed this. Thanks!