hw/sd/aspeed_sdhci: New device
RFC v3 1/1 hw/sd/aspeed_sdhci: New device
The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and models the Aspeed-specific registers and behavior.
Tested by reading from mmcblk0 in Linux:
qemu-system-arm -machine romulus-bmc -nographic \
-drive file=flash-romulus,format=raw,if=mtd \
-device sd-card,drive=sd0 -drive file=_tmp/kernel,format=raw,if=sd
---
This patch applies on top of Cedric's set of recent Aspeed changes. Therefore, I'm sending as an RFC rather than a patch for review.
Changes since v2:
- Do the memory mapping at the SOC level
- Add guest errors for out-of-bounds access to the SDHCI regs
- Remove unnecessary blockdev include in aspeed_soc.c
- Better naming for SDHCI objects.
Changes since v1:
- Move slot realize code into the Aspeed SDHCI realize function
- Fix interrupt handling by creating input irqs and connecting them to the slot irqs.
- Removed card device creation code
hw/arm/aspeed.c | 1 - hw/arm/aspeed_soc.c | 28 +++++++ hw/sd/Makefile.objs | 1 + hw/sd/aspeed_sdhci.c | 194 +++++++++++++++++++++++++++++++++++++++++++ include/hw/arm/aspeed_soc.h | 3 + include/hw/sd/aspeed_sdhci.h | 34 ++++++++ 6 files changed, 260 insertions(+), 1 deletion(-) create mode 100644 hw/sd/aspeed_sdhci.c create mode 100644 include/hw/sd/aspeed_sdhci.h
hw/arm/aspeed.c +0 -1
@@ -480,7 +480,6 @@ static void aspeed_machine_class_init(ObjectClass *oc, void *data) mc->desc = board->desc; mc->init = aspeed_machine_init; mc->max_cpus =ASPEED_CPUS_NUM ; - mc->no_sdcard =1 ; mc->no_floppy =1 ; mc->no_cdrom =1 ; mc->no_parallel =1 ;
hw/arm/aspeed_soc.c +28 -0
@@ -62,6 +62,7 @@ static const hwaddr aspeed_soc_ast2500_memmap[] = { [ASPEED_XDMA] = 0x1E6E7000, [ASPEED_ADC] = 0x1E6E9000, [ASPEED_SRAM] = 0x1E720000, + [ASPEED_SDHCI] = 0x1E740000, [ASPEED_GPIO] = 0x1E780000, [ASPEED_RTC] = 0x1E781000, [ASPEED_TIMER1] = 0x1E782000,
@@ -102,6 +103,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = { [ASPEED_XDMA] = 0x1E6E7000, [ASPEED_ADC] = 0x1E6E9000, [ASPEED_VIDEO] = 0x1E700000, + [ASPEED_SDHCI] = 0x1E740000, [ASPEED_GPIO] = 0x1E780000, [ASPEED_GPIO_1_8V] = 0x1E780800, [ASPEED_RTC] = 0x1E781000,
@@ -147,6 +149,7 @@ static const int aspeed_soc_ast2400_irqmap[] = { [ASPEED_ETH1] = 2, [ASPEED_ETH2] = 3, [ASPEED_XDMA] = 6, + [ASPEED_SDHCI] = 26, };#define aspeed_soc_ast2500_irqmap aspeed_soc_ast2400_irqmap
@@ -185,6 +188,7 @@ static const int aspeed_soc_ast2600_irqmap[] = { [ASPEED_ETH2] = 3, [ASPEED_FSI1] = 100, [ASPEED_FSI2] = 101, + [ASPEED_SDHCI] = 43, };static const AspeedSoCInfo aspeed_socs[] = {
@@ -357,6 +361,15 @@ static void aspeed_soc_init(Object *obj)sysbus_init_child_obj (obj,"fsi[*]" ,OBJECT (&s->fsi[0 ]),sizeof (s->fsi[0 ]),TYPE_ASPEED_FSI ); } + +sysbus_init_child_obj (obj,"sdc" ,OBJECT (&s->sdhci),sizeof (s->sdhci), +TYPE_ASPEED_SDHCI ); + +/* Init sd card slot class here so that they're under the correct parent */ +for (i =0 ; i <ASPEED_SDHCI_NUM_SLOTS ; ++i) { +sysbus_init_child_obj (obj,"sdhci[*]" ,OBJECT (&s->sdhci.slots[i]), +sizeof (s->sdhci.slots[i]),TYPE_SYSBUS_SDHCI ); + } }/*
@@ -698,6 +711,21 @@ static void aspeed_soc_realize(DeviceState *dev, Error **errp)sysbus_connect_irq (SYS_BUS_DEVICE (&s->fsi[0 ]),0 ,aspeed_soc_get_irq (s,ASPEED_FSI1 )); } + +/* SDHCI */ +object_property_set_bool (OBJECT (&s->sdhci), true,"realized" , &err); +if (err) { +error_propagate (errp, err); +return ; + } +for (i =0 ; i <ASPEED_SDHCI_NUM_SLOTS ; ++i) { +sysbus_mmio_map (SYS_BUS_DEVICE (&s->sdhci.slots[i]),0 , + sc->info->memmap[ASPEED_SDHCI ] + ((i +1 ) *0x100 )); + } +sysbus_mmio_map (SYS_BUS_DEVICE (&s->sdhci),0 , + sc->info->memmap[ASPEED_SDHCI ]); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->sdhci),0 , +aspeed_soc_get_irq (s,ASPEED_SDHCI )); }static Property aspeed_soc_properties[] = {DEFINE_PROP_UINT32 ("num-cpus" , AspeedSoCState, num_cpus,0 ),
hw/sd/Makefile.objs +1 -0
@@ -8,3 +8,4 @@ obj-$(CONFIG_MILKYMIST) += milkymist-memcard.o obj-$(CONFIG_OMAP) += omap_mmc.o obj-$(CONFIG_PXA2XX) += pxa2xx_mmci.o obj-$(CONFIG_RASPI) += bcm2835_sdhost.o +obj-$(CONFIG_ASPEED_SOC) += aspeed_sdhci.o
hw/sd/aspeed_sdhci.c new file +194 -0
194 lines not on this page · raw message
include/hw/arm/aspeed_soc.h +3 -0
@@ -29,6 +29,7 @@#include "hw/misc/aspeed_pwm.h" #include "hw/misc/aspeed_lpc.h" #include "hw/misc/aspeed_fsi.h" +#include "hw/sd/aspeed_sdhci.h" #define ASPEED_SPIS_NUM 2#define ASPEED_WDTS_NUM 4
@@ -63,6 +64,7 @@ typedef struct AspeedSoCState {AspeedPWMState pwm;AspeedLPCState lpc;AspeedFsiState fsi[2 ]; +AspeedSDHCIState sdhci; } AspeedSoCState;#define TYPE_ASPEED_SOC "aspeed-soc"
@@ -108,6 +110,7 @@ enum {ASPEED_ADC ,ASPEED_VIDEO ,ASPEED_SRAM , +ASPEED_SDHCI ,ASPEED_GPIO ,ASPEED_GPIO_1_8V , ASPEED_RTC,
include/hw/sd/aspeed_sdhci.h new file +34 -0
@@ -0,0 +1,34 @@ +/* +* Aspeed SD Host Controller +* Eddie James <[email protected]> +* +* Copyright (C) 2019 IBM Corp +* SPDX-License-Identifer: GPL-2.0-or-later +*/ + +#ifndef ASPEED_SDHCI_H +#define ASPEED_SDHCI_H + +#include "hw/sd/sdhci.h" + +#define TYPE_ASPEED_SDHCI "aspeed.sdhci" +#define ASPEED_SDHCI (obj) OBJECT_CHECK(AspeedSDHCIState, (obj), \ + TYPE_ASPEED_SDHCI) + +#define ASPEED_SDHCI_CAPABILITIES 0x01E80080 +#define ASPEED_SDHCI_NUM_SLOTS 2 +#define ASPEED_SDHCI_NUM_REGS (ASPEED_SDHCI_REG_SIZE / sizeof(uint32_t)) +#define ASPEED_SDHCI_REG_SIZE 0x100 + +typedef struct AspeedSDHCIState { +SysBusDevice parent; + +SDHCIState slots[ASPEED_SDHCI_NUM_SLOTS ]; + +MemoryRegion iomem; +qemu_irq irq; + +uint32_t regs[ASPEED_SDHCI_NUM_REGS ]; +}AspeedSDHCIState ; + +#endif /* ASPEED_SDHCI_H */
Signature · 1 line
1.8.3.1
Quoted 10 lines · Eddie James
The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and models the Aspeed-specific registers and behavior.
Tested by reading from mmcblk0 in Linux:
qemu-system-arm -machine romulus-bmc -nographic \
-drive file=flash-romulus,format=raw,if=mtd \
-device sd-card,drive=sd0 -drive file=_tmp/kernel,format=raw,if=sdSigned-off-by Eddie James <[email protected]>
Quoted 3 lines
---
This patch applies on top of Cedric's set of recent Aspeed changes. Therefore, I'm sending as an RFC rather than a patch for review.
I merged this patch in aspeed-4.2 and made the adjustments to move it to the top of the patchset after the GPIO model.
Thanks,
C.
Quoted 385 lines
Changes since v2:
- Do the memory mapping at the SOC level
- Add guest errors for out-of-bounds access to the SDHCI regs
- Remove unnecessary blockdev include inaspeed_soc.c
- Better naming for SDHCI objects.Changes since v1:
- Move slot realize code into the Aspeed SDHCI realize function
- Fix interrupt handling by creating input irqs and connecting them to the slot irqs.
- Removed card device creation codehw/arm/aspeed.c | 1 - hw/arm/aspeed_soc.c | 28 +++++++ hw/sd/Makefile.objs | 1 + hw/sd/aspeed_sdhci.c | 194 +++++++++++++++++++++++++++++++++++++++++++ include/hw/arm/aspeed_soc.h | 3 + include/hw/sd/aspeed_sdhci.h | 34 ++++++++ 6 files changed, 260 insertions(+), 1 deletion(-) create mode 100644 hw/sd/aspeed_sdhci.c create mode 100644 include/hw/sd/aspeed_sdhci.hhw/arm/aspeed.c +0
-1@@ -480,7 +480,6 @@ static void aspeed_machine_class_init(ObjectClass *oc, void *data) mc->desc = board->desc; mc->init = aspeed_machine_init; mc->max_cpus =ASPEED_CPUS_NUM ; - mc->no_sdcard =1 ; mc->no_floppy =1 ; mc->no_cdrom =1 ; mc->no_parallel =1 ;hw/arm/aspeed_soc.c +28
-0@@ -62,6 +62,7 @@ static const hwaddr aspeed_soc_ast2500_memmap[] = { [ASPEED_XDMA] = 0x1E6E7000, [ASPEED_ADC] = 0x1E6E9000, [ASPEED_SRAM] = 0x1E720000, + [ASPEED_SDHCI] = 0x1E740000, [ASPEED_GPIO] = 0x1E780000, [ASPEED_RTC] = 0x1E781000, [ASPEED_TIMER1] = 0x1E782000,@@ -102,6 +103,7 @@ static const hwaddr aspeed_soc_ast2600_memmap[] = { [ASPEED_XDMA] = 0x1E6E7000, [ASPEED_ADC] = 0x1E6E9000, [ASPEED_VIDEO] = 0x1E700000, + [ASPEED_SDHCI] = 0x1E740000, [ASPEED_GPIO] = 0x1E780000, [ASPEED_GPIO_1_8V] = 0x1E780800, [ASPEED_RTC] = 0x1E781000,@@ -147,6 +149,7 @@ static const int aspeed_soc_ast2400_irqmap[] = { [ASPEED_ETH1] = 2, [ASPEED_ETH2] = 3, [ASPEED_XDMA] = 6, + [ASPEED_SDHCI] = 26, };#define aspeed_soc_ast2500_irqmap aspeed_soc_ast2400_irqmap@@ -185,6 +188,7 @@ static const int aspeed_soc_ast2600_irqmap[] = { [ASPEED_ETH2] = 3, [ASPEED_FSI1] = 100, [ASPEED_FSI2] = 101, + [ASPEED_SDHCI] = 43, };static const AspeedSoCInfo aspeed_socs[] = {@@ -357,6 +361,15 @@ static void aspeed_soc_init(Object *obj)sysbus_init_child_obj (obj,"fsi[*]" ,OBJECT (&s->fsi[0 ]),sizeof (s->fsi[0 ]),TYPE_ASPEED_FSI ); } + +sysbus_init_child_obj (obj,"sdc" ,OBJECT (&s->sdhci),sizeof (s->sdhci), +TYPE_ASPEED_SDHCI ); + +/* Init sd card slot class here so that they're under the correct parent */ +for (i =0 ; i <ASPEED_SDHCI_NUM_SLOTS ; ++i) { +sysbus_init_child_obj (obj,"sdhci[*]" ,OBJECT (&s->sdhci.slots[i]), +sizeof (s->sdhci.slots[i]),TYPE_SYSBUS_SDHCI ); + } }/* @@ -698,6 +711,21 @@ static void aspeed_soc_realize(DeviceState *dev, Error **errp)sysbus_connect_irq (SYS_BUS_DEVICE (&s->fsi[0 ]),0 ,aspeed_soc_get_irq (s,ASPEED_FSI1 )); } + +/* SDHCI */ +object_property_set_bool (OBJECT (&s->sdhci), true,"realized" , &err); +if (err) { +error_propagate (errp, err); +return ; + } +for (i =0 ; i <ASPEED_SDHCI_NUM_SLOTS ; ++i) { +sysbus_mmio_map (SYS_BUS_DEVICE (&s->sdhci.slots[i]),0 , + sc->info->memmap[ASPEED_SDHCI ] + ((i +1 ) *0x100 )); + } +sysbus_mmio_map (SYS_BUS_DEVICE (&s->sdhci),0 , + sc->info->memmap[ASPEED_SDHCI ]); +sysbus_connect_irq (SYS_BUS_DEVICE (&s->sdhci),0 , +aspeed_soc_get_irq (s,ASPEED_SDHCI )); }static Property aspeed_soc_properties[] = {DEFINE_PROP_UINT32 ("num-cpus" , AspeedSoCState, num_cpus,0 ),hw/sd/Makefile.objs +1
-0@@ -8,3 +8,4 @@ obj-$(CONFIG_MILKYMIST) += milkymist-memcard.o obj-$(CONFIG_OMAP) += omap_mmc.o obj-$(CONFIG_PXA2XX) += pxa2xx_mmci.o obj-$(CONFIG_RASPI) += bcm2835_sdhost.o +obj-$(CONFIG_ASPEED_SOC) += aspeed_sdhci.ohw/sd/aspeed_sdhci.c new file +194
-0@@ -0,0 +1,194 @@ +/* +* Aspeed SD Host Controller +* Eddie James <[email protected]> +* +* Copyright (C) 2019 IBM Corp +* SPDX-License-Identifer: GPL-2.0-or-later +*/ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qemu/error-report.h" +#include "hw/sd/aspeed_sdhci.h" +#include "qapi/error.h" + +#define ASPEED_SDHCI_INFO 0x00 +#define ASPEED_SDHCI_INFO_RESET 0x00030000 +#define ASPEED_SDHCI_DEBOUNCE 0x04 +#define ASPEED_SDHCI_DEBOUNCE_RESET 0x00000005 +#define ASPEED_SDHCI_BUS 0x08 +#define ASPEED_SDHCI_SDIO_140 0x10 +#define ASPEED_SDHCI_SDIO_148 0x18 +#define ASPEED_SDHCI_SDIO_240 0x20 +#define ASPEED_SDHCI_SDIO_248 0x28 +#define ASPEED_SDHCI_WP_POL 0xec +#define ASPEED_SDHCI_CARD_DET 0xf0 +#define ASPEED_SDHCI_IRQ_STAT 0xfc + +#define TO_REG (addr) ((addr) / sizeof(uint32_t)) + +static uint64_t aspeed_sdhci_read (void *opaque,hwaddr addr,unsigned int size) +{ +uint32_t val =0 ; +AspeedSDHCIState *sdhci = opaque; + +switch (addr) { +case ASPEED_SDHCI_SDIO_140 : + val = (uint32_t )sdhci->slots[0 ].capareg; +break ; +case ASPEED_SDHCI_SDIO_148 : + val = (uint32_t )sdhci->slots[0 ].maxcurr; +break ; +case ASPEED_SDHCI_SDIO_240 : + val = (uint32_t )sdhci->slots[1 ].capareg; +break ; +case ASPEED_SDHCI_SDIO_248 : + val = (uint32_t )sdhci->slots[1 ].maxcurr; +break ; +default : +if (addr <ASPEED_SDHCI_REG_SIZE ) { + val = sdhci->regs[TO_REG (addr)]; + }else { +qemu_log_mask (LOG_GUEST_ERROR , +"%s: Out-of-bounds read at 0x%" HWADDR_PRIx"\n" , + __func__, addr); + } + } + +return (uint64_t )val; +} + +static void aspeed_sdhci_write (void *opaque,hwaddr addr,uint64_t val, +unsigned int size) +{ +AspeedSDHCIState *sdhci = opaque; + +switch (addr) { +case ASPEED_SDHCI_SDIO_140 : + sdhci->slots[0 ].capareg = (uint64_t )(uint32_t )val; +break ; +case ASPEED_SDHCI_SDIO_148 : + sdhci->slots[0 ].maxcurr = (uint64_t )(uint32_t )val; +break ; +case ASPEED_SDHCI_SDIO_240 : + sdhci->slots[1 ].capareg = (uint64_t )(uint32_t )val; +break ; +case ASPEED_SDHCI_SDIO_248 : + sdhci->slots[1 ].maxcurr = (uint64_t )(uint32_t )val; +break ; +default : +if (addr <ASPEED_SDHCI_REG_SIZE ) { + sdhci->regs[TO_REG (addr)] = (uint32_t )val; + }else { +qemu_log_mask (LOG_GUEST_ERROR , +"%s: Out-of-bounds write at 0x%" HWADDR_PRIx"\n" , + __func__, addr); + } + } +} + +static const MemoryRegionOps aspeed_sdhci_ops = { + .read = aspeed_sdhci_read, + .write = aspeed_sdhci_write, + .endianness =DEVICE_NATIVE_ENDIAN , + .valid.min_access_size =4 , + .valid.max_access_size =4 , +}; + +static void aspeed_sdhci_set_irq (void *opaque,int n,int level) +{ +AspeedSDHCIState *sdhci = opaque; + +if (level) { + sdhci->regs[TO_REG (ASPEED_SDHCI_IRQ_STAT )] |=BIT (n); + +qemu_irq_raise (sdhci->irq); + }else { + sdhci->regs[TO_REG (ASPEED_SDHCI_IRQ_STAT )] &= ~BIT (n); + +qemu_irq_lower (sdhci->irq); + } +} + +static void aspeed_sdhci_realize (DeviceState *dev,Error **errp) +{ +Error *err =NULL ; +SysBusDevice *sbd =SYS_BUS_DEVICE (dev); +AspeedSDHCIState *sdhci =ASPEED_SDHCI (dev); + +/* Create input irqs for the slots */ +qdev_init_gpio_in_named_with_opaque (DEVICE (sbd), aspeed_sdhci_set_irq, + sdhci,NULL ,ASPEED_SDHCI_NUM_SLOTS ); + +for (int i =0 ; i <ASPEED_SDHCI_NUM_SLOTS ; ++i) { +Object *sdhci_slot =OBJECT (&sdhci->slots[i]); +SysBusDevice *sbd_slot =SYS_BUS_DEVICE (&sdhci->slots[i]); + +object_property_set_int (sdhci_slot,2 ,"sd-spec-version" , &err); +if (err) { +error_propagate (errp, err); +return ; + } + +object_property_set_uint (sdhci_slot,ASPEED_SDHCI_CAPABILITIES , +"capareg" , &err); +if (err) { +error_propagate (errp, err); +return ; + } + +object_property_set_bool (sdhci_slot, true,"realized" , &err); +if (err) { +error_propagate (errp, err); +return ; + } + +sysbus_connect_irq (sbd_slot,0 ,qdev_get_gpio_in (DEVICE (sbd), i)); + } + +sysbus_init_irq (sbd, &sdhci->irq); +memory_region_init_io (&sdhci->iomem,OBJECT (sdhci), &aspeed_sdhci_ops, + sdhci,TYPE_ASPEED_SDHCI ,ASPEED_SDHCI_REG_SIZE ); +sysbus_init_mmio (sbd, &sdhci->iomem); +} + +static void aspeed_sdhci_reset (DeviceState *dev) +{ +AspeedSDHCIState *sdhci =ASPEED_SDHCI (dev); + +memset (sdhci->regs,0 ,ASPEED_SDHCI_REG_SIZE ); + sdhci->regs[TO_REG (ASPEED_SDHCI_INFO )] =ASPEED_SDHCI_INFO_RESET ; + sdhci->regs[TO_REG (ASPEED_SDHCI_DEBOUNCE )] =ASPEED_SDHCI_DEBOUNCE_RESET ; +} + +static const VMStateDescription vmstate_aspeed_sdhci = { + .name =TYPE_ASPEED_SDHCI , + .version_id =1 , + .fields = (VMStateField []) { +VMSTATE_UINT32_ARRAY (regs, AspeedSDHCIState,ASPEED_SDHCI_NUM_REGS ), +VMSTATE_END_OF_LIST (), + }, +}; + +static void aspeed_sdhci_class_init (ObjectClass *classp,void *data) +{ +DeviceClass *dc =DEVICE_CLASS (classp); + + dc->realize = aspeed_sdhci_realize; + dc->reset = aspeed_sdhci_reset; + dc->vmsd = &vmstate_aspeed_sdhci; +} + +static TypeInfo aspeed_sdhci_info = { + .name =TYPE_ASPEED_SDHCI , + .parent =TYPE_SYS_BUS_DEVICE , + .instance_size =sizeof (AspeedSDHCIState), + .class_init = aspeed_sdhci_class_init, +}; + +static void aspeed_sdhci_register_types (void ) +{ +type_register_static (&aspeed_sdhci_info); +} + +type_init (aspeed_sdhci_register_types)include/hw/arm/aspeed_soc.h +3
-0@@ -29,6 +29,7 @@#include "hw/misc/aspeed_pwm.h" #include "hw/misc/aspeed_lpc.h" #include "hw/misc/aspeed_fsi.h" +#include "hw/sd/aspeed_sdhci.h" #define ASPEED_SPIS_NUM 2#define ASPEED_WDTS_NUM 4@@ -63,6 +64,7 @@ typedef struct AspeedSoCState {AspeedPWMState pwm;AspeedLPCState lpc;AspeedFsiState fsi[2 ]; +AspeedSDHCIState sdhci; } AspeedSoCState;#define TYPE_ASPEED_SOC "aspeed-soc"@@ -108,6 +110,7 @@ enum {ASPEED_ADC ,ASPEED_VIDEO ,ASPEED_SRAM , +ASPEED_SDHCI ,ASPEED_GPIO ,ASPEED_GPIO_1_8V , ASPEED_RTC,include/hw/sd/aspeed_sdhci.h new file +34
-0@@ -0,0 +1,34 @@ +/* +* Aspeed SD Host Controller +* Eddie James <[email protected]> +* +* Copyright (C) 2019 IBM Corp +* SPDX-License-Identifer: GPL-2.0-or-later +*/ + +#ifndef ASPEED_SDHCI_H +#define ASPEED_SDHCI_H + +#include "hw/sd/sdhci.h" + +#define TYPE_ASPEED_SDHCI "aspeed.sdhci" +#define ASPEED_SDHCI (obj) OBJECT_CHECK(AspeedSDHCIState, (obj), \ + TYPE_ASPEED_SDHCI) + +#define ASPEED_SDHCI_CAPABILITIES 0x01E80080 +#define ASPEED_SDHCI_NUM_SLOTS 2 +#define ASPEED_SDHCI_NUM_REGS (ASPEED_SDHCI_REG_SIZE / sizeof(uint32_t)) +#define ASPEED_SDHCI_REG_SIZE 0x100 + +typedef struct AspeedSDHCIState { +SysBusDevice parent; + +SDHCIState slots[ASPEED_SDHCI_NUM_SLOTS ]; + +MemoryRegion iomem; +qemu_irq irq; + +uint32_t regs[ASPEED_SDHCI_NUM_REGS ]; +}AspeedSDHCIState ; + +#endif /* ASPEED_SDHCI_H */
Quoted 12 lines · Cédric Le Goater
Quoted 10 lines · Eddie James
The Aspeed SOCs have two SD/MMC controllers. Add a device that encapsulates both of these controllers and models the Aspeed-specific registers and behavior.
Tested by reading from mmcblk0 in Linux:
qemu-system-arm -machine romulus-bmc -nographic \
-drive file=flash-romulus,format=raw,if=mtd \
-device sd-card,drive=sd0 -drive file=_tmp/kernel,format=raw,if=sdSigned-off-by Eddie James <[email protected]>
Quoted 8 lines
Reviewed-by Cédric Le Goater <[email protected]>Quoted 3 lines
---
This patch applies on top of Cedric's set of recent Aspeed changes. Therefore, I'm sending as an RFC rather than a patch for review.I merged this patch in aspeed-4.2 and made the adjustments to move it to the top of the patchset after the GPIO model.
Hello,
What would be required to the model under linux-5.2 ?
Thanks,
C.