Skip to contentSkip to conversation

mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips

PATCH Applied Kamal Dasu 2 participants 2 messages Aug 26, 2019 – Aug 29, 2019

Subsystems (3)
lore
Share & tools
lore

Kamal Dasu

author
#0 lore raw

PATCH 1/1 mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips

From: Claire Lin <[email protected]>

In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation while correcting erased page bitflip.

Fixes 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
---
 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/mtd/nand/raw/brcmnand/brcmnand.c +4 -1
index 33310b8..15ef30b 100644
@@ -1792,6 +1792,7 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
 	int bitflips = 0;
 	int page = addr >> chip->page_shift;
 	int ret;
+	void *ecc_chunk;
 
 	if (!buf)
 		buf = nand_get_data_buf(chip);
@@ -1804,7 +1805,9 @@ static int brcmstb_nand_verify_erased_page(struct mtd_info *mtd,
 		return ret;
 
 	for (i = 0; i < chip->ecc.steps; i++, oob += sas) {
-		ret = nand_check_erased_ecc_chunk(buf, chip->ecc.size,
+		ecc_chunk = buf + chip->ecc.size * i;
+		ret = nand_check_erased_ecc_chunk(ecc_chunk,
+						  chip->ecc.size,
 						  oob, sas, NULL, 0,
 						  chip->ecc.strength);
 		if (ret < 0)
Signature · 1 line
1.9.0.138.g2de3478
maintainer Applied
#1 lore raw
Quoted 9 lines · Kamal Dasu

From: Claire Lin <[email protected]>

In brcmstb_nand_verify_erased_page(), fix ecc chunk pointer calculation while correcting erased page bitflip.

Fixes 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel