Skip to contentSkip to conversation

video/fbdev/68328fb: Remove dead code

PATCH In review Souptick Joarder 2 participants 2 messages Sep 2, 2019 – Jan 3, 2020 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video/fbdev/68328fb: Remove dead code

This is dead code since 3.15. If their is no plan to use it further, these can be removed forever.

---
 drivers/video/fbdev/68328fb.c | 12 ------------
 1 file changed, 12 deletions(-)
drivers/video/fbdev/68328fb.c +0 -12
index d48e960..02d22b7 100644
@@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 
 int __init mc68x328fb_setup(char *options)
 {
-#if 0
-	char *this_opt;
-#endif
-
 	if (!options || !*options)
 		return 1;
-#if 0
-	while ((this_opt = strsep(&options, ",")) != NULL) {
-		if (!*this_opt)
-			continue;
-		if (!strncmp(this_opt, "disable", 7))
-			mc68x328fb_enable = 0;
-	}
-#endif
 	return 1;
 }
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Souptick Joarder

This is dead code since 3.15. If their is no plan to use it further, these can be removed forever.

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 29 lines
---
 drivers/video/fbdev/68328fb.c | 12 ------------
 1 file changed, 12 deletions(-)
drivers/video/fbdev/68328fb.c +0 -12
index d48e960..02d22b7 100644
@@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 
 int __init mc68x328fb_setup(char *options)
 {
-#if 0
-	char *this_opt;
-#endif
-
 	if (!options || !*options)
 		return 1;
-#if 0
-	while ((this_opt = strsep(&options, ",")) != NULL) {
-		if (!*this_opt)
-			continue;
-		if (!strncmp(this_opt, "disable", 7))
-			mc68x328fb_enable = 0;
-	}
-#endif
 	return 1;
 }