Skip to contentSkip to conversation

storvsc: setup 1:1 mapping between hardware queue and CPU queue

PATCH Superseded [email protected] 3 participants 4 messages Sep 5, 2019 – Sep 6, 2019

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 storvsc: setup 1:1 mapping between hardware queue and CPU queue

From: Long Li <[email protected]>

storvsc doesn't use a dedicated hardware queue for a given CPU queue. When issuing I/O, it selects returning CPU (hardware queue) dynamically based on vmbus channel usage across all channels.

This patch advertises num_present_cpus() as number of hardware queues. This will have upper layer setup 1:1 mapping between hardware queue and CPU queue and avoid unnecessary locking when issuing I/O.

Changes:
v2: rely on default upper layer function to map queues. (suggested by Ming Lei <[email protected]>)
v3: use num_present_cpus() instead of num_online_cpus(). Hyper-v doesn't support hot-add CPUs. (suggested by Michael Kelley <[email protected]>)

---
 drivers/scsi/storvsc_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/storvsc_drv.c +1 -2
index b89269120a2d..cf987712041a 100644
@@ -1836,8 +1836,7 @@ static int storvsc_probe(struct hv_device *device,
 	/*
 	 * Set the number of HW queues we are supporting.
 	 */
-	if (stor_device->num_sc != 0)
-		host->nr_hw_queues = stor_device->num_sc + 1;
+	host->nr_hw_queues = num_present_cpus();
 
 	/*
 	 * Set the error handler work queue.
Signature · 1 line
2.17.1
#1 lore raw

From: Long Li <[email protected]> Sent: Thursday, September 5, 2019 3:55 PM

Quoted 9 lines

storvsc doesn't use a dedicated hardware queue for a given CPU queue. When issuing I/O, it selects returning CPU (hardware queue) dynamically based on vmbus channel usage across all channels.

This patch advertises num_present_cpus() as number of hardware queues. This will have upper layer setup 1:1 mapping between hardware queue and CPU queue and avoid unnecessary locking when issuing I/O.

Quoted 5 lines

Changes:
v2: rely on default upper layer function to map queues. (suggested by Ming Lei <[email protected]>)
v3: use num_present_cpus() instead of num_online_cpus(). Hyper-v doesn't support hot-add CPUs. (suggested by Michael Kelley <[email protected]>)

I've mostly seen the "Changes:" section placed below the "---" so that it doesn't clutter up the commit log. But maybe there's not a strong requirement one way or the other as I didn't find anything called out in the "Documentation/process" directory.

Michael

Quoted 22 lines
---
 drivers/scsi/storvsc_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/storvsc_drv.c +1 -3
index b89269120a2d..cf987712041a 100644
@@ -1836,8 +1836,7 @@ static int storvsc_probe(struct hv_device *device,
 	/*
 	 * Set the number of HW queues we are supporting.
 	 */
-	if (stor_device->num_sc != 0)
-		host->nr_hw_queues = stor_device->num_sc + 1;
+	host->nr_hw_queues = num_present_cpus();
 
 	/*
 	 * Set the error handler work queue.
--

2.17.1

#2 lore raw
Quoted 22 lines

Subject: RE: [Patch v3] storvsc: setup 1:1 mapping between hardware queue and CPU queue

From: Long Li <[email protected]> Sent: Thursday, September 5, 2019 3:55 PM

Quoted 9 lines

storvsc doesn't use a dedicated hardware queue for a given CPU queue. When issuing I/O, it selects returning CPU (hardware queue) dynamically based on vmbus channel usage across all channels.

This patch advertises num_present_cpus() as number of hardware queues. This will have upper layer setup 1:1 mapping between hardware queue and CPU queue and avoid unnecessary locking when issuing I/O.

Quoted 7 lines

Changes:
v2: rely on default upper layer function to map queues. (suggested by Ming Lei
<[email protected]>)
v3: use num_present_cpus() instead of num_online_cpus(). Hyper-v doesn't support hot-add CPUs. (suggested by Michael Kelley <[email protected]>)

Quoted 5 lines

I've mostly seen the "Changes:" section placed below the "---" so that it doesn't clutter up the commit log. But maybe there's not a strong requirement one way or the other as I didn't find anything called out in the "Documentation/process"
directory.

Should I resubmit the patch (but keep it v3)?

Quoted 25 lines

Michael

Quoted 22 lines
---
 drivers/scsi/storvsc_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/storvsc_drv.c +1 -3
index b89269120a2d..cf987712041a 100644
@@ -1836,8 +1836,7 @@ static int storvsc_probe(struct hv_device *device,
 	/*
 	 * Set the number of HW queues we are supporting.
 	 */
-	if (stor_device->num_sc != 0)
-		host->nr_hw_queues = stor_device->num_sc + 1;
+	host->nr_hw_queues = num_present_cpus();
 
 	/*
 	 * Set the error handler work queue.
--

2.17.1

#3 lore raw

From: Long Li <[email protected]> Sent: Thursday, September 5, 2019 8:35 PM

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

Changes:
v2: rely on default upper layer function to map queues. (suggested by Ming Lei
<[email protected]>)
v3: use num_present_cpus() instead of num_online_cpus(). Hyper-v doesn't support hot-add CPUs. (suggested by Michael Kelley <[email protected]>)

Quoted 8 lines
Quoted 5 lines

I've mostly seen the "Changes:" section placed below the "---" so that it doesn't clutter up the commit log. But maybe there's not a strong requirement one way or the other as I didn't find anything called out in the "Documentation/process"
directory.

Should I resubmit the patch (but keep it v3)?

I would say do a quick resubmit as v4 so there's no confusion.

Michael