Skip to contentSkip to conversation

net: Fix null de-reference of device refcount

PATCH In review Subash Abhinov Kasiviswanathan 2 participants 2 messages Sep 10, 2019 – Sep 12, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Fix null de-reference of device refcount

In event of failure during register_netdevice, free_netdev is invoked immediately. free_netdev assumes that all the netdevice refcounts have been dropped prior to it being called and as a result frees and clears out the refcount pointer.

However, this is not necessarily true as some of the operations in the NETDEV_UNREGISTER notifier handlers queue RCU callbacks for invocation after a grace period. The IPv4 callback in_dev_rcu_put tries to access the refcount after free_netdev is called which leads to a null de-reference-

44837.761523: <6> Unable to handle kernel paging request at

                    virtual address 0000004a88287000
44837.761651:   <2> pc : in_dev_finish_destroy+0x4c/0xc8
44837.761654:   <2> lr : in_dev_finish_destroy+0x2c/0xc8
44837.762393:   <2> Call trace:
44837.762398:   <2>  in_dev_finish_destroy+0x4c/0xc8
44837.762404:   <2>  in_dev_rcu_put+0x24/0x30
44837.762412:   <2>  rcu_nocb_kthread+0x43c/0x468
44837.762418:   <2>  kthread+0x118/0x128
44837.762424:   <2>  ret_from_fork+0x10/0x1c

Fix this by waiting for the completion of the call_rcu() in case of register_netdevice errors.

Fixes 93ee31f14f6f ("[NET]: Fix free_netdev on register_netdev failure.")
Cc Sean Tranchetti <[email protected]>
---
 net/core/dev.c | 2 ++
 1 file changed, 2 insertions(+)
net/core/dev.c +2 -0
index 49589ed..c7463c9 100644
@@ -8796,6 +8796,8 @@ int register_netdevice(struct net_device *dev)
 	ret = notifier_to_errno(ret);
 	if (ret) {
 		rollback_registered(dev);
+		rcu_barrier();
+
 		dev->reg_state = NETREG_UNREGISTERED;
 	}
 	/*
Signature · 1 line
1.9.1
maintainer
#1 lore raw

From: Subash Abhinov Kasiviswanathan <[email protected]>
Date: Tue, 10 Sep 2019 14:02:57 -0600

Quoted 10 lines

In event of failure during register_netdevice, free_netdev is invoked immediately. free_netdev assumes that all the netdevice refcounts have been dropped prior to it being called and as a result frees and clears out the refcount pointer.

However, this is not necessarily true as some of the operations in the NETDEV_UNREGISTER notifier handlers queue RCU callbacks for invocation after a grace period. The IPv4 callback in_dev_rcu_put tries to access the refcount after free_netdev is called which leads to a null de-reference-

...

Quoted 6 lines

Fix this by waiting for the completion of the call_rcu() in case of register_netdevice errors.

Fixes 93ee31f14f6f ("[NET]: Fix free_netdev on register_netdev failure.")
Cc Sean Tranchetti <[email protected]>

Applied and queued up for -stable.