Skip to contentSkip to conversation

fuse:send filep uid as part of fuse write req

PATCH In review Chakra Divi 2 participants 3 messages Sep 11, 2019 – Sep 12, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fuse:send filep uid as part of fuse write req

In current code in fuse write request current_fsuid is sent, however this creates an issue in sudo execution context. Changes to consider uid and gid from file struture pointer that is created as part of open file instead of current_fsuid,gid

Steps to reproduce the issue:
1) create user1 and user2
2) create a file1 with user1 on fusemount
3) change the file1 permissions to 600
4) execute the following command

user1@linux# sudo -u user2 whoami >> /fusemnt/file1
Here write fails with permission denied error

on nfs and ext4 - above use case is working, but on fuse its failing

---
 fs/fuse/file.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/fuse/file.c +4 -0
index 5ae2828..e1d223c 100644
@@ -1134,6 +1134,7 @@ static ssize_t fuse_perform_write(struct kiocb *iocb,
 	struct inode *inode = mapping->host;
 	struct fuse_conn *fc = get_fuse_conn(inode);
 	struct fuse_inode *fi = get_fuse_inode(inode);
+	struct file *file = iocb->ki_filp;
 	int err = 0;
 	ssize_t res = 0;
 
@@ -1150,6 +1151,9 @@ static ssize_t fuse_perform_write(struct kiocb *iocb,
 		if (IS_ERR(req)) {
 			err = PTR_ERR(req);
 			break;
+		} else {
+			req->in.h.uid = file->f_cred->uid.val;
+			req->in.h.gid = file->f_cred->gid.val;
 		}
 
 		count = fuse_fill_write_pages(req, mapping, ii, pos);
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · Chakra Divi

In current code in fuse write request current_fsuid is sent, however this creates an issue in sudo execution context. Changes to consider uid and gid from file struture pointer that is created as part of open file instead of current_fsuid,gid

Quoted 7 lines

Steps to reproduce the issue:
1) create user1 and user2
2) create a file1 with user1 on fusemount
3) change the file1 permissions to 600
4) execute the following command

user1@linux# sudo -u user2 whoami >> /fusemnt/file1
Here write fails with permission denied error

Not sure what's the issue here. If filesystem wants to check open creds, it should do so with the creds sent at open.

Does that solve your problem?

Thanks,
Miklos

maintainer
#3 lore raw
In reply to a message not in the archive
Quoted 20 lines · Chakra Divi

Hi Miklos,

Quoted 16 lines · Miklos Szeredi
Quoted 13 lines · Chakra Divi

In current code in fuse write request current_fsuid is sent, however this creates an issue in sudo execution context. Changes to consider uid and gid from file struture pointer that is created as part of open file instead of current_fsuid,gid

Steps to reproduce the issue:
1) create user1 and user2
2) create a file1 with user1 on fusemount
3) change the file1 permissions to 600
4) execute the following command

user1@linux# sudo -u user2 whoami >> /fusemnt/file1
Here write fails with permission denied error
Quoted 7 lines
Quoted 5 lines

Not sure what's the issue here. If filesystem wants to check open creds, it should do so with the creds sent at open.

Does that solve your problem?

Are you saying that our filesystem should store the credentials in open call, ignore the credentials in write request and use open credentials instead

Yes. And even that would be dubious in case of mmap-ed writes or with FUSE_WRITEBACK_CACHE because the information about which open file instance received the modification is lost.

So generally credential checking on writeback is useless. Not sure what NFS does, because there's no way to get around those rules.

Thanks,
Miklos