btrfs: removed unused return variable
PATCH 1/1 btrfs: removed unused return variable
From: Aliasgar Surti <[email protected]>
Removed unused return variable and replaced it with returning the value directly
Signed-off-by Aliasgar Surti <[email protected]>
--- fs/btrfs/disk-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/disk-io.c +2 -3
@@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,struct rb_node *node;struct btrfs_delayed_ref_root *delayed_refs;struct btrfs_delayed_ref_node *ref; -int ret =0 ; delayed_refs = &trans->delayed_refs;
@@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,if (atomic_read (&delayed_refs->num_entries) ==0 ) {spin_unlock (&delayed_refs->lock);btrfs_info (fs_info,"delayed_refs has NO entry" ); -return ret; +return 0 ; }while ((node =rb_first_cached (&delayed_refs->href_root)) !=NULL ) {
@@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,spin_unlock (&delayed_refs->lock); -return ret; +return 0 ; }static void btrfs_destroy_delalloc_inodes (struct btrfs_root *root)
Signature · 1 line
2.7.4
Quoted 6 lines · Aliasgar Surti
From: Aliasgar Surti <[email protected]>
Removed unused return variable and replaced it with returning the value directly
Signed-off-by Aliasgar Surti <[email protected]>
Actually this function should be turned to void and even the declaration at the top of disk-io can be removed.
Quoted 35 lines
--- fs/btrfs/disk-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)fs/btrfs/disk-io.c +2
-3@@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,struct rb_node *node;struct btrfs_delayed_ref_root *delayed_refs;struct btrfs_delayed_ref_node *ref; -int ret =0 ; delayed_refs = &trans->delayed_refs;@@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,if (atomic_read (&delayed_refs->num_entries) ==0 ) {spin_unlock (&delayed_refs->lock);btrfs_info (fs_info,"delayed_refs has NO entry" ); -return ret; +return 0 ; }while ((node =rb_first_cached (&delayed_refs->href_root)) !=NULL ) {@@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,spin_unlock (&delayed_refs->lock); -return ret; +return 0 ; }static void btrfs_destroy_delalloc_inodes (struct btrfs_root *root)
Quoted 5 lines · Nikolay Borisov
Quoted 2 lines · Aliasgar Surti
From: Aliasgar Surti <[email protected]>
Quoted 7 lines
Quoted 4 lines
Removed unused return variable and replaced it with returning the value directly
Signed-off-by Aliasgar Surti <[email protected]>Actually this function should be turned to void and even the declaration at the top of disk-io can be removed.
Okay, will send out v2 incorporating this change.
Thanks,
Aliasgar
Quoted 36 lines
Quoted 36 lines
--- fs/btrfs/disk-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)fs/btrfs/disk-io.c +2
-3@@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,struct rb_node *node;struct btrfs_delayed_ref_root *delayed_refs;struct btrfs_delayed_ref_node *ref; -int ret =0 ; delayed_refs = &trans->delayed_refs;@@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,if (atomic_read (&delayed_refs->num_entries) ==0 ) {spin_unlock (&delayed_refs->lock);btrfs_info (fs_info,"delayed_refs has NO entry" ); -return ret; +return 0 ; }while ((node =rb_first_cached (&delayed_refs->href_root)) !=NULL ) {@@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,spin_unlock (&delayed_refs->lock); -return ret; +return 0 ; }static void btrfs_destroy_delalloc_inodes (struct btrfs_root *root)