patch "media: stkwebcam: fix runtime PM after driver unbind" added to usb-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
media: stkwebcam: fix runtime PM after driver unbind
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 30045f2174aab7fb4db7a9cf902d0aa6c75856a7 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 1 Oct 2019 10:49:08 +0200
Subject: media: stkwebcam: fix runtime PM after driver unbind
Since commit c2b71462d294 ("USB: core: Fix bug caused by duplicate interface PM usage counter") USB drivers must always balance their runtime PM gets and puts, including when the driver has already been unbound from the interface.
Leaving the interface with a positive PM usage counter would prevent a later bound driver from suspending the device.
Note that runtime PM has never actually been enabled for this driver since the support_autosuspend flag in its usb_driver struct is not set.
--- drivers/media/usb/stkwebcam/stk-webcam.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/usb/stkwebcam/stk-webcam.c +1 -2
@@ -643,8 +643,7 @@ static int v4l_stk_release(struct file *fp) dev->owner =NULL ; } -if (is_present (dev)) -usb_autopm_put_interface (dev->interface); +usb_autopm_put_interface (dev->interface);mutex_unlock (&dev->lock);return v4l2_fh_release (fp); }
Signature · 1 line
2.23.0