Skip to contentSkip to conversation

drivers/net/wireless/realtek/rtlwifi/usb.c - fix some non-kerneldoc comments

PATCH In review Valdis Kl=?utf-8?Q?=c4=93?=tnieks 2 participants 2 messages Mar 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/wireless/realtek/rtlwifi/usb.c - fix some non-kerneldoc comments

Building with W=1:
CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand *
on line 243 - I thought it was a doc line
drivers/net/wireless/realtek/rtlwifi/usb.c:760: warning: Cannot understand *
on line 760 - I thought it was a doc line
drivers/net/wireless/realtek/rtlwifi/usb.c:790: warning: Cannot understand *
on line 790 - I thought it was a doc line

Fix comment blocks so they don't look like kerneldoc lines

drivers/net/wireless/realtek/rtlwifi/usb.c +3 -3
index e24fda5e9087..9478cc0d4f8b 100644
@@ -239,7 +239,7 @@ static void _rtl_usb_io_handler_release(struct ieee80211_hw *hw)
 	mutex_destroy(&rtlpriv->io.bb_mutex);
 }
 
-/**
+/*
  *
  *	Default aggregation handler. Do nothing and just return the oldest skb.
  */
@@ -756,7 +756,7 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
 	return err;
 }
 
-/**
+/*
  *
  *
  */
@@ -786,7 +786,7 @@ static void rtl_usb_cleanup(struct ieee80211_hw *hw)
 	usb_kill_anchored_urbs(&rtlusb->tx_submitted);
 }
 
-/**
+/*
  *
  * We may add some struct into struct rtl_usb later. Do deinit here.
  *
Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · Valdis Klētnieks

Building with W=1:
CC [M] drivers/net/wireless/realtek/rtlwifi/usb.o
drivers/net/wireless/realtek/rtlwifi/usb.c:243: warning: Cannot understand *
on line 243 - I thought it was a doc line
drivers/net/wireless/realtek/rtlwifi/usb.c:760: warning: Cannot understand *
on line 760 - I thought it was a doc line
drivers/net/wireless/realtek/rtlwifi/usb.c:790: warning: Cannot understand *
on line 790 - I thought it was a doc line

Fix comment blocks so they don't look like kerneldoc lines

drivers/net/wireless/realtek/rtlwifi/usb.c +2 -2
index e24fda5e9087..9478cc0d4f8b 100644
@@ -239,7 +239,7 @@ static void _rtl_usb_io_handler_release(struct ieee80211_hw *hw)
  	mutex_destroy(&rtlpriv->io.bb_mutex);
  }
 
-/**
+/*
   *
   *	Default aggregation handler. Do nothing and just return the oldest skb.
   */
@@ -756,7 +756,7 @@ static int rtl_usb_start(struct ieee80211_hw *hw)
  	return err;
  }
 
-/**
+/*
   *
   *
   */

drivers/net/wireless/realtek/rtlwifi/usb.c static void rtl_usb_cleanup(struct ieee80211_hw *hw) · line 792

Quoted 8 lines
drivers/net/wireless/realtek/rtlwifi/usb.c +1 -1
@@ -786,7 +786,7 @@ static void rtl_usb_cleanup(struct ieee80211_hw *hw)
  	usb_kill_anchored_urbs(&rtlusb->tx_submitted);
  }
 
-/**
+/*
   *
   * We may add some struct into struct rtl_usb later. Do deinit here.
   *

As these comments are 1 line at most, I would have changed the first and third instance to /* <contents of line> */, and deleted the second empty comment, but the content of this patch is OK. The subject line needs to be changed. It should start with "rtlwifi: rtl_usb: Fix some ...".

Once this change is made in v2, then

Larry