Skip to contentSkip to conversation

spl: Allow cache drivers to be used in SPL

PATCH Superseded Ley Foon Tan 4 participants 7 messages Nov 8, 2019 – Nov 29, 2019 Standalone cache controller drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Add an option for building cache drivers in SPL.

---
 common/spl/Kconfig     | 5 +++++
 drivers/Makefile       | 1 +
 drivers/cache/Makefile | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +5 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
 	  README.ubispl for more info.
 
 if SPL_DM
+config SPL_CACHE
+	bool "Support cache drivers in SPL"
+	help
+	  Enable support for cache drivers in SPL.
+
 config SPL_DM_SPI
 	bool "Support SPI DM drivers in SPL"
 	help
drivers/Makefile +1 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
 ifdef CONFIG_SPL_BUILD
 
 obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/
 obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
 obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
 obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +1 -1
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o
 obj-$(CONFIG_SANDBOX) += sandbox_cache.o
 obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
 obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Quoted 50 lines · Ley Foon Tan

Add an option for building cache drivers in SPL.

---
 common/spl/Kconfig     | 5 +++++
 drivers/Makefile       | 1 +
 drivers/cache/Makefile | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +5 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
          README.ubispl for more info.
 
 if SPL_DM
+config SPL_CACHE
+       bool "Support cache drivers in SPL"
+       help
+         Enable support for cache drivers in SPL.
+
 config SPL_DM_SPI
        bool "Support SPI DM drivers in SPL"
        help
drivers/Makefile +1 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
 ifdef CONFIG_SPL_BUILD
 
 obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/
 obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
 obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
 obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +1 -2
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o
 obj-$(CONFIG_SANDBOX) += sandbox_cache.o
 obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
 obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
--
Quoted 1 line

2.19.0

Hi Tom

Any comment on this patch?

Regards

Ley Foon

#2 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Ley, Tom,

Am 26.11.2019 um 10:26 schrieb Ley Foon Tan:

Quoted 3 lines · Ley Foon Tan
Quoted 2 lines

Add an option for building cache drivers in SPL.

Ley:

What's the actual problem here? Can you further describe your change? Why do you need to change drivers/cache/Makefile? That seems to only make sense if you enable the new SPL_CACHE without (non-SPL) CACHE.

However, the series this was pulled out from adds a new cache driver and makes it select CACHE, not SPL_CACHE, so how would this be activated anyway?

Maybe it would be better to always dive down into drivers/cache/ if CACHE is y?

Tom:

As drivers/cache is rather new and initiated via the socfpga tree, would you be OK for us to take this via the socfpga/next tree once it's sorted out?

Regards,
Simon

Quoted 57 lines
Quoted 48 lines
---
  common/spl/Kconfig     | 5 +++++
  drivers/Makefile       | 1 +
  drivers/cache/Makefile | 2 +-
  3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +5 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
           README.ubispl for more info.
 
  if SPL_DM
+config SPL_CACHE
+       bool "Support cache drivers in SPL"
+       help
+         Enable support for cache drivers in SPL.
+
  config SPL_DM_SPI
         bool "Support SPI DM drivers in SPL"
         help
drivers/Makefile +1 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
  ifdef CONFIG_SPL_BUILD
 
  obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/
  obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
  obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
  obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +1 -2
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o
  obj-$(CONFIG_SANDBOX) += sandbox_cache.o
  obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
  obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
--
Quoted 1 line

2.19.0

Hi Tom

Any comment on this patch?

Regards

Ley Foon

#3 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Quoted 16 lines · Simon Goldschmidt

Ley, Tom,

Am 26.11.2019 um 10:26 schrieb Ley Foon Tan:

Quoted 3 lines · Ley Foon Tan
Quoted 2 lines

Add an option for building cache drivers in SPL.

Ley:

What's the actual problem here? Can you further describe your change? Why do you need to change drivers/cache/Makefile? That seems to only make sense if you enable the new SPL_CACHE without (non-SPL) CACHE.

However, the series this was pulled out from adds a new cache driver and makes it select CACHE, not SPL_CACHE, so how would this be activated anyway?

Quoted 7 lines

Maybe it would be better to always dive down into drivers/cache/ if CACHE is y?

Tom:

As drivers/cache is rather new and initiated via the socfpga tree, would you be OK for us to take this via the socfpga/next tree once it's sorted out?

Sounds good, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191127/46705394/attachment.sig>
#4 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

In reply to Simon Goldschmidt
Quoted 14 lines · Simon Goldschmidt

Ley, Tom,

Am 26.11.2019 um 10:26 schrieb Ley Foon Tan:

Quoted 3 lines · Ley Foon Tan
Quoted 2 lines

Add an option for building cache drivers in SPL.

Ley:

What's the actual problem here? Can you further describe your change? Why do you need to change drivers/cache/Makefile? That seems to only make sense if you enable the new SPL_CACHE without (non-SPL) CACHE.

Quoted 5 lines

However, the series this was pulled out from adds a new cache driver and makes it select CACHE, not SPL_CACHE, so how would this be activated anyway?

Maybe it would be better to always dive down into drivers/cache/ if CACHE is y?

Hi Simon

The existing drivers/cache is only build when compile for Uboot proper, but not SPL build.
So, this patch mainly is to allow drivers/cache to compile in SPL build. User can enable CONFIG_SPL_CACHE if they need to include drivers/cache in SPL, eg: Agilex platform.

Regards
Ley Foon

Quoted 68 lines

Tom:

As drivers/cache is rather new and initiated via the socfpga tree, would you be OK for us to take this via the socfpga/next tree once it's sorted out?

Regards,
Simon

Quoted 57 lines
Quoted 48 lines
---
  common/spl/Kconfig     | 5 +++++
  drivers/Makefile       | 1 +
  drivers/cache/Makefile | 2 +-
  3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +5 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
           README.ubispl for more info.
 
  if SPL_DM
+config SPL_CACHE
+       bool "Support cache drivers in SPL"
+       help
+         Enable support for cache drivers in SPL.
+
  config SPL_DM_SPI
         bool "Support SPI DM drivers in SPL"
         help
drivers/Makefile +1 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
  ifdef CONFIG_SPL_BUILD
 
  obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/
  obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
  obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
  obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +1 -2
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o
  obj-$(CONFIG_SANDBOX) += sandbox_cache.o
  obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
  obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
--
Quoted 1 line

2.19.0

Hi Tom

Any comment on this patch?

Regards

Ley Foon

#5 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Quoted 22 lines · Ley Foon Tan
Quoted 14 lines · Simon Goldschmidt

Ley, Tom,

Am 26.11.2019 um 10:26 schrieb Ley Foon Tan:

Quoted 3 lines · Ley Foon Tan
Quoted 2 lines

Add an option for building cache drivers in SPL.

Ley:

What's the actual problem here? Can you further describe your change? Why do you need to change drivers/cache/Makefile? That seems to only make sense if you enable the new SPL_CACHE without (non-SPL) CACHE.

Quoted 5 lines

However, the series this was pulled out from adds a new cache driver and makes it select CACHE, not SPL_CACHE, so how would this be activated anyway?

Maybe it would be better to always dive down into drivers/cache/ if CACHE is y?

Quoted 7 lines

Hi Simon

The existing drivers/cache is only build when compile for Uboot proper, but not SPL build.
So, this patch mainly is to allow drivers/cache to compile in SPL build. User can enable CONFIG_SPL_CACHE if they need to include drivers/cache in SPL, eg: Agilex platform.

But you might not have CACHE enabled since you can enable SPL_CACHE without CACHE, see my suggestions below.

Quoted 29 lines

Regards
Ley Foon

Quoted 25 lines

Tom:

As drivers/cache is rather new and initiated via the socfpga tree, would you be OK for us to take this via the socfpga/next tree once it's sorted out?

Regards,
Simon

Quoted 15 lines
Quoted 15 lines
---
  common/spl/Kconfig     | 5 +++++
  drivers/Makefile       | 1 +
  drivers/cache/Makefile | 2 +-
  3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +0 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
           README.ubispl for more info.
 
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

common/spl/Kconfig config SPL_UBI · line 718

Quoted 3 lines
common/spl/Kconfig +2 -0
  if SPL_DM
+config SPL_CACHE
+       bool "Support cache drivers in SPL"

I think this needs to depend on CACHE.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
common/spl/Kconfig +3 -0
+       help
+         Enable support for cache drivers in SPL.
+
  config SPL_DM_SPI
         bool "Support SPI DM drivers in SPL"
         help
drivers/Makefile +0 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
  ifdef CONFIG_SPL_BUILD
 
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/Makefile ifndef CONFIG_TPL_BUILD · line 34

Quoted 2 lines
drivers/Makefile +1 -0
  obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/

Can you move this up to the common part and make it:

obj-$(CONFIG_$(SPL_TPL_)CACHE) += cache/

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

drivers/cache/Makefile line 2

Quoted 11 lines
drivers/Makefile +0 -0
  obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
  obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
  obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +1 -1
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o

This should then probably be $(SPL_TPL), too?

Although we don't have CONFIG_TPL_CACHE, yet, it might be better like that to prevent including cache drivers in TPL?

Regards,
Simon

Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 5 lines
drivers/cache/Makefile +0 -1
  obj-$(CONFIG_SANDBOX) += sandbox_cache.o
  obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
  obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
--

2.19.0

Hi Tom

Any comment on this patch?

Regards

Ley Foon

#6 lore raw

PATCH 1/1 spl: Allow cache drivers to be used in SPL

Quoted 64 lines · Simon Goldschmidt
Quoted 22 lines · Ley Foon Tan
Quoted 14 lines · Simon Goldschmidt

Ley, Tom,

Am 26.11.2019 um 10:26 schrieb Ley Foon Tan:

Quoted 3 lines · Ley Foon Tan
Quoted 2 lines

Add an option for building cache drivers in SPL.

Ley:

What's the actual problem here? Can you further describe your change? Why do you need to change drivers/cache/Makefile? That seems to only make sense if you enable the new SPL_CACHE without (non-SPL) CACHE.

Quoted 5 lines

However, the series this was pulled out from adds a new cache driver and makes it select CACHE, not SPL_CACHE, so how would this be activated anyway?

Maybe it would be better to always dive down into drivers/cache/ if CACHE is y?

Quoted 7 lines

Hi Simon

The existing drivers/cache is only build when compile for Uboot proper, but not SPL build.
So, this patch mainly is to allow drivers/cache to compile in SPL build. User can enable CONFIG_SPL_CACHE if they need to include drivers/cache in SPL, eg: Agilex platform.

But you might not have CACHE enabled since you can enable SPL_CACHE without CACHE, see my suggestions below.

Quoted 29 lines

Regards
Ley Foon

Quoted 25 lines

Tom:

As drivers/cache is rather new and initiated via the socfpga tree, would you be OK for us to take this via the socfpga/next tree once it's sorted out?

Regards,
Simon

Quoted 15 lines
Quoted 15 lines
---
  common/spl/Kconfig     | 5 +++++
  drivers/Makefile       | 1 +
  drivers/cache/Makefile | 2 +-
  3 files changed, 7 insertions(+), 1 deletion(-)
common/spl/Kconfig +0 -0
index c661809923..6e095c33e1 100644
@@ -714,6 +714,11 @@ config SPL_UBI
           README.ubispl for more info.
 
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

common/spl/Kconfig config SPL_UBI · line 718

Quoted 3 lines
common/spl/Kconfig +2 -0
  if SPL_DM
+config SPL_CACHE
+       bool "Support cache drivers in SPL"

I think this needs to depend on CACHE.

Okay.

Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
common/spl/Kconfig +3 -0
+       help
+         Enable support for cache drivers in SPL.
+
  config SPL_DM_SPI
         bool "Support SPI DM drivers in SPL"
         help
drivers/Makefile +0 -0
index 0befeddfcb..0e42d006b9 100644
@@ -31,6 +31,7 @@ ifndef CONFIG_TPL_BUILD
  ifdef CONFIG_SPL_BUILD
 
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/Makefile ifndef CONFIG_TPL_BUILD · line 34

Quoted 2 lines
drivers/Makefile +1 -0
  obj-$(CONFIG_SPL_BOOTCOUNT_LIMIT) += bootcount/
+obj-$(CONFIG_SPL_CACHE) += cache/

Can you move this up to the common part and make it:

Noted.

Quoted 12 lines

obj-$(CONFIG_$(SPL_TPL_)CACHE) += cache/

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/Makefile +0 -0
  obj-$(CONFIG_SPL_CPU_SUPPORT) += cpu/
  obj-$(CONFIG_SPL_CRYPTO_SUPPORT) += crypto/
  obj-$(CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT) += ddr/fsl/
drivers/cache/Makefile +0 -0
index 4a6458c602..c1f766cfca 100644
@@ -1,5 +1,5 @@
 
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/cache/Makefile line 2

Quoted 2 lines
drivers/cache/Makefile +1 -1
-obj-$(CONFIG_CACHE) += cache-uclass.o
+obj-$(CONFIG_$(SPL_)CACHE) += cache-uclass.o

This should then probably be $(SPL_TPL), too?

Although we don't have CONFIG_TPL_CACHE, yet, it might be better like that to prevent including cache drivers in TPL?

Okay.

Regards
Ley Foon

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
Quoted 6 lines
drivers/cache/Makefile +0 -1
  obj-$(CONFIG_SANDBOX) += sandbox_cache.o
  obj-$(CONFIG_L2X0_CACHE) += cache-l2x0.o
  obj-$(CONFIG_V5L2_CACHE) += cache-v5l2.o
--

2.19.0

Hi Tom

Any comment on this patch?

Regards

Ley Foon