Skip to contentSkip to conversation

patch "usb: gadget: configfs: Fix missing spin_lock_init()" added to usb-next

PATCH [email protected] 1 participant 1 message Nov 21, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: gadget: configfs: Fix missing spin_lock_init()

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-next branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will also be merged in the next major kernel release during the merge window.

If you have any questions about this process, please let me know.

From 093edc2baad2c258b1f55d1ab9c63c2b5ae67e42 Mon Sep 17 00:00:00 2001
From: Wei Yongjun <[email protected]>
Date: Wed, 30 Oct 2019 03:40:46 +0000
Subject: usb: gadget: configfs: Fix missing spin_lock_init()

The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly.

This is detected by Coccinelle semantic patch.

Fixes 1a1c851bbd70 ("usb: gadget: configfs: fix concurrent issue between composite APIs")
Cc stable <[email protected]>
---
 drivers/usb/gadget/configfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/gadget/configfs.c +1 -0
index 33852c2b29d1..ab9ac48a751a 100644
@@ -1544,6 +1544,7 @@ static struct config_group *gadgets_make(
 	gi->composite.resume = NULL;
 	gi->composite.max_speed = USB_SPEED_SUPER;
 
+	spin_lock_init(&gi->spinlock);
 	mutex_init(&gi->lock);
 	INIT_LIST_HEAD(&gi->string_list);
 	INIT_LIST_HEAD(&gi->available_func);
Signature · 1 line
2.24.0