arm: socfpga: add kernel parameter for immediate reboot
Ooi
PATCH 1/1 arm: socfpga: add kernel parameter for immediate reboot
Add Linux kernel line parameters for Stratix10 U-Boot. The "panic=-1" indicates the reset should occur immediately (without a delay)
--- include/configs/socfpga_stratix10_socdk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/socfpga_stratix10_socdk.h +1 -1
@@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);* CONFIG_BOOTARGS goes into the environment value "bootargs". * Do note the value will override also the chosen node in FDT blob. */ -#define CONFIG_BOOTARGS "earlycon" +#define CONFIG_BOOTARGS "earlycon panic=-1"#define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \ "run mmcboot"
Signature · 1 line
1.9.1
PATCH 1/1 arm: socfpga: add kernel parameter for immediate reboot
Quoted 7 lines · Joyce
Add Linux kernel line parameters for Stratix10 U-Boot. The "panic=-1" indicates the reset should occur immediately (without a delay)
Signed-off-by Thor Thayer <[email protected]>Signed-off-by Ooi, Joyce <[email protected]>
You might want to send socfpga patches to the U-Boot socfpga maintainers as well...
Quoted 9 lines
--- include/configs/socfpga_stratix10_socdk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/configs/socfpga_stratix10_socdk.h +0
-0
include/configs/socfpga_stratix10_socdk.h unsigned int cm_get_qspi_controller_clk_hz(void); · line 91
Quoted 5 lines
include/configs/socfpga_stratix10_socdk.h +1
-1@@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);* CONFIG_BOOTARGS goes into the environment value "bootargs". * Do note the value will override also the chosen node in FDT blob. */ -#define CONFIG_BOOTARGS "earlycon" +#define CONFIG_BOOTARGS "earlycon panic=-1"
That looks a bit like a hack. In my opinion, bootargs should be provided by the boot configuration (e.g. included in devicetree), not hardcoded in the bootloader.
I'd rather take a patch that removes this line than adding more.
Regards,
Simon
Quoted 6 lines
include/configs/socfpga_stratix10_socdk.h +0
-1#define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \ "run mmcboot" --1.9.1
Nguyen
PATCH 1/1 arm: socfpga: add kernel parameter for immediate reboot
Quoted 44 lines
-----Original Message-----
From: Simon Goldschmidt <[email protected]>
Sent: Thursday, November 21, 2019 9:28 AM
To: Ooi, Joyce <[email protected]>
Cc: See, Chin Liang <[email protected]>; Nguyen, Dinh <[email protected]>; U-Boot Mailing List <[email protected]>; Ang, Chee Hong <[email protected]>
Subject: Re: [U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate rebootQuoted 7 lines · Joyce
Add Linux kernel line parameters for Stratix10 U-Boot.
The "panic=-1" indicates the reset should occur immediately (without a delay)Signed-off-by Thor Thayer <[email protected]>Signed-off-by Ooi, Joyce <[email protected]>You might want to send socfpga patches to the U-Boot socfpga maintainers as well...
Quoted 10 lines
--- include/configs/socfpga_stratix10_socdk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/configs/socfpga_stratix10_socdk.h +0
-0include/configs/socfpga_stratix10_socdk.h unsigned int cm_get_qspi_controller_clk_hz(void); · line 91
Quoted 5 lines
include/configs/socfpga_stratix10_socdk.h +1
-1@@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);* CONFIG_BOOTARGS goes into the environment value "bootargs". * Do note the value will override also the chosen node in FDT blob. */ -#define CONFIG_BOOTARGS "earlycon" +#define CONFIG_BOOTARGS "earlycon panic=-1"That looks a bit like a hack. In my opinion, bootargs should be provided by the boot configuration (e.g. included in devicetree), not hardcoded in the bootloader.
Quoted 1 line
I'd rather take a patch that removes this line than adding more.
Agreed! Also, what's the reason that you want to force an immediate reboot when a panic happens?
Dinh