Skip to contentSkip to conversation

btrfs-progs: tests: mkfs/011: Fix path for rootdir

PATCH In review Long An 3 participants 3 messages Dec 17, 2019 – Dec 20, 2019 Btrfs file system

lore
Share & tools
lore

Long An

author
#0 lore raw

PATCH 1/1 btrfs-progs: tests: mkfs/011: Fix path for rootdir

Documentation folder path is wrong on exported testsutie. Fix this by replace TOP with INTERNAL_BIN.

---
 tests/mkfs-tests/011-rootdir-create-file/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/mkfs-tests/011-rootdir-create-file/test.sh +1 -1
index 20f7c4ce..a21c6245 100755
@@ -10,6 +10,6 @@ check_prereq mkfs.btrfs
 tmp=$(mktemp -d --tmpdir btrfs-progs-mkfs.rootdirXXXXXXX)
 # we can't use TEST_DEV, a file is needed
 img=$(mktemp btrfs-progs-mkfs.rootdirXXXXXXX)
-run_check "$TOP/mkfs.btrfs" -f --rootdir "$TOP/Documentation/" "$img"
+run_check "$TOP/mkfs.btrfs" -f --rootdir "$INTERNAL_BIN/Documentation/" "$img"
 
 rm -rf -- "$img"
#1 lore raw
Quoted 2 lines · Long An

Documentation folder path is wrong on exported testsutie. Fix this by replace TOP with INTERNAL_BIN.

It feels wrong that the tests use INTERNAL_BIN but it obviously exists and works so I'll apply the patch but maybe this could use some cleanup. Thanks.

#2 lore raw
Quoted 8 lines · David Sterba
Quoted 2 lines · Long An

Documentation folder path is wrong on exported testsutie. Fix this by replace TOP with INTERNAL_BIN.

It feels wrong that the tests use INTERNAL_BIN but it obviously exists and works so I'll apply the patch but maybe this could use some cleanup. Thanks.

The patch itself is kinda OK, but I guess we'd better to have some file generation function to test mkfs.btrfs --rootdir.

Thanks,
Qu