Skip to contentSkip to conversation

fput: Use unbound workqueue for scheduling delayed fput works

PATCH RESEND In review [email protected] 2 participants 2 messages Dec 17, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 fput: Use unbound workqueue for scheduling delayed fput works

From: chenqiwu <[email protected]>

There is a potential starvation that the number of delayed fput works increase rapidly if task exit storm or fs unmount issue happens.

Since the delayed fput works are expected to be executed as soon as possible. The commonly accepted wisdom that the measurements of scheduling works via the unbound workqueue show lowered worst-case latency responses of up to 5x over bound workqueue.

Work items queued to an unbound wq are not bound to any specific CPU, not concurrency managed. All queued works are executed immediately as long as max_active limit is not reached and resources are available.

---
 fs/file_table.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/file_table.c +2 -1
index 30d55c9..472ad92 100644
@@ -348,7 +348,8 @@ void fput_many(struct file *file, unsigned int refs)
 		}
 
 		if (llist_add(&file->f_u.fu_llist, &delayed_fput_list))
-			schedule_delayed_work(&delayed_fput_work, 1);
+			queue_delayed_work(system_unbound_wq,
+					&delayed_fput_work, 1);
 	}
 }
 
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 4 lines · On Tue, Dec 17, 2019 at 11:11:12PM +0800, [email protected] wrote:

From: chenqiwu <[email protected]>

There is a potential starvation that the number of delayed fput works increase rapidly if task exit storm or fs unmount issue happens.

Err... Details, please, ideally along with a reproducer. In particular, I would like to understand what does any of that have to do with umount. Or to task exits, for that matter - exit_files() is called before exit_task_work(), so you shouldn't normally be seeing task_work_add() failures when files get closed on exit(2)...

If you are really observing such problems, it might be worth looking into the underlying situation - something odd appears to be going on and I'd rather understand what it is.