patch "iio: light: vcnl4000: Fix scale for vcnl4040" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: light: vcnl4000: Fix scale for vcnl4040
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From bc80573ea25bb033a58da81b3ce27205b97c088e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <[email protected]>
Date: Fri, 27 Dec 2019 11:22:54 +0100
Subject: iio: light: vcnl4000: Fix scale for vcnl4040
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
According to the data sheet the ambient sensor's scale is 0.12 lux/step (not 0.024 lux/step as used by vcnl4200) when the integration time is 80ms. The integration time is currently hardcoded in the driver to that value.
See p. 8 in https://www.vishay.com/docs/84307/designingvcnl4040.pdf
--- drivers/iio/light/vcnl4000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iio/light/vcnl4000.c +2 -1
@@ -163,7 +163,6 @@ static int vcnl4200_init(struct vcnl4000_data *data)if (ret <0 )return ret; - data->al_scale =24000 ; data->vcnl4200_al.reg =VCNL4200_AL_DATA ; data->vcnl4200_ps.reg =VCNL4200_PS_DATA ;switch (id) {
@@ -172,11 +171,13 @@ static int vcnl4200_init(struct vcnl4000_data *data)/* show 54ms in total. */ data->vcnl4200_al.sampling_rate =ktime_set (0 ,54000 *1000 ); data->vcnl4200_ps.sampling_rate =ktime_set (0 ,4200 *1000 ); + data->al_scale =24000 ;break ;case VCNL4040_PROD_ID :/* Integration time is 80ms, add 10ms. */ data->vcnl4200_al.sampling_rate =ktime_set (0 ,100000 *1000 ); data->vcnl4200_ps.sampling_rate =ktime_set (0 ,100000 *1000 ); + data->al_scale =120000 ;break ; } data->vcnl4200_al.last_measurement =ktime_set (0 ,0 );
Signature · 1 line
2.24.1