Skip to contentSkip to conversation

SCSI fixes for 5.5-rc6

GIT PULL Merged James Bottomley 2 participants 2 messages Jan 14, 2020

Subsystems (2)
lore
Share & tools
lore

James Bottomley

author maintainer
#0 lore raw

Two simple fixes in the upper drivers (so both fairly core), one in enclosures, which fixes replugging a device into an enclosure slot and one in the disk driver which fixes revalidating a drive with protection information (PI) to make it a non-PI drive ... previously we were still remembering the old PI state. Both fixed issues are quite rare in the field.

The patch is available here:

git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes

The short changelog is:

James Bottomley (1):
scsi: enclosure: Fix stale device oops with hot replug

Xiang Chen (1):

      scsi: sd: Clear sdkp->protection_type if disk is reformatted without PI

And the diffstat:

 drivers/misc/enclosure.c | 3 +--
 drivers/scsi/sd.c        | 4 +++-
 2 files changed, 4 insertions(+), 3 deletions(-)

With full diff below.

James

---

drivers/misc/enclosure.c +1 -2
index 6d27ccfe0680..3c2d405bc79b 100644
@@ -406,10 +406,9 @@ int enclosure_remove_device(struct enclosure_device *edev, struct device *dev)
 		cdev = &edev->component[i];
 		if (cdev->dev == dev) {
 			enclosure_remove_links(cdev);
-			device_del(&cdev->cdev);
 			put_device(dev);
 			cdev->dev = NULL;
-			return device_add(&cdev->cdev);
+			return 0;
 		}
 	}
 	return -ENODEV;
drivers/scsi/sd.c +3 -1
index cea625906440..65ce10c7989c 100644
@@ -2211,8 +2211,10 @@ static int sd_read_protection_type(struct scsi_disk *sdkp, unsigned char *buffer
 	u8 type;
 	int ret = 0;
 
-	if (scsi_device_protection(sdp) == 0 || (buffer[12] & 1) == 0)
+	if (scsi_device_protection(sdp) == 0 || (buffer[12] & 1) == 0) {
+		sdkp->protection_type = 0;
 		return ret;
+	}
 
 	type = ((buffer[12] >> 1) & 7) + 1; /* P_TYPE 0 = Type 1 */