Skip to contentSkip to conversation

drm/amdgpu: remove the alignment placeholder for secure buffer

PATCH In review Huang Rui 3 participants 3 messages Jan 17, 2020

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 drm/amdgpu: remove the alignment placeholder for secure buffer

The alignment should match the page size for secure buffer, so we didn't configure it anymore.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +0 -4
index f39012e..41d49a0 100644
@@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
 		resv = vm->root.base.bo->tbo.base.resv;
 	}
 
-	if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
-		/* XXX: pad out alignment to meet TMZ requirements */
-	}
-
 	r = amdgpu_gem_object_create(adev, size, args->in.alignment,
 				     (u32)(0xffffffff & args->in.domains),
 				     flags, ttm_bo_type_device, resv, &gobj);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw

BR,
Aaron Liu

Quoted 38 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Huang Rui
Sent: Friday, January 17, 2020 3:48 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Huang, Ray <[email protected]>; Koenig, Christian <[email protected]>
Subject: [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer

The alignment should match the page size for secure buffer, so we didn't configure it anymore.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +0 -4
index f39012e..41d49a0 100644
@@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device
 *dev, void *data,
 		resv = vm->root.base.bo->tbo.base.resv;
 	}
 
-	if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
-		/* XXX: pad out alignment to meet TMZ requirements */
-	}
-
 	r = amdgpu_gem_object_create(adev, size, args->in.alignment,
 				     (u32)(0xffffffff & args->in.domains),

flags, ttm_bo_type_device, resv, &gobj);
--
2.7.4

Quoted 9 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=02%7C01%7Caaron.liu%40amd.com%7Cfe128e2299c943be48 9d08d79b21a418%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6 37148441147752302&amp;sdata=HRtRCe7OUhBK4ScG%2BplLUJiK%2Bn8wU1 BXxb28r5t2bWk%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Huang Rui

Am 17.01.20 um 08:48 schrieb Huang Rui:

Quoted 4 lines

The alignment should match the page size for secure buffer, so we didn't configure it anymore.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
  1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +0 -0
index f39012e..41d49a0 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data, · line 266

Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +0 -4
@@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
  		resv = vm->root.base.bo->tbo.base.resv;
  	}
 
-	if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
-		/* XXX: pad out alignment to meet TMZ requirements */
-	}
-
  	r = amdgpu_gem_object_create(adev, size, args->in.alignment,
  				     (u32)(0xffffffff & args->in.domains),
  				     flags, ttm_bo_type_device, resv, &gobj);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx