scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
PATCH 1/1 scsi: ufs: Enable HOST_PA_TACTIVATE quirk for WDC UFS devices
Western Digital UFS devices require host PA_TACTIVATE to be lower than device PA_TACTIVATE, otherwise it may get stuck during hibern8 sequence.
drivers/scsi/ufs/ufs_quirks.h +1 -0
@@ -15,6 +15,7 @@#define UFS_VENDOR_TOSHIBA 0x198#define UFS_VENDOR_SAMSUNG 0x1CE#define UFS_VENDOR_SKHYNIX 0x1AD +#define UFS_VENDOR_WDC 0x145/** * ufs_dev_fix - ufs device quirk info
drivers/scsi/ufs/ufshcd.c +2 -0
@@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),UFS_FIX (UFS_VENDOR_SKHYNIX ,"hB8aL1" /*H28U62301AMR*/ ,UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME ), +UFS_FIX (UFS_VENDOR_WDC ,UFS_ANY_MODEL , +UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE ), END_FIX };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Hi,
Quoted 5 lines
Western Digital UFS devices require host
PA_TACTIVATEto be lower than devicePA_TACTIVATE, otherwise it may get stuck during hibern8 sequence.Signed-off-by Can Guo <[email protected]>
Please allow few more days to consult internally about this. Thanks,
Avri
Hi,
drivers/scsi/ufs/ufshcd.c struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { · line 243
Quoted 13 lines
/**
*ufs_dev_fix- ufs device quirk infodrivers/scsi/ufs/ufshcd.c +2
-0@@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),UFS_FIX (UFS_VENDOR_SKHYNIX ,"hB8aL1" /*H28U62301AMR*/ ,UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME ), +UFS_FIX (UFS_VENDOR_WDC ,UFS_ANY_MODEL , + UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),
We are objecting to apply this quirk categorically for all SOC vendors. Please use a vendor-specific quirk for that.
Thanks,
Avri
Quoted 18 lines · Avri Altman
Hi,
drivers/scsi/ufs/ufshcd.c struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { · line 243
Quoted 13 lines
/**
*ufs_dev_fix- ufs device quirk infodrivers/scsi/ufs/ufshcd.c +2
-0@@ -239,6 +239,8 @@ struct ufs_pm_lvl_states ufs_pm_lvl_states[] = { UFS_DEVICE_QUIRK_HOST_PA_SAVECONFIGTIME),UFS_FIX (UFS_VENDOR_SKHYNIX ,"hB8aL1" /*H28U62301AMR*/ ,UFS_DEVICE_QUIRK_HOST_VS_DEBUGSAVECONFIGTIME ), +UFS_FIX (UFS_VENDOR_WDC ,UFS_ANY_MODEL , + UFS_DEVICE_QUIRK_HOST_PA_TACTIVATE),We are objecting to apply this quirk categorically for all SOC vendors. Please use a vendor-specific quirk for that.
Quoted 2 lines
Thanks,
Avri
Yeah, as we discussed, I will apply it in ufshcd_vops_apply_dev_quirks() in next version and this is agreed by Stanley as well.