Skip to contentSkip to conversation

mmc: cqhci: Update cqhci memory ioresource name

PATCH Superseded Veerabhadrarao Badiganti 5 participants 8 messages Mar 4, 2020 – Mar 11, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: cqhci: Update cqhci memory ioresource name

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
Signature · 1 line
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 2 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(), right? So no one else could be using "cqhci_mem"? Some more explanation is needed here.

Quoted 23 lines

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
#2 lore raw
Quoted 6 lines · Adrian Hunter
Quoted 2 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(), right? So no one else could be using "cqhci_mem"? Some more explanation is needed here.

Right, only qcom cqhci solution is making use of it.

I did a grep in dt and find no other vendor is using it.

Sure. Will update commit text.

Quoted 22 lines
Quoted 22 lines

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

---
  drivers/mmc/host/cqhci.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
  	/* check and setup CMDQ interface */
  	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
  	if (!cqhci_memres) {
  		dev_dbg(&pdev->dev, "CMDQ not supported\n");
  		return ERR_PTR(-EINVAL);
#3 lore raw

PATCH v2 1/1 mmc: cqhci: Update cqhci memory ioresource name

In reply to Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality.

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes sicne V1:
- Updated commit text expalining this change affects *only* qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
Signature · 1 line
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
maintainer Acked-by on v2 1/1
#4 lore raw
Quoted 8 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality.

Quoted 26 lines

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes sicne V1:
- Updated commit text expalining this change affects *only* qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
Reviewed-by Douglas Anderson on v2 1/1
#5 lore raw
In reply to Veerabhadrarao Badiganti

Hi,

Quoted 13 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality.

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Quoted 7 lines

Changes sicne V1:
- Updated commit text expalining this change affects *only* qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

...now I guess the last thing is the dts change...

Acked-by on v2 1/1
#6 lore raw
In reply to Veerabhadrarao Badiganti
Quoted 8 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality.

I do favor using names without the "_mem" suffix and it seems like the existing code only acquire the first two regions by index. So this should be fine.

But I do expect to see some patches fixing up the 8 dts files that now has invalid reg-names.

Regards,
Bjorn

Quoted 27 lines

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes sicne V1:
- Updated commit text expalining this change affects *only* qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -1
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
 	/* check and setup CMDQ interface */
 	cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-						   "cqhci_mem");
+						   "cqhci");
 	if (!cqhci_memres) {
 		dev_dbg(&pdev->dev, "CMDQ not supported\n");
 		return ERR_PTR(-EINVAL);
Signature · 1 line
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
#7 lore raw
In reply to Veerabhadrarao Badiganti
Quoted 9 lines · Veerabhadrarao Badiganti

Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality.

Applied for next, thanks!

Kind regards
Uffe

Quoted 27 lines

---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes sicne V1:
- Updated commit text expalining this change affects *only* qcom cqhci functionality.

---
 drivers/mmc/host/cqhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/cqhci.c +1 -2
index e2ea2c4..e24b8ff 100644
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
 
        /* check and setup CMDQ interface */
        cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
-                                                  "cqhci_mem");
+                                                  "cqhci");
        if (!cqhci_memres) {
                dev_dbg(&pdev->dev, "CMDQ not supported\n");
                return ERR_PTR(-EINVAL);
--

Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project