Skip to contentSkip to conversation

mm: add "+" in show_free_areas()

PATCH In review hui yang 2 participants 2 messages Mar 12, 2020

Subsystems (2)
lore
Share & tools
lore

hui yang

author
#0 lore raw

PATCH 20/20 mm: add "+" in show_free_areas()

From: YangHui <[email protected]>

if there has not "+" , it will show below:
DMA: 305*4kB (UMCH).....5*2048kB (C) 13*4096kB (C) = 67196kB actually it's an addition expression
so we should add "+"

---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
index 3c4eb75..d90b3d7 100644
@@ -5399,7 +5399,7 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
 		}
 		spin_unlock_irqrestore(&zone->lock, flags);
 		for (order = 0; order < MAX_ORDER; order++) {
-			printk(KERN_CONT "%lu*%lukB ",
+			printk(KERN_CONT "+%lu*%lukB ",
 			       nr[order], K(1UL) << order);
 			if (nr[order])
 				show_migration_types(types[order]);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 8 lines · hui yang

From: YangHui <[email protected]>

if there has not "+" , it will show below:
DMA: 305*4kB (UMCH).....5*2048kB (C) 13*4096kB (C) = 67196kB actually it's an addition expression
so we should add "+"

Yeah but I think it's quite clear even without the '+' which would just make the output longer harder to read, IMHO.

Quoted 18 lines
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
index 3c4eb75..d90b3d7 100644
@@ -5399,7 +5399,7 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
 		}
 		spin_unlock_irqrestore(&zone->lock, flags);
 		for (order = 0; order < MAX_ORDER; order++) {
-			printk(KERN_CONT "%lu*%lukB ",
+			printk(KERN_CONT "+%lu*%lukB ",
 			       nr[order], K(1UL) << order);
 			if (nr[order])
 				show_migration_types(types[order]);