Skip to contentSkip to conversation

drm/amdgpu/sriov : Don't resume RLCG for SRIOV guest

PATCH In review shaoyunl 3 participants 4 messages Mar 17, 2020 – Mar 19, 2020

Subsystems (2)
lore
Share & tools
lore

shaoyunl

author
#0 lore raw

PATCH 1/1 drm/amdgpu/sriov : Don't resume RLCG for SRIOV guest

RLCG is enabled by host driver, no need to enable it in guest for none-PSP load path

Change-Id I2f313743bf3d492f06aaef07224da6eda3878a28
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +5 -0
index d1cdcb4..e134bb2 100644
@@ -1940,6 +1940,11 @@ static int gfx_v10_0_rlc_resume(struct amdgpu_device *adev)
 		if (!amdgpu_sriov_vf(adev)) /* enable RLC SRM */
 			gfx_v10_0_rlc_enable_srm(adev);
 	} else {
+		if (amdgpu_sriov_vf(adev)) {
+			gfx_v10_0_init_csb(adev);
+			return 0;
+		}
+
 		adev->gfx.rlc.funcs->stop(adev);
 
 		/* disable CG */
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

ping

-----Original Message-----
From: Liu, Shaoyun <[email protected]>
Sent: Tuesday, March 17, 2020 12:55 PM
To: [email protected]
Cc: Liu, Shaoyun <[email protected]>
Subject: [PATCH] drm/amdgpu/sriov : Don't resume RLCG for SRIOV guest

RLCG is enabled by host driver, no need to enable it in guest for none-PSP load path

Change-Id I2f313743bf3d492f06aaef07224da6eda3878a28
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +5 -0
index d1cdcb4..e134bb2 100644
@@ -1940,6 +1940,11 @@ static int gfx_v10_0_rlc_resume(struct amdgpu_device *adev)
 		if (!amdgpu_sriov_vf(adev)) /* enable RLC SRM */
 			gfx_v10_0_rlc_enable_srm(adev);
 	} else {
+		if (amdgpu_sriov_vf(adev)) {
+			gfx_v10_0_init_csb(adev);
+			return 0;
+		}
+
 		adev->gfx.rlc.funcs->stop(adev);
 
 		/* disable CG */
Signature · 5 lines
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by
#2 lore raw

[AMD Official Use Only - Internal Distribution Only]

Regards,
Hawking
-----Original Message-----
From: Liu, Shaoyun <[email protected]>
Sent: Thursday, March 19, 2020 05:30
To: [email protected]; Zhang, Hawking <[email protected]>
Subject: RE: [PATCH] drm/amdgpu/sriov : Don't resume RLCG for SRIOV guest

[AMD Official Use Only - Internal Distribution Only]

ping

-----Original Message-----
From: Liu, Shaoyun <[email protected]>
Sent: Tuesday, March 17, 2020 12:55 PM
To: [email protected]
Cc: Liu, Shaoyun <[email protected]>
Subject: [PATCH] drm/amdgpu/sriov : Don't resume RLCG for SRIOV guest

RLCG is enabled by host driver, no need to enable it in guest for none-PSP load path

Change-Id I2f313743bf3d492f06aaef07224da6eda3878a28
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +5 -0
index d1cdcb4..e134bb2 100644
@@ -1940,6 +1940,11 @@ static int gfx_v10_0_rlc_resume(struct amdgpu_device *adev)
 		if (!amdgpu_sriov_vf(adev)) /* enable RLC SRM */
 			gfx_v10_0_rlc_enable_srm(adev);
 	} else {
+		if (amdgpu_sriov_vf(adev)) {
+			gfx_v10_0_init_csb(adev);
+			return 0;
+		}
+
 		adev->gfx.rlc.funcs->stop(adev);
 
 		/* disable CG */
Signature · 5 lines
2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Acked-by on v1 1/1
#3 lore raw
In reply to shaoyunl
Quoted 5 lines · shaoyunl

RLCG is enabled by host driver, no need to enable it in guest for none-PSP load path

Change-Id I2f313743bf3d492f06aaef07224da6eda3878a28
Quoted 23 lines
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +5 -1
index d1cdcb4..e134bb2 100644
@@ -1940,6 +1940,11 @@ static int gfx_v10_0_rlc_resume(struct amdgpu_device *adev)
                if (!amdgpu_sriov_vf(adev)) /* enable RLC SRM */
                        gfx_v10_0_rlc_enable_srm(adev);
        } else {
+               if (amdgpu_sriov_vf(adev)) {
+                       gfx_v10_0_init_csb(adev);
+                       return 0;
+               }
+
                adev->gfx.rlc.funcs->stop(adev);
 
                /* disable CG */
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx