Skip to contentSkip to conversation

ADD interconnect support for Qualcomm DWC3 driver

PATCH Superseded Sandeep Maheswaram 9 participants 37 messages Apr 1, 2020 – Jul 7, 2020

Subsystems (6)

v7 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#32 lore raw

PATCH v7 4/4 arm64: dts: qcom: sc7180: Add interconnect properties for USB

In reply to Sandeep Maheswaram

Populate USB DT nodes with interconnect properties.

---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7180.dtsi +4 -0
index 998f101..bd0d3a7 100644
@@ -1447,6 +1447,10 @@
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre2_noc MASTER_USB3 &mc_virt SLAVE_EBI1>,
+					<&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_USB3>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			usb_1_dwc3: dwc3@a600000 {
 				compatible = "snps,dwc3";
 				reg = <0 0x0a600000 0 0xe000>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#0 lore raw

v7 cover ADD interconnect support for Qualcomm DWC3 driver

This path series aims to add interconnect support in dwc3-qcom driver on SDM845 and SC7180 SoCs.

Changes from v6 -> v7

Quoted 2 lines

[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. Other patches remain unchanged.

Changes from v5 -> v6

Quoted 4 lines

[PATCH 1/4] Addressed comments from Rob.
[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/4] Ignoring 80 char limit in defining interconnect paths. Added [PATCH 4/4] in this series. Adding interconnect nodes for SC7180.

    Depends on patch https://patchwork.kernel.org/patch/11417989/.	

Changes from v4 -> v5

Quoted 1 line

[PATCH 1/3] Added the interconnect properties in yaml. This patch depends

    on series https://patchwork.kernel.org/cover/11372641/.
Quoted 2 lines

[PATCH 2/3] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/3] Modified as per the new interconnect nodes in sdm845. Depends

    on series https://patchwork.kernel.org/cover/11372211/. 

Changes from v3 -> v4

Quoted 2 lines

Fixed review comments from Matthias
[PATCH 1/3] and [PATCH 3/3] remains unchanged

Changes from v2 -> v3

Quoted 2 lines

Fixed review comments from Matthias and Manu changed the functions prefix from usb_* to dwc3_qcom_*

Changes since V1:

Quoted 2 lines

Comments by Georgi Djakov on "[PATCH 2/3]" addressed [PATCH 1/3] and [PATCH 3/3] remains unchanged

Sandeep Maheswaram (4):
dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for
Qualcomm DWC3 driver
usb: dwc3: qcom: Add interconnect support in dwc3 driver
arm64: dts: qcom: sdm845: Add interconnect properties for USB
arm64: dts: qcom: sc7180: Add interconnect properties for USB

 .../devicetree/bindings/usb/qcom,dwc3.yaml         |   8 ++
 arch/arm64/boot/dts/qcom/sc7180.dtsi               |   4 +
 arch/arm64/boot/dts/qcom/sdm845.dtsi               |   8 ++
 drivers/usb/dwc3/dwc3-qcom.c                       | 128 ++++++++++++++++++++-
 4 files changed, 146 insertions(+), 2 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#1 lore raw

PATCH v7 1/4 dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver

Add documentation for the interconnects and interconnect-names properties for USB.

---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +8 -0
index 17e22ff..ec1ec47 100644
@@ -70,6 +70,14 @@ properties:
   resets:
     maxItems: 1
 
+  interconnects:
+    maxItems: 2
+
+  interconnect-names:
+    items:
+      - const: usb-ddr
+      - const: apps-usb
+
   interrupts:
     items:
       - description: The interrupt that is asserted
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#4 lore raw

PATCH v7 2/4 usb: dwc3: qcom: Add interconnect support in dwc3 driver

In reply to Sandeep Maheswaram

Add interconnect support in dwc3-qcom driver to vote for bus bandwidth.

This requires for two different paths - from USB master to DDR slave. The other is from APPS master to USB slave.

---
 drivers/usb/dwc3/dwc3-qcom.c | 128 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 126 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-qcom.c +126 -2
index 1dfd024..d33ae86 100644
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/extcon.h>
+#include <linux/interconnect.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/phy/phy.h>
@@ -43,6 +44,14 @@
 #define SDM845_QSCRATCH_SIZE			0x400
 #define SDM845_DWC3_CORE_SIZE			0xcd00
 
+/* Interconnect path bandwidths in MBps */
+#define USB_MEMORY_AVG_HS_BW MBps_to_icc(240)
+#define USB_MEMORY_PEAK_HS_BW MBps_to_icc(700)
+#define USB_MEMORY_AVG_SS_BW  MBps_to_icc(1000)
+#define USB_MEMORY_PEAK_SS_BW MBps_to_icc(2500)
+#define APPS_USB_AVG_BW 0
+#define APPS_USB_PEAK_BW MBps_to_icc(40)
+
 struct dwc3_acpi_pdata {
 	u32			qscratch_base_offset;
 	u32			qscratch_base_size;
@@ -76,8 +85,13 @@ struct dwc3_qcom {
 	enum usb_dr_mode	mode;
 	bool			is_suspended;
 	bool			pm_suspended;
+	struct icc_path		*usb_ddr_icc_path;
+	struct icc_path		*apps_usb_icc_path;
 };
 
+static int dwc3_qcom_interconnect_enable(struct dwc3_qcom *qcom);
+static int dwc3_qcom_interconnect_disable(struct dwc3_qcom *qcom);
+
 static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val)
 {
 	u32 reg;
@@ -239,7 +253,7 @@ static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom)
 static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
 {
 	u32 val;
-	int i;
+	int i, ret;
 
 	if (qcom->is_suspended)
 		return 0;
@@ -251,6 +265,10 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
 	for (i = qcom->num_clocks - 1; i >= 0; i--)
 		clk_disable_unprepare(qcom->clks[i]);
 
+	ret = dwc3_qcom_interconnect_disable(qcom);
+	if (ret)
+		dev_warn(qcom->dev, "failed to disable interconnect %d\n", ret);
+
 	qcom->is_suspended = true;
 	dwc3_qcom_enable_interrupts(qcom);
 
@@ -276,6 +294,10 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
 		}
 	}
 
+	ret = dwc3_qcom_interconnect_enable(qcom);
+	if (ret)
+		dev_warn(qcom->dev, "failed to enable interconnect %d\n", ret);
+
 	/* Clear existing events from PHY related to L2 in/out */
 	dwc3_qcom_setbits(qcom->qscratch_base, PWR_EVNT_IRQ_STAT_REG,
 			  PWR_EVNT_LPM_IN_L2_MASK | PWR_EVNT_LPM_OUT_L2_MASK);
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
 	return 0;
 }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles
+ * @qcom:			Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;
+
+	qcom->usb_ddr_icc_path = of_icc_get(dev, "usb-ddr");
+	if (IS_ERR(qcom->usb_ddr_icc_path)) {
+		dev_err(dev, "Error: (%ld) failed getting usb-ddr path\n",
+			PTR_ERR(qcom->usb_ddr_icc_path));
+		return PTR_ERR(qcom->usb_ddr_icc_path);
+	}
+
+	qcom->apps_usb_icc_path = of_icc_get(dev, "apps-usb");
+	if (IS_ERR(qcom->apps_usb_icc_path)) {
+		dev_err(dev, "Error: (%ld) failed getting apps-usb path\n",
+				PTR_ERR(qcom->apps_usb_icc_path));
+		return PTR_ERR(qcom->apps_usb_icc_path);
+	}
+
+	ret = dwc3_qcom_interconnect_enable(qcom);
+	if (ret) {
+		dev_err(dev, "failed to enable interconnect %d\n", ret);
+		return ret;
+	}
+
+	return 0;
+}
+
+/**
+ * dwc3_qcom_interconnect_exit() - Release interconnect path handles
+ * @qcom:			Pointer to the concerned usb core.
+ *
+ * This function is used to release interconnect path handle.
+ */
+static void dwc3_qcom_interconnect_exit(struct dwc3_qcom *qcom)
+{
+	icc_put(qcom->usb_ddr_icc_path);
+	icc_put(qcom->apps_usb_icc_path);
+}
+
+/* Currently we only use bandwidth level, so just "enable" interconnects */
+static int dwc3_qcom_interconnect_enable(struct dwc3_qcom *qcom)
+{
+	struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
+	int ret;
+
+	if (dwc->maximum_speed == USB_SPEED_SUPER)
+		ret = icc_set_bw(qcom->usb_ddr_icc_path,
+			USB_MEMORY_AVG_SS_BW, USB_MEMORY_PEAK_SS_BW);
+	else
+		ret = icc_set_bw(qcom->usb_ddr_icc_path,
+			USB_MEMORY_AVG_HS_BW, USB_MEMORY_PEAK_HS_BW);
+
+	if (ret)
+		return ret;
+
+	ret = icc_set_bw(qcom->apps_usb_icc_path,
+		APPS_USB_AVG_BW, APPS_USB_PEAK_BW);
+	if (ret)
+		icc_set_bw(qcom->usb_ddr_icc_path, 0, 0);
+
+	return ret;
+}
+
+/* To disable an interconnect, we just set its bandwidth to 0 */
+static int dwc3_qcom_interconnect_disable(struct dwc3_qcom *qcom)
+{
+	int ret;
+
+	ret = icc_set_bw(qcom->usb_ddr_icc_path, 0, 0);
+	if (ret)
+		return ret;
+
+	ret = icc_set_bw(qcom->apps_usb_icc_path, 0, 0);
+	if (ret)
+		goto err_reenable_memory_path;
+
+	return 0;
+
+	/* Re-enable things in the event of an error */
+err_reenable_memory_path:
+	dwc3_qcom_interconnect_enable(qcom);
+
+	return ret;
+}
+
 static irqreturn_t qcom_dwc3_resume_irq(int irq, void *data)
 {
 	struct dwc3_qcom *qcom = data;
@@ -648,6 +765,10 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
 		goto depopulate;
 	}
 
+	ret = dwc3_qcom_interconnect_init(qcom);
+	if (ret)
+		goto depopulate;
+
 	qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);
 
 	/* enable vbus override for device mode */
@@ -657,7 +778,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
 	/* register extcon to override sw_vbus on Vbus change later */
 	ret = dwc3_qcom_register_extcon(qcom);
 	if (ret)
-		goto depopulate;
+		goto interconnect_exit;
 
 	device_init_wakeup(&pdev->dev, 1);
 	qcom->is_suspended = false;
@@ -667,6 +788,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
 
 	return 0;
 
+interconnect_exit:
+	dwc3_qcom_interconnect_exit(qcom);
 depopulate:
 	if (np)
 		of_platform_depopulate(&pdev->dev);
@@ -697,6 +820,7 @@ static int dwc3_qcom_remove(struct platform_device *pdev)
 	}
 	qcom->num_clocks = 0;
 
+	dwc3_qcom_interconnect_exit(qcom);
 	reset_control_assert(qcom->resets);
 
 	pm_runtime_allow(dev);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#30 lore raw

PATCH v7 3/4 arm64: dts: qcom: sdm845: Add interconnect properties for USB

In reply to Sandeep Maheswaram

Populate USB DT nodes with interconnect properties.

---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +8 -0
index 8f926b5..860d5c2 100644
@@ -3097,6 +3097,10 @@
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre2_noc MASTER_USB3_0 &mem_noc SLAVE_EBI1>,
+					<&gladiator_noc MASTER_APPSS_PROC &config_noc SLAVE_USB3_0>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			usb_1_dwc3: dwc3@a600000 {
 				compatible = "snps,dwc3";
 				reg = <0 0x0a600000 0 0xcd00>;
@@ -3141,6 +3145,10 @@
 
 			resets = <&gcc GCC_USB30_SEC_BCR>;
 
+			interconnects = <&aggre2_noc MASTER_USB3_1 &mem_noc SLAVE_EBI1>,
+					<&gladiator_noc MASTER_APPSS_PROC &config_noc SLAVE_USB3_1>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			usb_2_dwc3: dwc3@a800000 {
 				compatible = "snps,dwc3";
 				reg = <0 0x0a800000 0 0xcd00>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
maintainer Reviewed-by on v7 1/4
#2 lore raw

Re: [PATCH v7 1/4] dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for Qualcomm DWC3 driver

In reply to Sandeep Maheswaram
Quoted 8 lines · Sandeep Maheswaram

Add documentation for the interconnects and interconnect-names properties for USB.

---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)
#34 lore raw
In reply to Sandeep Maheswaram

Hi Felipe,

all patches of this series have been reviewed and there are no outstanding comments, so I guess it should be ready to land?

Thanks

Matthias

Quoted 52 lines · Sandeep Maheswaram

This path series aims to add interconnect support in dwc3-qcom driver on SDM845 and SC7180 SoCs.

Changes from v6 -> v7

Quoted 2 lines

[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. Other patches remain unchanged.

Changes from v5 -> v6

Quoted 4 lines

[PATCH 1/4] Addressed comments from Rob.
[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/4] Ignoring 80 char limit in defining interconnect paths. Added [PATCH 4/4] in this series. Adding interconnect nodes for SC7180.

    Depends on patch https://patchwork.kernel.org/patch/11417989/.	

Changes from v4 -> v5

Quoted 1 line

[PATCH 1/3] Added the interconnect properties in yaml. This patch depends

    on series https://patchwork.kernel.org/cover/11372641/.
Quoted 2 lines

[PATCH 2/3] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/3] Modified as per the new interconnect nodes in sdm845. Depends

    on series https://patchwork.kernel.org/cover/11372211/. 

Changes from v3 -> v4

Quoted 2 lines

Fixed review comments from Matthias
[PATCH 1/3] and [PATCH 3/3] remains unchanged

Changes from v2 -> v3

Quoted 2 lines

Fixed review comments from Matthias and Manu changed the functions prefix from usb_* to dwc3_qcom_*

Changes since V1:

Quoted 2 lines

Comments by Georgi Djakov on "[PATCH 2/3]" addressed [PATCH 1/3] and [PATCH 3/3] remains unchanged

Sandeep Maheswaram (4):
dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for
Qualcomm DWC3 driver
usb: dwc3: qcom: Add interconnect support in dwc3 driver
arm64: dts: qcom: sdm845: Add interconnect properties for USB
arm64: dts: qcom: sc7180: Add interconnect properties for USB

 .../devicetree/bindings/usb/qcom,dwc3.yaml         |   8 ++
 arch/arm64/boot/dts/qcom/sc7180.dtsi               |   4 +
 arch/arm64/boot/dts/qcom/sdm845.dtsi               |   8 ++
 drivers/usb/dwc3/dwc3-qcom.c                       | 128 ++++++++++++++++++++-
 4 files changed, 146 insertions(+), 2 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#35 lore raw

Hi Felipe,

Any update about landing this series.

Regards

Sandeep

Quoted 62 lines · Matthias Kaehlcke

Hi Felipe,

all patches of this series have been reviewed and there are no outstanding comments, so I guess it should be ready to land?

Thanks

Matthias

Quoted 52 lines · Sandeep Maheswaram

This path series aims to add interconnect support in dwc3-qcom driver on SDM845 and SC7180 SoCs.

Changes from v6 -> v7

Quoted 2 lines

[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. Other patches remain unchanged.

Changes from v5 -> v6

Quoted 4 lines

[PATCH 1/4] Addressed comments from Rob.
[PATCH 2/4] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/4] Ignoring 80 char limit in defining interconnect paths. Added [PATCH 4/4] in this series. Adding interconnect nodes for SC7180.

     Depends on patch https://patchwork.kernel.org/patch/11417989/.	

Changes from v4 -> v5

Quoted 1 line

[PATCH 1/3] Added the interconnect properties in yaml. This patch depends

     on series https://patchwork.kernel.org/cover/11372641/.
Quoted 2 lines

[PATCH 2/3] Fixed review comments from Matthias in DWC3 driver. [PATCH 3/3] Modified as per the new interconnect nodes in sdm845. Depends

     on series https://patchwork.kernel.org/cover/11372211/.

Changes from v3 -> v4

Quoted 2 lines

Fixed review comments from Matthias
[PATCH 1/3] and [PATCH 3/3] remains unchanged

Changes from v2 -> v3

Quoted 2 lines

Fixed review comments from Matthias and Manu changed the functions prefix from usb_* to dwc3_qcom_*

Changes since V1:

Quoted 2 lines

Comments by Georgi Djakov on "[PATCH 2/3]" addressed [PATCH 1/3] and [PATCH 3/3] remains unchanged

Sandeep Maheswaram (4):
dt-bindings: usb: qcom,dwc3: Introduce interconnect properties for
Qualcomm DWC3 driver
usb: dwc3: qcom: Add interconnect support in dwc3 driver
arm64: dts: qcom: sdm845: Add interconnect properties for USB
arm64: dts: qcom: sc7180: Add interconnect properties for USB

  .../devicetree/bindings/usb/qcom,dwc3.yaml         |   8 ++
  arch/arm64/boot/dts/qcom/sc7180.dtsi               |   4 +
  arch/arm64/boot/dts/qcom/sdm845.dtsi               |   8 ++
  drivers/usb/dwc3/dwc3-qcom.c                       | 128 ++++++++++++++++++++-
  4 files changed, 146 insertions(+), 2 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#36 lore raw
Quoted 3 lines · Sandeep Maheswaram (Temp)

Hi Felipe,

Any update about landing this series.

in my tree now

Signature · 1 line
balbi
#5 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

In reply to Sandeep Maheswaram

Hi,

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 7 lines · Sandeep Maheswaram
drivers/usb/dwc3/dwc3-qcom.c +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Signature · 1 line
balbi
#6 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 13 lines · Felipe Balbi

Hi,

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 7 lines · Sandeep Maheswaram
drivers/usb/dwc3/dwc3-qcom.c +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Sorry, I meant this patch ;-)

Signature · 1 line
balbi
#7 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 16 lines · Felipe Balbi
Quoted 13 lines · Felipe Balbi

Hi,

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 7 lines · Sandeep Maheswaram
drivers/usb/dwc3/dwc3-qcom.c +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

Let's hold back with this patch/series then until that is sorted out.

#8 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 17 lines · Matthias Kaehlcke
Quoted 16 lines · Felipe Balbi
Quoted 13 lines · Felipe Balbi

Hi,

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT
 	depends on (OF || ACPI)
 	default USB_DWC3
 	help
#9 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 10 lines · Georgi Djakov

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
        tristate "Qualcomm Platform"
        depends on ARCH_QCOM || COMPILE_TEST
        depends on EXTCON || !EXTCON
+       depends on INTERCONNECT || !INTERCONNECT

Again, as I said yesterday. This looks incorrect and may not fix the problem..

With this we will be able to select USB_DWC3_QCOM even when INTERCONNECT=m.

What we perhaps need here is:
depends on INTERCONNECT != m

--
viresh

#10 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi,

Quoted 14 lines · Viresh Kumar

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 10 lines · Georgi Djakov

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
        tristate "Qualcomm Platform"
        depends on ARCH_QCOM || COMPILE_TEST
        depends on EXTCON || !EXTCON
+       depends on INTERCONNECT || !INTERCONNECT

Again, as I said yesterday. This looks incorrect and may not fix the problem..

Quoted 1 line

With this we will be able to select USB_DWC3_QCOM even when INTERCONNECT=m.

DWC3_QCOM in that case would be 'm' if INTERCONNECT =m and that should be fine?

Quoted 5 lines

What we perhaps need here is:
depends on INTERCONNECT != m

--
viresh

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#11 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 17 lines · Manu Gautam

Hi,

Quoted 14 lines · Viresh Kumar

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 10 lines · Georgi Djakov

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
        tristate "Qualcomm Platform"
        depends on ARCH_QCOM || COMPILE_TEST
        depends on EXTCON || !EXTCON
+       depends on INTERCONNECT || !INTERCONNECT

Again, as I said yesterday. This looks incorrect and may not fix the problem..

Quoted 4 lines
Quoted 1 line

With this we will be able to select USB_DWC3_QCOM even when INTERCONNECT=m.

DWC3_QCOM in that case would be 'm' if INTERCONNECT =m and that should be fine?

Ahh, I was speaking in context of PM_OPP where it is a bool. Perhaps this works just fine with DWC3_QCOM, sorry for the confusion.

Signature · 1 line
viresh
#12 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

In reply to Georgi Djakov

Hi,

Quoted 43 lines · Georgi Djakov
Quoted 17 lines · Matthias Kaehlcke
Quoted 16 lines · Felipe Balbi
Quoted 13 lines · Felipe Balbi

Hi,

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

---8<---

drivers/usb/dwc3/Kconfig +0 -0
index 206caa0ea1c6..6661788b1a76 100644

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 4 lines
drivers/usb/dwc3/Kconfig +1 -0
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Signature · 1 line
balbi
#13 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi,

Quoted 41 lines · Felipe Balbi

Hi,

Quoted 37 lines · Georgi Djakov
Quoted 17 lines · Matthias Kaehlcke
Quoted 16 lines · Felipe Balbi
Quoted 13 lines · Felipe Balbi

Hi,

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

Quoted 12 lines

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 10 lines

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Agree, but just to clarify, that these are two separate issues that need to be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined with INTERCONNECT=m is the second one.

Thanks,
Georgi

#14 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi,

Quoted 44 lines · Georgi Djakov
Quoted 31 lines
Quoted 31 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

Quoted 12 lines

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 10 lines

---8<---

drivers/usb/dwc3/Kconfig +1 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Quoted 3 lines

Agree, but just to clarify, that these are two separate issues that need to be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined with INTERCONNECT=m is the second one.

If INTERCONNECT=m, QCOM3 shouldn't be y. I think the following is enough:

	depends on INTERCONNECT=y || INTERCONNECT=USB_DWC3_QCOM
Signature · 1 line
balbi
#15 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 48 lines · Felipe Balbi

Hi,

Quoted 44 lines · Georgi Djakov
Quoted 43 lines
Quoted 37 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

---8<---

drivers/usb/dwc3/Kconfig +0 -0
index 206caa0ea1c6..6661788b1a76 100644

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 4 lines
drivers/usb/dwc3/Kconfig +1 -0
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
 	tristate "Qualcomm Platform"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Quoted 9 lines
Quoted 3 lines

Agree, but just to clarify, that these are two separate issues that need to be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined with INTERCONNECT=m is the second one.

If INTERCONNECT=m, QCOM3 shouldn't be y. I think the following is enough:

	depends on INTERCONNECT=y || INTERCONNECT=USB_DWC3_QCOM

This misses the case where INTERCONNECT=n and USB_DWC3_QCOM=[ym] which I don't see a reason for breaking.

But if only INTERCONNECT where a bool, then we don't need to specify a depends on, because it will either be there, or the stubs will. We've come to this conclusion in a lot of different frameworks and I don't see why we should do this differently with INTERCONNECT.

Regards,
Bjorn

#16 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 7 lines · Bjorn Andersson

This misses the case where INTERCONNECT=n and USB_DWC3_QCOM=[ym] which I don't see a reason for breaking.

But if only INTERCONNECT where a bool, then we don't need to specify a depends on, because it will either be there, or the stubs will. We've come to this conclusion in a lot of different frameworks and I don't see why we should do this differently with INTERCONNECT.

INTERCONNECT is a bool now and the patch has been pushed to linux-next already.

Signature · 1 line
viresh
#17 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

In reply to Bjorn Andersson

Hi Felipe,

Please let me know how to go forward with this patch

Regards

Sandeep

Quoted 60 lines · Bjorn Andersson
Quoted 40 lines · Felipe Balbi

Hi,

Quoted 37 lines · Georgi Djakov
Quoted 37 lines
Quoted 32 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+	struct device *dev = qcom->dev;
+	int ret;
+
+	if (!device_is_bound(&qcom->dwc3->dev))
+		return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for this merge window.

Quoted 2 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 4 lines

discussion about this with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT from tristate to bool, which seems sensible to me given that interconnect is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

---8<---

drivers/usb/dwc3/Kconfig +0 -0
index 206caa0ea1c6..6661788b1a76 100644

drivers/usb/dwc3/Kconfig config USB_DWC3_QCOM · line 132

Quoted 4 lines
drivers/usb/dwc3/Kconfig +1 -0
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM
  	tristate "Qualcomm Platform"
  	depends on ARCH_QCOM || COMPILE_TEST
  	depends on EXTCON || !EXTCON
+	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Quoted 8 lines
Quoted 3 lines

Agree, but just to clarify, that these are two separate issues that need to be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined with INTERCONNECT=m is the second one.

If INTERCONNECT=m, QCOM3 shouldn't be y. I think the following is enough:

	depends on INTERCONNECT=y || INTERCONNECT=USB_DWC3_QCOM

This misses the case where INTERCONNECT=n and USB_DWC3_QCOM=[ym] which I don't see a reason for breaking.

But if only INTERCONNECT where a bool, then we don't need to specify a depends on, because it will either be there, or the stubs will. We've come to this conclusion in a lot of different frameworks and I don't see why we should do this differently with INTERCONNECT.

Regards,
Bjorn

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#18 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 4 lines · Sandeep Maheswaram (Temp)

Hi Felipe,

Please let me know how to go forward with this patch

Hi Sandeep,

Please just add a patch to fix the allmodconfig error. Felipe has suggested to introduce a separate patch which exports the device_is_bound() function. This export should precede the addition of interconnect support.

Also regarding the "depends on INTERCONNECT || !INTERCONNECT" change, no "depends on" would be needed, as we just made the interconnect framework bool.

Thanks,
Georgi

Quoted 75 lines

Regards

Sandeep

Quoted 69 lines · Bjorn Andersson
Quoted 52 lines · Felipe Balbi

Hi,

Quoted 44 lines · Georgi Djakov
Quoted 32 lines
Quoted 32 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

Review

Quoted 7 lines · Sandeep Maheswaram
(quoted diff) +7 -0
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+    struct device *dev = qcom->dev;
+    int ret;
+
+    if (!device_is_bound(&qcom->dwc3->dev))
+        return -EPROBE_DEFER;

this breaks allmodconfig. I'm dropping this series from my queue for
this merge window.

Quoted 3 lines
Quoted 1 line

Sorry, I meant this patch ;-)

I guess that's due to INTERCONNECT being a module. There is currently a

I believe it's because of this:
ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefined!

Quoted 6 lines

discussion about this  with Viresh and Georgi in response to another automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
from tristate to bool, which seems sensible to me given that interconnect
is a core subsystem.

The problem you are talking about would arise when INTERCONNECT=m and USB_DWC3_QCOM=y and it definitely exists here and could be triggered with
randconfig build. So i suggest to squash also the diff below.

Thanks,
Georgi

Quoted 12 lines
Quoted 10 lines

---8<---

drivers/usb/dwc3/Kconfig +0 -0
index 206caa0ea1c6..6661788b1a76 100644
@@ -129,6 +129,7 @@ config USB_DWC3_QCOM

      tristate "Qualcomm Platform"
      depends on ARCH_QCOM || COMPILE_TEST
      depends on EXTCON || !EXTCON
+    depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound()

Quoted 5 lines

Agree, but just to clarify, that these are two separate issues that need to
be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=y combined
with INTERCONNECT=m is the second one.

Quoted 5 lines

If INTERCONNECT=m, QCOM3 shouldn't be y. I think the following is enough:

    depends on INTERCONNECT=y || INTERCONNECT=USB_DWC3_QCOM

This misses the case where INTERCONNECT=n and USB_DWC3_QCOM=[ym] which I don't see a reason for breaking.

But if only INTERCONNECT where a bool, then we don't need to specify a depends on, because it will either be there, or the stubs will. We've come to this conclusion in a lot of different frameworks and I don't see why we should do this differently with INTERCONNECT.

Regards,
Bjorn

#19 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi,

Quoted 4 lines · Georgi Djakov
Quoted 3 lines · Sandeep Maheswaram (Temp)

Hi Felipe,

Please let me know how to go forward with this patch

(don't top-post!)

Quoted 8 lines

Please just add a patch to fix the allmodconfig error. Felipe has suggested to introduce a separate patch which exports the device_is_bound() function. This export should precede the addition of interconnect support.

Also regarding the "depends on INTERCONNECT || !INTERCONNECT" change, no "depends on" would be needed, as we just made the interconnect framework bool.

y'all have lost the current merge window, I guess. I'm not sure Greg will take last minute changes to drivers base and I have already sent him my pull request for v5.8. On the plus side, this gives you the chance to run hundreds of randbuilds with your patches.

Signature · 1 line
balbi
#20 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 14 lines · Felipe Balbi

Hi,

Quoted 4 lines · Georgi Djakov
Quoted 3 lines · Sandeep Maheswaram (Temp)

Hi Felipe,

Please let me know how to go forward with this patch

(don't top-post!)

Quoted 5 lines

Please just add a patch to fix the allmodconfig error. Felipe has suggested to introduce a separate patch which exports the device_is_bound() function. This export should precede the addition of interconnect support.

Quoted 7 lines
Quoted 3 lines

Also regarding the "depends on INTERCONNECT || !INTERCONNECT" change, no "depends on" would be needed, as we just made the interconnect framework bool.

y'all have lost the current merge window, I guess. I'm not sure Greg will take last minute changes to drivers base and I have already sent him my pull request for v5.8. On the plus side, this gives you the chance to run hundreds of randbuilds with your patches.

Hi  Georgi,

I am assuming that the patch which exports the device_is_bound() function will solve the allmodconfig error. Or do i need to change anything in dwc3 driver?

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#21 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

In reply to Sandeep Maheswaram

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 5 lines
drivers/usb/dwc3/dwc3-qcom.c +0 -0
index 1dfd024..d33ae86 100644

drivers/usb/dwc3/dwc3-qcom.c struct dwc3_qcom { · line 93

Quoted 9 lines
drivers/usb/dwc3/dwc3-qcom.c +4 -0
@@ -76,8 +85,13 @@ struct dwc3_qcom {
        enum usb_dr_mode        mode;
        bool                    is_suspended;
        bool                    pm_suspended;
+       struct icc_path         *usb_ddr_icc_path;
+       struct icc_path         *apps_usb_icc_path;
 };
 
+static int dwc3_qcom_interconnect_enable(struct dwc3_qcom *qcom);
+static int dwc3_qcom_interconnect_disable(struct dwc3_qcom *qcom);

Please get rid of these. We shouldn't need forward declarations.

Quoted 11 lines
drivers/usb/dwc3/dwc3-qcom.c +4 -0
+
 static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val)
 {
        u32 reg;
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
        return 0;
 }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

#22 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 13 lines · Stephen Boyd

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 12 lines
drivers/usb/dwc3/dwc3-qcom.c +2 -0
index 1dfd024..d33ae86 100644
@@ -76,8 +85,13 @@ struct dwc3_qcom {
         enum usb_dr_mode        mode;
         bool                    is_suspended;
         bool                    pm_suspended;
+       struct icc_path         *usb_ddr_icc_path;
+       struct icc_path         *apps_usb_icc_path;
  };
 
Quoted 3 lines

drivers/usb/dwc3/dwc3-qcom.c struct dwc3_qcom { · line 93

Quoted 2 lines
drivers/usb/dwc3/dwc3-qcom.c +2 -0
+static int dwc3_qcom_interconnect_enable(struct dwc3_qcom *qcom);
+static int dwc3_qcom_interconnect_disable(struct dwc3_qcom *qcom);

Please get rid of these. We shouldn't need forward declarations.

Will do in next version.

Quoted 36 lines
Quoted 12 lines
drivers/usb/dwc3/dwc3-qcom.c +4 -0
+
  static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset, u32 val)
  {
         u32 reg;
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
         return 0;
  }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#23 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 47 lines · Stephen Boyd
Quoted 36 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 11 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
         return 0;
  }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

#24 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 55 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 47 lines · Stephen Boyd
Quoted 36 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 11 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
         return 0;
  }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

#25 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 71 lines · Matthias Kaehlcke
Quoted 53 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 46 lines · Stephen Boyd
Quoted 36 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 11 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
          return 0;
   }
 
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 322

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

Quoted 3 lines

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

if (np)
        ret = dwc3_qcom_of_register_core(pdev);
    else
        ret = dwc3_qcom_acpi_register_core(pdev);

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

    ret = dwc3_qcom_interconnect_init(qcom);
    if (ret)
        goto depopulate;

    qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Before calling dwc3_qcom_interconnect_init we are checking

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

Doesn't  this condition confirm the core driver is probed?

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#26 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 91 lines · Sandeep Maheswaram (Temp)
Quoted 70 lines · Matthias Kaehlcke
Quoted 52 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 45 lines · Stephen Boyd
Quoted 35 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
          return 0;
   }
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 321

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

Quoted 3 lines

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

if (np)
        ret = dwc3_qcom_of_register_core(pdev);
    else
        ret = dwc3_qcom_acpi_register_core(pdev);

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

    ret = dwc3_qcom_interconnect_init(qcom);
    if (ret)
        goto depopulate;

    qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Quoted 8 lines

Before calling dwc3_qcom_interconnect_init we are checking

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

Doesn't  this condition confirm the core driver is probed?

Not really:

// called under the hood by of_platform_populate()
static int really_probe(struct device *dev, struct device_driver *drv)

{
	...

	if (dev->bus->probe) {
		ret = dev->bus->probe(dev);
		if (ret)
			goto probe_failed;
	} else if (drv->probe) {
		ret = drv->probe(dev);
	        if (ret)
	       		goto probe_failed;
        }

	...

probe_failed:

	...

	/*
         * Ignore errors returned by ->probe so that the next driver can try
         * its luck.
         */
        ret = 0;

	...

	return ret;
}

As a result of_platform_populate() in dwc3_qcom_of_register_core() returns 0 even when probing the device failed:

[    0.244339] dwc3-qcom a6f8800.usb: DBG: populate
[    0.244772] dwc3 a600000.dwc3: DBG: dwc3_probe
[    0.245237] dwc3 a600000.dwc3: DBG: dwc3_probe err: -517
[    0.245264] dwc3-qcom a6f8800.usb: DBG: populate (done)
[    0.245317] dwc3-qcom a6f8800.usb: DBG: dwc3_qcom_interconnect_init() failed: -517

Probe fails because the interconnect stuff isn't ready yet, otherwise it could access invalid data.

A later _populate() is successful and the probing of the core is done synchronously, i.e. after _populate() the core driver is fully initialized:

[    3.898106] dwc3-qcom a6f8800.usb: DBG: populate
[    3.908356] dwc3 a600000.dwc3: DBG: dwc3_probe
[    4.205104] dwc3 a600000.dwc3: DBG: dwc3_probe (done)
[    4.210305] dwc3-qcom a6f8800.usb: DBG: populate (done)

The synchronous probing in _populate() suggests that using device_is_bound() would actually be a valid option, either the core device was successfully probed or not, there should be no race.

I sent a patch that adds this check to dwc3_qcom_of_register_core(), which is less confusing and makes clear that the core device is valid unless this function returns an error:

https://lore.kernel.org/patchwork/patch/1257279/

It might make sense to add your "driver core:Export the symbol device_is_bound" patch, mine and this one to a single series.

Thanks

Matthias

#27 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 159 lines · Matthias Kaehlcke
Quoted 91 lines · Sandeep Maheswaram (Temp)
Quoted 70 lines · Matthias Kaehlcke
Quoted 52 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 45 lines · Stephen Boyd
Quoted 35 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
          return 0;
   }
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 321

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

Quoted 3 lines

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

if (np)
        ret = dwc3_qcom_of_register_core(pdev);
    else
        ret = dwc3_qcom_acpi_register_core(pdev);

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

    ret = dwc3_qcom_interconnect_init(qcom);
    if (ret)
        goto depopulate;

    qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Quoted 8 lines

Before calling dwc3_qcom_interconnect_init we are checking

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

Doesn't  this condition confirm the core driver is probed?

Not really:

// called under the hood by of_platform_populate()
static int really_probe(struct device *dev, struct device_driver *drv)

{
	...

	if (dev->bus->probe) {
		ret = dev->bus->probe(dev);
		if (ret)
			goto probe_failed;
	} else if (drv->probe) {
		ret = drv->probe(dev);
	        if (ret)
	       		goto probe_failed;
        }

	...

probe_failed:

	...

	/*
         * Ignore errors returned by ->probe so that the next driver can try
         * its luck.
         */
        ret = 0;

	...

	return ret;
}

As a result of_platform_populate() in dwc3_qcom_of_register_core() returns 0 even when probing the device failed:

[    0.244339] dwc3-qcom a6f8800.usb: DBG: populate
[    0.244772] dwc3 a600000.dwc3: DBG: dwc3_probe
[    0.245237] dwc3 a600000.dwc3: DBG: dwc3_probe err: -517
[    0.245264] dwc3-qcom a6f8800.usb: DBG: populate (done)
[    0.245317] dwc3-qcom a6f8800.usb: DBG: dwc3_qcom_interconnect_init() failed: -517

Probe fails because the interconnect stuff isn't ready yet, otherwise it could access invalid data.

A later _populate() is successful and the probing of the core is done synchronously, i.e. after _populate() the core driver is fully initialized:

[    3.898106] dwc3-qcom a6f8800.usb: DBG: populate
[    3.908356] dwc3 a600000.dwc3: DBG: dwc3_probe
[    4.205104] dwc3 a600000.dwc3: DBG: dwc3_probe (done)
[    4.210305] dwc3-qcom a6f8800.usb: DBG: populate (done)

The synchronous probing in _populate() suggests that using device_is_bound() would actually be a valid option, either the core device was successfully probed or not, there should be no race.

Quoted 8 lines

I sent a patch that adds this check to dwc3_qcom_of_register_core(), which is less confusing and makes clear that the core device is valid unless this function returns an error:

https://lore.kernel.org/patchwork/patch/1257279/

It might make sense to add your "driver core:Export the symbol device_is_bound" patch, mine and this one to a single series.

From the discussion on "driver core:Export the symbol device_is_bound"
(https://patchwork.kernel.org/patch/11584225/) it is clear that this won't fly. The split dwc3 driver is considered a broken design.

This is what Rob Herring said:

We never should have had this split either in the DT binding nor driver(s) as if the SoC wrapper crap and licensed IP block are independent things. The thing to do here is either make the DWC3 code a library which drivers call (e.g. SDHCI) or add hooks into the DWC3 driver for platform specifics (e.g. Designware PCI). Neither is a simple solution though.

That seems to be the desirable solution in the longer term, but it doesn't seem reasonable to me to expect you to fix this design issue to add interconnect support.

Some possible options to move forward:

- try to determine the max speed without involving the core device
- select a reasonable default when 'maximum-speed' is not specified
- use the core device to determine the max speed and pray

#28 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 184 lines · Matthias Kaehlcke
Quoted 157 lines · Matthias Kaehlcke
Quoted 90 lines · Sandeep Maheswaram (Temp)
Quoted 70 lines · Matthias Kaehlcke
Quoted 52 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 45 lines · Stephen Boyd
Quoted 35 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
           return 0;
    }
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 321

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

Quoted 3 lines

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

if (np)
        ret = dwc3_qcom_of_register_core(pdev); else
        ret = dwc3_qcom_acpi_register_core(pdev);

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

    ret = dwc3_qcom_interconnect_init(qcom);
    if (ret)
        goto depopulate;

    qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Quoted 8 lines

Before calling dwc3_qcom_interconnect_init we are checking

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

Doesn't  this condition confirm the core driver is probed?

Not really:

// called under the hood by of_platform_populate()
static int really_probe(struct device *dev, struct device_driver *drv)

{
	...

	if (dev->bus->probe) {
		ret = dev->bus->probe(dev);
		if (ret)
			goto probe_failed;
	} else if (drv->probe) {
		ret = drv->probe(dev);
	        if (ret)
	       		goto probe_failed;
         }

	...

probe_failed:

	...

	/*
          * Ignore errors returned by ->probe so that the next driver can try
          * its luck.
          */
         ret = 0;

	...

	return ret;
}

As a result of_platform_populate() in dwc3_qcom_of_register_core() returns 0 even when probing the device failed:

[    0.244339] dwc3-qcom a6f8800.usb: DBG: populate
[    0.244772] dwc3 a600000.dwc3: DBG: dwc3_probe
[    0.245237] dwc3 a600000.dwc3: DBG: dwc3_probe err: -517
[    0.245264] dwc3-qcom a6f8800.usb: DBG: populate (done)
[    0.245317] dwc3-qcom a6f8800.usb: DBG: dwc3_qcom_interconnect_init() failed: -517

Probe fails because the interconnect stuff isn't ready yet, otherwise it could access invalid data.

A later _populate() is successful and the probing of the core is done synchronously, i.e. after _populate() the core driver is fully initialized:

[    3.898106] dwc3-qcom a6f8800.usb: DBG: populate
[    3.908356] dwc3 a600000.dwc3: DBG: dwc3_probe
[    4.205104] dwc3 a600000.dwc3: DBG: dwc3_probe (done)
[    4.210305] dwc3-qcom a6f8800.usb: DBG: populate (done)

The synchronous probing in _populate() suggests that using device_is_bound() would actually be a valid option, either the core device was successfully probed or not, there should be no race.

Quoted 8 lines

I sent a patch that adds this check to dwc3_qcom_of_register_core(), which is less confusing and makes clear that the core device is valid unless this function returns an error:

   https://lore.kernel.org/patchwork/patch/1257279/

It might make sense to add your "driver core:Export the symbol device_is_bound" patch, mine and this one to a single series.

From the discussion on "driver core:Export the symbol device_is_bound"
(https://patchwork.kernel.org/patch/11584225/) it is clear that this won't fly. The split dwc3 driver is considered a broken design.

This is what Rob Herring said:

We never should have had this split either in the DT binding nor driver(s) as if the SoC wrapper crap and licensed IP block are independent things. The thing to do here is either make the DWC3 code a library which drivers call (e.g. SDHCI) or add hooks into the DWC3 driver for platform specifics (e.g. Designware PCI). Neither is a simple solution though.

That seems to be the desirable solution in the longer term, but it doesn't seem reasonable to me to expect you to fix this design issue to add interconnect support.

Quoted 5 lines

Some possible options to move forward:

- try to determine the max speed without involving the core device
- select a reasonable default when 'maximum-speed' is not specified
- use the core device to determine the max speed and pray

Can we do as below to get speed

qcom->max_speed = usb_get_maximum_speed(&qcom->dwc3->dev);

as they were doing similarly in below code to get mode

qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
#29 lore raw

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Quoted 188 lines · Sandeep Maheswaram (Temp)
Quoted 186 lines · Matthias Kaehlcke
Quoted 157 lines · Matthias Kaehlcke
Quoted 90 lines · Sandeep Maheswaram (Temp)
Quoted 70 lines · Matthias Kaehlcke
Quoted 52 lines · Stephen Boyd

Quoting Sandeep Maheswaram (Temp) (2020-06-04 02:43:09)

Quoted 45 lines · Stephen Boyd
Quoted 35 lines

Quoting Sandeep Maheswaram (2020-03-31 22:15:43)

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +3 -0
index 1dfd024..d33ae86 100644
@@ -285,6 +307,101 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
           return 0;
    }
+
+/**
+ * dwc3_qcom_interconnect_init() - Get interconnect path handles

drivers/usb/dwc3/dwc3-qcom.c static int dwc3_qcom_resume(struct dwc3_qcom *qcom) · line 321

Quoted 10 lines
drivers/usb/dwc3/dwc3-qcom.c +10 -0
+ * @qcom:                      Pointer to the concerned usb core.
+ *
+ */
+static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
+{
+       struct device *dev = qcom->dev;
+       int ret;
+
+       if (!device_is_bound(&qcom->dwc3->dev))
+               return -EPROBE_DEFER;

How is this supposed to work? I see that this was added in an earlier revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?

Furthermore, dwc3_qcom_interconnect_init() is called by dwc3_qcom_probe() which is the function that registers the device for qcom->dwc3->dev. If that device doesn't probe between the time it is registered by dwc3_qcom_probe() and this function is called then we'll fail dwc3_qcom_probe() with -EPROBE_DEFER. And that will remove the qcom->dwc3->dev device from the platform bus because we call of_platform_depopulate() on the error path of dwc3_qcom_probe().

Quoted 9 lines

So isn't this whole thing racy and can potentially lead us to a driver probe loop where the wrapper (dwc3_qcom) and the core (dwc3) are probing and we're trying to time it just right so that driver for dwc3 binds before we setup interconnects? I don't know if dwc3 can communicate to the wrapper but that would be more of a direct way to do this. Or maybe the wrapper should try to read the DT property for maximum speed and fallback to a worst case high bandwidth value if it can't figure it out itself without help from dwc3 core.

Quoted 4 lines

This was added in V4 to address comments from Matthias in V3

https://patchwork.kernel.org/patch/11148587/

Yes, that why I said:

Quoted 7 lines

"I see that this was added in an earlier
revision of this patch series but there isn't any mention of why device_is_bound() is used here. It would be great if there was a comment detailing why this is necessary. It sounds like maximum_speed is important?"

Can you please respond to the rest of my email?

I agree with Stephen that using device_is_bound() isn't a good option in this case, when I suggested it I wasn't looking at the big picture of how probing the core driver is triggered, sorry about that.

Reading the speed from the DT with usb_get_maximum_speed() as Stephen suggests would be an option, the inconvenient is that we then essentially require the property to be defined, while the core driver gets a suitable value from hardware registers. Not sure if the wrapper driver could read from the same registers.

Quoted 3 lines

One option could be to poll device_is_bound() for 100 ms (or so), with sleeps between polls. It's not elegant but would probably work if we don't find a better solution.

if (np)
        ret = dwc3_qcom_of_register_core(pdev); else
        ret = dwc3_qcom_acpi_register_core(pdev);

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

    ret = dwc3_qcom_interconnect_init(qcom);
    if (ret)
        goto depopulate;

    qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev);

Quoted 8 lines

Before calling dwc3_qcom_interconnect_init we are checking

    if (ret) {
        dev_err(dev, "failed to register DWC3 Core, err=%d\n", ret); goto depopulate;
    }

Doesn't  this condition confirm the core driver is probed?

Not really:

// called under the hood by of_platform_populate()
static int really_probe(struct device *dev, struct device_driver *drv)

{
	...

	if (dev->bus->probe) {
		ret = dev->bus->probe(dev);
		if (ret)
			goto probe_failed;
	} else if (drv->probe) {
		ret = drv->probe(dev);
	        if (ret)
	       		goto probe_failed;
         }

	...

probe_failed:

	...

	/*
          * Ignore errors returned by ->probe so that the next driver can try
          * its luck.
          */
         ret = 0;

	...

	return ret;
}

As a result of_platform_populate() in dwc3_qcom_of_register_core() returns 0 even when probing the device failed:

[    0.244339] dwc3-qcom a6f8800.usb: DBG: populate
[    0.244772] dwc3 a600000.dwc3: DBG: dwc3_probe
[    0.245237] dwc3 a600000.dwc3: DBG: dwc3_probe err: -517
[    0.245264] dwc3-qcom a6f8800.usb: DBG: populate (done)
[    0.245317] dwc3-qcom a6f8800.usb: DBG: dwc3_qcom_interconnect_init() failed: -517

Probe fails because the interconnect stuff isn't ready yet, otherwise it could access invalid data.

A later _populate() is successful and the probing of the core is done synchronously, i.e. after _populate() the core driver is fully initialized:

[    3.898106] dwc3-qcom a6f8800.usb: DBG: populate
[    3.908356] dwc3 a600000.dwc3: DBG: dwc3_probe
[    4.205104] dwc3 a600000.dwc3: DBG: dwc3_probe (done)
[    4.210305] dwc3-qcom a6f8800.usb: DBG: populate (done)

The synchronous probing in _populate() suggests that using device_is_bound() would actually be a valid option, either the core device was successfully probed or not, there should be no race.

Quoted 8 lines

I sent a patch that adds this check to dwc3_qcom_of_register_core(), which is less confusing and makes clear that the core device is valid unless this function returns an error:

   https://lore.kernel.org/patchwork/patch/1257279/

It might make sense to add your "driver core:Export the symbol device_is_bound" patch, mine and this one to a single series.

From the discussion on "driver core:Export the symbol device_is_bound"
(https://patchwork.kernel.org/patch/11584225/) it is clear that this won't fly. The split dwc3 driver is considered a broken design.

This is what Rob Herring said:

We never should have had this split either in the DT binding nor driver(s) as if the SoC wrapper crap and licensed IP block are independent things. The thing to do here is either make the DWC3 code a library which drivers call (e.g. SDHCI) or add hooks into the DWC3 driver for platform specifics (e.g. Designware PCI). Neither is a simple solution though.

That seems to be the desirable solution in the longer term, but it doesn't seem reasonable to me to expect you to fix this design issue to add interconnect support.

Some possible options to move forward:

Quoted 7 lines
Quoted 3 lines

- try to determine the max speed without involving the core device
- select a reasonable default when 'maximum-speed' is not specified
- use the core device to determine the max speed and pray

Can we do as below to get speed

qcom->max_speed = usb_get_maximum_speed(&qcom->dwc3->dev);

Yes, that would get the maximum speed from the DT if it is specified. In case of USB_SPEED_UNKNOWN you probably want to assume it's USB_SPEED_SUPER, which in the worst case would result in the ICC running at a higher speed than needed.