mm/swapfile: use list_{prev,next}_entry() instead of open-coding
Subsystems (2)
PATCH 1/1 mm/swapfile: use list_{prev,next}_entry() instead of open-coding
From: chenqiwu <[email protected]>
Use list_{prev,next}_entry() instead of list_entry() for better code readability.
Signed-off-by chenqiwu <[email protected]>
--- mm/swapfile.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
mm/swapfile.c +6 -10
@@ -3653,7 +3653,7 @@ static bool swap_count_continued(struct swap_info_struct *si,spin_lock (&si->cont_lock); offset &= ~PAGE_MASK ; - page = list_entry(head->lru.next, struct page, lru); + page =list_next_entry (head, lru); map =kmap_atomic (page) + offset;if (count ==SWAP_MAP_MAX )/* initial increment from swap_map */
@@ -3665,13 +3665,13 @@ static bool swap_count_continued(struct swap_info_struct *si,*/ while (*map == (SWAP_CONT_MAX |COUNT_CONTINUED )) {kunmap_atomic (map); - page = list_entry(page->lru.next, struct page, lru); + page =list_next_entry (page, lru);BUG_ON (page == head); map =kmap_atomic (page) + offset; }if (*map ==SWAP_CONT_MAX ) {kunmap_atomic (map); - page = list_entry(page->lru.next, struct page, lru); + page =list_next_entry (page, lru);if (page == head) { ret = false;/* add count continuation */ goto out;
@@ -3681,12 +3681,10 @@ static bool swap_count_continued(struct swap_info_struct *si, } *map +=1 ;kunmap_atomic (map); - page = list_entry(page->lru.prev, struct page, lru); -while (page != head) { +while ((page =list_prev_entry (page, lru)) != head) { map =kmap_atomic (page) + offset; *map =COUNT_CONTINUED ;kunmap_atomic (map); - page = list_entry(page->lru.prev, struct page, lru); } ret = true;/* incremented */
@@ -3697,7 +3695,7 @@ static bool swap_count_continued(struct swap_info_struct *si,BUG_ON (count !=COUNT_CONTINUED );while (*map ==COUNT_CONTINUED ) {kunmap_atomic (map); - page = list_entry(page->lru.next, struct page, lru); + page =list_next_entry (page, lru);BUG_ON (page == head); map =kmap_atomic (page) + offset; }
@@ -3706,13 +3704,11 @@ static bool swap_count_continued(struct swap_info_struct *si,if (*map ==0 ) count =0 ;kunmap_atomic (map); - page = list_entry(page->lru.prev, struct page, lru); -while (page != head) { +while ((page =list_prev_entry (page, lru)) != head) { map =kmap_atomic (page) + offset; *map =SWAP_CONT_MAX | count; count =COUNT_CONTINUED ;kunmap_atomic (map); - page = list_entry(page->lru.prev, struct page, lru); } ret = count ==COUNT_CONTINUED ; }
Signature · 1 line
1.9.1