Skip to contentSkip to conversation

drm/amdgpu: Print UTCL2 client ID on a gpuvm fault

PATCH In review Oak Zeng 3 participants 3 messages Apr 6, 2020

Subsystems (2)
lore
Share & tools
lore

Oak Zeng

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Print UTCL2 client ID on a gpuvm fault

UTCL2 client ID is useful information to get which UTCL2 client caused the gpuvm fault. Print it out for debug purpose

Change-Id I733d0127b0ee53aa788f194cefa53cbb55b49c11
---
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c  | 3 +++
 2 files changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c +3 -0
index 78d769e..94a6096 100644
@@ -170,6 +170,9 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev,
 			dev_err(adev->dev,
 				"GCVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
 				status);
+			dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+				REG_GET_FIELD(status,
+				GCVM_L2_PROTECTION_FAULT_STATUS, CID));
 			dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
 				REG_GET_FIELD(status,
 				GCVM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -0
index 8606f87..fecdbc4 100644
@@ -362,6 +362,9 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
 			dev_err(adev->dev,
 				"VM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
 				status);
+			dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+				REG_GET_FIELD(status,
+				VM_L2_PROTECTION_FAULT_STATUS, CID));
 			dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
 				REG_GET_FIELD(status,
 				VM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Oak Zeng

UTCL2 client ID is useful information to get which UTCL2 client caused the gpuvm fault. Print it out for debug purpose

Change-Id I733d0127b0ee53aa788f194cefa53cbb55b49c11
Quoted 36 lines
---
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c  | 3 +++
 2 files changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c +3 -0
index 78d769e..94a6096 100644
@@ -170,6 +170,9 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev,
                        dev_err(adev->dev,
                                "GCVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
                                status);
+                       dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+                               REG_GET_FIELD(status,
+                               GCVM_L2_PROTECTION_FAULT_STATUS, CID));
                        dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
                                REG_GET_FIELD(status,
                                GCVM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -1
index 8606f87..fecdbc4 100644
@@ -362,6 +362,9 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
                        dev_err(adev->dev,
                                "VM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
                                status);
+                       dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+                               REG_GET_FIELD(status,
+                               VM_L2_PROTECTION_FAULT_STATUS, CID));
                        dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
                                REG_GET_FIELD(status,
                                VM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#2 lore raw

Am 06.04.20 um 20:46 schrieb Alex Deucher:

Quoted 8 lines · Oak Zeng
Quoted 6 lines

UTCL2 client ID is useful information to get which UTCL2 client caused the gpuvm fault. Print it out for debug purpose

Change-Id I733d0127b0ee53aa788f194cefa53cbb55b49c11
Quoted 38 lines
Quoted 38 lines

---
  drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c  | 3 +++
  2 files changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c +3 -0
index 78d769e..94a6096 100644
@@ -170,6 +170,9 @@ static int gmc_v10_0_process_interrupt(struct amdgpu_device *adev,
                         dev_err(adev->dev,
                                 "GCVM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
                                 status);
+                       dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+                               REG_GET_FIELD(status,
+                               GCVM_L2_PROTECTION_FAULT_STATUS, CID));
                         dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
                                 REG_GET_FIELD(status,
                                 GCVM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +3 -1
index 8606f87..fecdbc4 100644
@@ -362,6 +362,9 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
                         dev_err(adev->dev,
                                 "VM_L2_PROTECTION_FAULT_STATUS:0x%08X\n",
                                 status);
+                       dev_err(adev->dev, "\t Faulty UTCL2 client ID: 0x%lx\n",
+                               REG_GET_FIELD(status,
+                               VM_L2_PROTECTION_FAULT_STATUS, CID));
                         dev_err(adev->dev, "\t MORE_FAULTS: 0x%lx\n",
                                 REG_GET_FIELD(status,
                                 VM_L2_PROTECTION_FAULT_STATUS, MORE_FAULTS));
--

2.7.4

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx