Staging: comedi: dt2815: remove set but not used variable 'hi'
PATCH 1/1 Staging: comedi: dt2815: remove set but not used variable 'hi'
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In function dt2815_ao_insn:drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable 'hi' set but not used [-Wunused-but-set-variable]
commit d6a929b7608a ("Staging: comedi: add dt2815 driver") involved this, remove it.
--- drivers/staging/comedi/drivers/dt2815.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/comedi/drivers/dt2815.c +1 -2
@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s,struct dt2815_private *devpriv = dev->private;int i;int chan =CR_CHAN (insn->chanspec); -unsigned int lo, hi; +unsigned int lo;int ret;for (i =0 ; i < insn->n; i++) { lo = ((data[i] &0x0f ) <<4 ) | (chan <<1 ) |0x01 ; - hi = (data[i] &0xff0 ) >>4 ; ret =comedi_timeout (dev, s, insn, dt2815_ao_status,0x00 );if (ret)
Signature · 1 line
1.8.3.1
Quoted 23 lines · Wang Hai
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/comedi/drivers/dt2815.c: In functiondt2815_ao_insn:drivers/staging/comedi/drivers/dt2815.c:91:19: warning: variable 'hi' set but not used [-Wunused-but-set-variable]commit
d6a929b7608a("Staging: comedi: add dt2815 driver") involved this, remove it.Reported-by Hulk Robot <[email protected]>Signed-off-by Wang Hai <[email protected]>--- drivers/staging/comedi/drivers/dt2815.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/comedi/drivers/dt2815.c +0
-0@@ -88,12 +88,11 @@ static int dt2815_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s,struct dt2815_private *devpriv = dev->private;int i;int chan =CR_CHAN (insn->chanspec);
drivers/staging/comedi/drivers/dt2815.c static int dt2815_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s, · line 98
Quoted 10 lines
drivers/staging/comedi/drivers/dt2815.c +1
-2-unsigned int lo, hi; +unsigned int lo;int ret;for (i =0 ; i < insn->n; i++) { lo = ((data[i] &0x0f ) <<4 ) | (chan <<1 ) |0x01 ; - hi = (data[i] &0xff0 ) >>4 ; ret =comedi_timeout (dev, s, insn, dt2815_ao_status,0x00 );if (ret)
That 'hi' value should be written to the hardware, but the driver is broken. I don't think this driver has ever been tested as working because it has never written the 'hi' value to the hardware!
I think I know how to fix it. I'll send a patch.
Signature · 4 lines
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-