venus: core: remove CNOC voting while device suspend
Subsystems (4)
PATCH v2 1/1 venus: core: remove CNOC voting while device suspend
The Venus driver is voting Configuration NoC during .probe but not clear voting in .suspend. Because of this NoC is up during shutdown also. As a consequence the whole device could leak energy while in .suspend.
So correct this by moving voting in .resume and unvoting in .suspend
---
Changes in V2:
- As per stanimir comment changed the commit message.
drivers/media/platform/qcom/venus/core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/media/platform/qcom/venus/core.c +8 -4
@@ -242,10 +242,6 @@ static int venus_probe(struct platform_device *pdev)if (ret)return ret; - ret =icc_set_bw (core->cpucfg_path,0 ,kbps_to_icc (1000 )); -if (ret) -return ret; - ret =hfi_create (core, &venus_core_ops);if (ret)return ret;
@@ -350,6 +346,10 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)if (ret)return ret; + ret =icc_set_bw (core->cpucfg_path,0 ,0 ); +if (ret) +return ret; +if (pm_ops->core_power) ret = pm_ops->core_power (dev,POWER_OFF );
@@ -368,6 +368,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)return ret; } + ret =icc_set_bw (core->cpucfg_path,0 ,kbps_to_icc (1000 )); +if (ret) +return ret; +return hfi_core_resume (core, false); }
Signature · 1 line
2.7.4
Thanks Mansur,
Quoted 8 lines · Mansur Alisha Shaik
The Venus driver is voting Configuration NoC during .probe but not clear voting in .suspend. Because of this NoC is up during shutdown also. As a consequence the whole device could leak energy while in .suspend.
So correct this by moving voting in .resume and unvoting in .suspend
Signed-off-by mansur alisha shaik <[email protected]>
Please configure git and use 'git commit -s' to sign off your commits next time. I will correct that when applying.
Quoted 6 lines
---
Changes in V2:
- As per stanimir comment changed the commit message.drivers/media/platform/qcom/venus/core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
Signature · 2 lines
regards, Stan