Skip to contentSkip to conversation

amdgpu/vcn: add dummy feedback message

PATCH In review James Zhu 3 participants 3 messages Apr 13, 2020

lore
Share & tools
lore

James Zhu

author
#0 lore raw

PATCH 1/1 amdgpu/vcn: add dummy feedback message

Latest VCN firmware has feedback header check.

---
 tests/amdgpu/decode_messages.h | 4 ++++
 tests/amdgpu/vcn_tests.c       | 1 +
 2 files changed, 5 insertions(+)
tests/amdgpu/decode_messages.h +4 -0
index bd6fe4b..0dd80a2 100644
@@ -845,4 +845,8 @@ static const uint8_t vcn_dec_destroy_msg[] = {
 	0x03,0x00,0x44,0x40,0x00,0x00,0x00,0x00,
 };
 
+static const uint8_t feedback_msg[] = {
+	0x2c,0x00,0x00,0x00,0x2c,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
+};
+
 #endif /* _DECODE_MESSAGES_H_ */
tests/amdgpu/vcn_tests.c +1 -0
index ad438f3..0d8df81 100644
@@ -333,6 +333,7 @@ static void amdgpu_cs_vcn_dec_decode(void)
 			avc_decode_msg, sizeof(avc_decode_msg));
 
 	dec += 4*1024;
+	memcpy(dec, feedback_msg, sizeof(feedback_msg));
 	dec += 4*1024;
 	memcpy(dec, uvd_it_scaling_table, sizeof(uvd_it_scaling_table));
 
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

I think you need to create a MR for libdrm patch, and the tittle should be like "tests/amdgpu/vcn"

Regards,
Leo

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of James Zhu
Sent: Monday, April 13, 2020 1:13 PM
To: [email protected]
Cc: Li, Pauline <[email protected]>; Zhu, James <[email protected]>
Subject: [PATCH] amdgpu/vcn: add dummy feedback message

Latest VCN firmware has feedback header check.

---
 tests/amdgpu/decode_messages.h | 4 ++++
 tests/amdgpu/vcn_tests.c       | 1 +
 2 files changed, 5 insertions(+)
tests/amdgpu/decode_messages.h +4 -0
@@ -845,4 +845,8 @@ static const uint8_t vcn_dec_destroy_msg[] = {
 	0x03,0x00,0x44,0x40,0x00,0x00,0x00,0x00,
 };
 
+static const uint8_t feedback_msg[] = {
+	0x2c,0x00,0x00,0x00,0x2c,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
+};
+
 #endif /* _DECODE_MESSAGES_H_ */
tests/amdgpu/vcn_tests.c +1 -0
@@ -333,6 +333,7 @@ static void amdgpu_cs_vcn_dec_decode(void)
 			avc_decode_msg, sizeof(avc_decode_msg));
 
 	dec += 4*1024;
+	memcpy(dec, feedback_msg, sizeof(feedback_msg));
 	dec += 4*1024;
 	memcpy(dec, uvd_it_scaling_table, sizeof(uvd_it_scaling_table));
 

--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cleo.liu%40amd.com%7Ce06ed3031a8e4c5de9d008d7dfcde4e5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637223947784156110&amp;sdata=lkYADqz5Pqcu%2FYN%2BBZKzJHeCV8NypHniPBBHN3WD40U%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw

sure

Quoted 49 lines · Leo

[AMD Official Use Only - Internal Distribution Only]

I think you need to create a MR for libdrm patch, and the tittle should be like "tests/amdgpu/vcn"

Regards,
Leo

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of James Zhu
Sent: Monday, April 13, 2020 1:13 PM
To: [email protected]
Cc: Li, Pauline <[email protected]>; Zhu, James <[email protected]>
Subject: [PATCH] amdgpu/vcn: add dummy feedback message

Latest VCN firmware has feedback header check.

---
  tests/amdgpu/decode_messages.h | 4 ++++
  tests/amdgpu/vcn_tests.c       | 1 +
  2 files changed, 5 insertions(+)
tests/amdgpu/decode_messages.h +4 -0
@@ -845,4 +845,8 @@ static const uint8_t vcn_dec_destroy_msg[] = {
  	0x03,0x00,0x44,0x40,0x00,0x00,0x00,0x00,
  };
 
+static const uint8_t feedback_msg[] = {
+	0x2c,0x00,0x00,0x00,0x2c,0x00,0x00,0x00,0x00,0x00,0x00,0x00,
+};
+
  #endif /* _DECODE_MESSAGES_H_ */
tests/amdgpu/vcn_tests.c +1 -1
@@ -333,6 +333,7 @@ static void amdgpu_cs_vcn_dec_decode(void)
  			avc_decode_msg, sizeof(avc_decode_msg));
 
  	dec += 4*1024;
+	memcpy(dec, feedback_msg, sizeof(feedback_msg));
  	dec += 4*1024;
  	memcpy(dec, uvd_it_scaling_table, sizeof(uvd_it_scaling_table));
 
--

2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cleo.liu%40amd.com%7Ce06ed3031a8e4c5de9d008d7dfcde4e5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637223947784156110&amp;sdata=lkYADqz5Pqcu%2FYN%2BBZKzJHeCV8NypHniPBBHN3WD40U%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx