Skip to contentSkip to conversation

af9015 problem on fedora rawhide 9.93 with 2.6.27x kernel

linux-dvb Sebastian Marskamp 3 participants 6 messages Nov 12, 2008 – Nov 13, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Theres also a patch , which works fine for me.

http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081022/94261bbc/attachment.diff

_______________________________________________________________________
Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 30 Tage kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#1 lore raw
Quoted 3 lines · Sebastian Marskamp

Theres also a patch , which works fine for me.

http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081022/94261bbc/attachment.diff

This patch is not OK because it still sends reconnect USB-command. It may lead to situation stick reconnects but driver does not except that.

It seems like problem is that it sends USB-reconnect command to the stick firmware immediately after firmware is downloaded. Sometimes (especially Kernel 2.6.27) USB-reconnect command will be rejected by stick firmware because firmware is not started yet. Small sleep just before USB-reconnect is needed to ensure stick firmware is running.

Is there anyone who has this problem and can make & test patch?

regards
Antti

Signature · 6 lines
http://palosaari.fi/

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#2 lore raw
Quoted 15 lines · Antti Palosaari
Quoted 4 lines · Sebastian Marskamp

Theres also a patch , which works fine for me.

http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081022/94261bbc/
attachment.diff

This patch is not OK because it still sends reconnect USB-command. It may lead to situation stick reconnects but driver does not except that.

It seems like problem is that it sends USB-reconnect command to the stick firmware immediately after firmware is downloaded. Sometimes (especially Kernel 2.6.27) USB-reconnect command will be rejected by stick firmware because firmware is not started yet. Small sleep just before USB-reconnect is needed to ensure stick firmware is running.

Quoted 4 lines

Is there anyone who has this problem and can make & test patch?

regards
Antti

The attached patch work for me.

Jose Alberto

linux/drivers/media/dvb/dvb-usb/af9015.c +2 -6
diff -r b45ffc93fb82 linux/drivers/media/dvb/dvb-usb/af9015.c
@@ -681,12 +681,6 @@
 		goto error;
 	}
 
-	/* firmware is running, reconnect device in the usb bus */
-	req.cmd = RECONNECT_USB;
-	ret = af9015_rw_udev(udev, &req);
-	if (ret)
-		err("reconnect failed: %d", ret);
-
 error:
 	return ret;
 }
@@ -1219,6 +1213,7 @@
 		.usb_ctrl = DEVICE_SPECIFIC,
 		.download_firmware = af9015_download_firmware,
 		.firmware = "dvb-usb-af9015.fw",
+		.no_reconnect = 1,
 
 		.size_of_priv = sizeof(struct af9015_state), \
 
@@ -1317,6 +1312,7 @@
 		.usb_ctrl = DEVICE_SPECIFIC,
 		.download_firmware = af9015_download_firmware,
 		.firmware = "dvb-usb-af9015.fw",
+		.no_reconnect = 1,
 
 		.size_of_priv = sizeof(struct af9015_state), \
 

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#3 lore raw
Quoted 15 lines · Jose Alberto Reguero
Quoted 14 lines · Antti Palosaari
Quoted 4 lines · Sebastian Marskamp

Theres also a patch , which works fine for me.

http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081022/94261bbc/
attachment.diff

This patch is not OK because it still sends reconnect USB-command. It may lead to situation stick reconnects but driver does not except that.

It seems like problem is that it sends USB-reconnect command to the stick firmware immediately after firmware is downloaded. Sometimes (especially Kernel 2.6.27) USB-reconnect command will be rejected by stick firmware because firmware is not started yet. Small sleep just before USB-reconnect is needed to ensure stick firmware is running.

Quoted 8 lines
Quoted 4 lines

Is there anyone who has this problem and can make & test patch?

regards
Antti

The attached patch work for me.

Jose Alberto

Looks better, could you provide signed-off-by?

regards
Antti

Signature · 6 lines
http://palosaari.fi/

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#4 lore raw
Quoted 22 lines · Antti Palosaari
Quoted 21 lines · Jose Alberto Reguero
Quoted 19 lines · Antti Palosaari
Quoted 4 lines · Sebastian Marskamp

Theres also a patch , which works fine for me.

http://www.linuxtv.org/pipermail/linux-dvb/attachments/20081022/94261bb
c/ attachment.diff

This patch is not OK because it still sends reconnect USB-command. It may lead to situation stick reconnects but driver does not except that.

It seems like problem is that it sends USB-reconnect command to the stick firmware immediately after firmware is downloaded. Sometimes (especially Kernel 2.6.27) USB-reconnect command will be rejected by stick firmware because firmware is not started yet. Small sleep just before USB-reconnect is needed to ensure stick firmware is running.

Is there anyone who has this problem and can make & test patch?

regards
Antti

Quoted 8 lines
Quoted 3 lines

The attached patch work for me.

Jose Alberto

Looks better, could you provide signed-off-by?

regards
Antti

Jose Alberto

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb