FAILED: patch "[PATCH] drm/qxl: qxl_release leak in qxl_draw_dirty_fb()" failed to apply to 4.4-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 85e9b88af1e6164f19ec71381efd5e2bcfc17620 Mon Sep 17 00:00:00 2001
From: Vasily Averin <[email protected]>
Date: Mon, 27 Apr 2020 08:32:46 +0300
Subject: [PATCH] drm/qxl: qxl_release leak in qxl_draw_dirty_fb()
ret should be changed to release allocated struct qxl_release
Fixes 8002db6336dd ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by Vasily Averin <[email protected]>
Signed-off-by Gerd Hoffmann <[email protected]>
drivers/gpu/drm/qxl/qxl_draw.c +3 -2
@@ -209,9 +209,10 @@ void qxl_draw_dirty_fb(struct qxl_device *qdev, goto out_release_backoff; rects =drawable_set_clipping (qdev, num_clips, clips_bo); -if (!rects) +if (!rects) { + ret = -EINVAL ; goto out_release_backoff; - + } drawable = (struct qxl_drawable *)qxl_release_map (qdev, release); drawable->clip.type =SPICE_CLIP_TYPE_RECTS ;