Skip to contentSkip to conversation

arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

PATCH Applied Maulik Shah 3 participants 3 messages May 18, 2020 – May 21, 2020

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Arm/Qualcomm chromebook support
lore
Share & tools
lore

Maulik Shah

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

Few PDC interrupts do not map to respective parent GIC interrupt. Fix this by correcting the pdc interrupt map.

Fixes 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
Cc [email protected]
Signed-off-by Maulik Shah <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +1 -2
index f1280e0..f6b4ee8 100644
@@ -2308,8 +2308,7 @@
 		pdc: interrupt-controller@b220000 {
 			compatible = "qcom,sc7180-pdc", "qcom,pdc";
 			reg = <0 0x0b220000 0 0x30000>;
-			qcom,pdc-ranges = <0 480 15>, <17 497 98>,
-					  <119 634 4>, <124 639 1>;
+			qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;
 			#interrupt-cells = <2>;
 			interrupt-parent = <&intc>;
 			interrupt-controller;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Applied
#1 lore raw
Quoted 6 lines · Maulik Shah

Few PDC interrupts do not map to respective parent GIC interrupt. Fix this by correcting the pdc interrupt map.

Fixes 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
Cc [email protected]
Signed-off-by Maulik Shah <[email protected]>

Applied

Thanks,
Bjorn

Quoted 21 lines
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +1 -2
index f1280e0..f6b4ee8 100644
@@ -2308,8 +2308,7 @@
 		pdc: interrupt-controller@b220000 {
 			compatible = "qcom,sc7180-pdc", "qcom,pdc";
 			reg = <0 0x0b220000 0 0x30000>;
-			qcom,pdc-ranges = <0 480 15>, <17 497 98>,
-					  <119 634 4>, <124 639 1>;
+			qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;
 			#interrupt-cells = <2>;
 			interrupt-parent = <&intc>;
 			interrupt-controller;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
#2 lore raw
In reply to Maulik Shah

Quoting Maulik Shah (2020-05-18 05:20:02)

Quoted 15 lines

Few PDC interrupts do not map to respective parent GIC interrupt. Fix this by correcting the pdc interrupt map.

Fixes 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
Cc [email protected]
Signed-off-by Maulik Shah <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -0
index f1280e0..f6b4ee8 100644

arch/arm64/boot/dts/qcom/sc7180.dtsi line 2311

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc7180.dtsi +1 -2
@@ -2308,8 +2308,7 @@
                pdc: interrupt-controller@b220000 {
                        compatible = "qcom,sc7180-pdc", "qcom,pdc";
                        reg = <0 0x0b220000 0 0x30000>;
-                       qcom,pdc-ranges = <0 480 15>, <17 497 98>,
-                                         <119 634 4>, <124 639 1>;
+                       qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;

This is a sign that we shouldn't put this information in DT. It was wrong once so who knows if it will be wrong again. We don't have an automated way to check this like we can check other properties. And the information isn't something that is changed by firmware or the OS loader. It is static data about the internals of the PDC device and how it maps PDC pins to GIC SPI lines. We are probably better off just setting up these ranges in the driver vs. relying on DT authors to get it right.