fpga: dfl: afu: Corrected error handling levels
Subsystems (2)
PATCH v2 1/1 fpga: dfl: afu: Corrected error handling levels
Corrected error handling goto sequnece. Level put_pages should be called when pinned pages >= 0 && pinned != npages. Level free_pages should be called when pinned pages < 0.
Fixes fa8dda1edef9 (fpga: dfl: afu: add DFL_FPGA_PORT_DMA_MAP/
UNMAP ioctls support)
Signed-off-by Souptick Joarder <[email protected]>
Acked-by Wu Hao <[email protected]>
Reviewed-by Xu Yilun <[email protected]>
---
v2: Updated change logs and few reviews.
drivers/fpga/dfl-afu-dma-region.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/dfl-afu-dma-region.c +2 -2
@@ -61,10 +61,10 @@ static int afu_dma_pin_pages(struct dfl_feature_platform_data *pdata, region->pages);if (pinned <0 ) { ret = pinned; - goto put_pages; + goto free_pages; }else if (pinned != npages) { ret = -EFAULT ; - goto free_pages; + goto put_pages; }dev_dbg (dev,"%d pages pinned\n" , pinned);
Signature · 1 line
1.9.1