perf config: Add stat.big-num support
PATCH 1/1 perf config: Add stat.big-num support
From: "Paul A. Clarke" <[email protected]>
Add support for new "stat.big-num" boolean option.
This allows a user to set a default for "--no-big-num" for "perf stat" commands.
$ perf config stat.big-num $ perf stat --event cycles /bin/true
Performance counter stats for '/bin/true':
803,684 cycles [...] $ perf config stat.big-num=0 $ perf config stat.big-num stat.big-num=0 $ perf stat --event cycles /bin/true
Performance counter stats for '/bin/true':
790448 cycles
[...]
There is an interaction with "--field-separator" that must be accommodated, such that specifying "--big-num --field-separator={x}" still reports an invalid combination of options.
---
Testing results with a matrix of:
- nothing in .perfconfig, stat.big-num=0, stat.big-num=1
- --field-separator not set, --field-separator=:
- no "--big-num", --big-num, --no-big-num
$ perf config stat.big-num $ perf stat --event cycles /bin/true
Performance counter stats for '/bin/true':
803,684 cycles
0.000592761 seconds time elapsed
0.000672000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/true
Performance counter stats for '/bin/true':
809,599 cycles
0.000576090 seconds time elapsed
0.000627000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/true
Performance counter stats for '/bin/true':
793870 cycles
0.000574928 seconds time elapsed
0.000625000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 790255::cycles:346960:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -x
Usage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator
$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 764548::cycles:335938:100.00:: $ perf config stat.big-num=0 $ perf config stat.big-num stat.big-num=0 $ perf stat --event cycles /bin/true
Performance counter stats for '/bin/true':
790448 cycles
0.000567659 seconds time elapsed
0.000619000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/true
Performance counter stats for '/bin/true':
751,377 cycles
0.000534888 seconds time elapsed
0.000587000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/true
Performance counter stats for '/bin/true':
803738 cycles
0.000576151 seconds time elapsed
0.000657000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 774897::cycles:339986:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -x
Usage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator
$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 814619::cycles:358260:100.00:: $ perf config stat.big-num=1 $ perf config stat.big-num stat.big-num=1 $ perf stat --event cycles /bin/true
Performance counter stats for '/bin/true':
787,680 cycles
0.000555401 seconds time elapsed
0.000623000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/true
Performance counter stats for '/bin/true':
783,287 cycles
0.000562255 seconds time elapsed
0.000636000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/true
Performance counter stats for '/bin/true':
748802 cycles
0.000525658 seconds time elapsed
0.000586000 seconds user
0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 785868::cycles:344508:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -x
Usage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator
$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 794273::cycles:349600:100.00:: $ -- tools/perf/builtin-stat.c | 6 ++++++ tools/perf/util/config.c | 13 +++++++++++++ tools/perf/util/stat.h | 2 ++ 3 files changed, 21 insertions(+)
tools/perf/builtin-stat.c +6 -0
@@ -821,10 +821,16 @@ static void sig_atexit(void)kill (getpid (), signr); } +void perf_stat__set_big_num (int set) +{ + stat_config.big_num = (set !=0 ); +} +static int stat__set_big_num (const struct option *opt__maybe_unused ,const char *s__maybe_unused ,int unset) { big_num_opt = unset ?0 :1 ; +perf_stat__set_big_num (!unset);return 0 ; }
tools/perf/util/config.c +13 -0
@@ -17,6 +17,7 @@#include "util/event.h" /* proc_map_timeout */ #include "util/hist.h" /* perf_hist_config */ #include "util/llvm-utils.h" /* perf_llvm_config */ +#include "util/stat.h" /* perf_stat__set_big_num */ #include "build-id.h" #include "debug.h" #include "config.h"
@@ -452,6 +453,15 @@ static int perf_ui_config(const char *var, const char *value)return 0 ; } +static int perf_stat_config (const char *var,const char *value) +{ +if (!strcmp (var,"stat.big-num" )) +perf_stat__set_big_num (perf_config_bool (var, value)); + +/* Add other config variables here. */ +return 0 ; +} +int perf_default_config (const char *var,const char *value,void *dummy__maybe_unused ) {
@@ -473,6 +483,9 @@ int perf_default_config(const char *var, const char *value,if (strstarts (var,"buildid." ))return perf_buildid_config (var, value); +if (strstarts (var,"stat." )) +return perf_stat_config (var, value); +/* Add other config variables here. */ return 0 ; }
tools/perf/util/stat.h +2 -0
@@ -132,6 +132,8 @@ struct perf_stat_config {struct rblist metric_events; }; +void perf_stat__set_big_num (int set); +void update_stats (struct stats *stats,u64 val);double avg_stats (struct stats *stats);double stddev_stats (struct stats *stats);
Signature · 1 line
2.18.2
Arnaldo Carvalho de Melo
maintainerEm Wed, May 20, 2020 at 10:32:55AM -0500, Paul A. Clarke escreveu:
Quoted 6 lines
From: "Paul A. Clarke" <[email protected]>
Add support for new "stat.big-num" boolean option.
This allows a user to set a default for "--no-big-num" for "perf stat" commands.
That is super cool, these polishing patches using infrastructure already in place for configuring user preferences, great.
One thing you forgot was to change 'man perf-stat's entry for --no-big-num to state that this is now possible, can you please do that and send a v2?
- Arnaldo
Quoted 260 lines
$ perf config stat.big-num $ perf stat --event cycles /bin/truePerformance counter stats for '
/bin/true':803,684 cycles [...] $ perf config stat.big-num=0 $ perf config stat.big-num stat.big-num=0 $ perf stat --event cycles /bin/truePerformance counter stats for '
/bin/true':790448 cycles[...]
There is an interaction with "--field-separator" that must be accommodated, such that specifying "--big-num --field-separator={x}" still reports an invalid combination of options.
Signed-off-by Paul A. Clarke <[email protected]>---
Testing results with a matrix of:
- nothing in .perfconfig, stat.big-num=0, stat.big-num=1
- --field-separator not set, --field-separator=:
- no "--big-num", --big-num, --no-big-num$ perf config stat.big-num $ perf stat --event cycles /bin/truePerformance counter stats for '
/bin/true':803,684 cycles 0.000592761 seconds time elapsed 0.000672000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/truePerformance counter stats for '
/bin/true':809,599 cycles 0.000576090 seconds time elapsed 0.000627000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/truePerformance counter stats for '
/bin/true':793870 cycles 0.000574928 seconds time elapsed 0.000625000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 790255::cycles:346960:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -xUsage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 764548::cycles:335938:100.00:: $ perf config stat.big-num=0 $ perf config stat.big-num stat.big-num=0 $ perf stat --event cycles /bin/truePerformance counter stats for '
/bin/true':790448 cycles 0.000567659 seconds time elapsed 0.000619000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/truePerformance counter stats for '
/bin/true':751,377 cycles 0.000534888 seconds time elapsed 0.000587000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/truePerformance counter stats for '
/bin/true':803738 cycles 0.000576151 seconds time elapsed 0.000657000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 774897::cycles:339986:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -xUsage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 814619::cycles:358260:100.00:: $ perf config stat.big-num=1 $ perf config stat.big-num stat.big-num=1 $ perf stat --event cycles /bin/truePerformance counter stats for '
/bin/true':787,680 cycles 0.000555401 seconds time elapsed 0.000623000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --big-num /bin/truePerformance counter stats for '
/bin/true':783,287 cycles 0.000562255 seconds time elapsed 0.000636000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --no-big-num /bin/truePerformance counter stats for '
/bin/true':748802 cycles 0.000525658 seconds time elapsed 0.000586000 seconds user 0.000000000 seconds sys$ perf stat --event cycles --field-separator=: /bin/true 785868::cycles:344508:100.00:: $ perf stat --event cycles --big-num --field-separator=: /bin/true -B option not supported with -xUsage: perf stat [<options>] [<command>]
-B, --big-num print large numbers with thousands' separators
-x, --field-separator <separator>
print counts with custom separator$ perf stat --event cycles --no-big-num --field-separator=: /bin/true 794273::cycles:349600:100.00:: $ -- tools/perf/builtin-stat.c | 6 ++++++ tools/perf/util/config.c | 13 +++++++++++++ tools/perf/util/stat.h | 2 ++ 3 files changed, 21 insertions(+)tools/perf/builtin-stat.c +6
-0@@ -821,10 +821,16 @@ static void sig_atexit(void)kill (getpid (), signr); } +void perf_stat__set_big_num (int set) +{ + stat_config.big_num = (set !=0 ); +} +static int stat__set_big_num (const struct option *opt__maybe_unused ,const char *s__maybe_unused ,int unset) { big_num_opt = unset ?0 :1 ; +perf_stat__set_big_num (!unset);return 0 ; }tools/perf/util/config.c +13
-0@@ -17,6 +17,7 @@#include "util/event.h" /* proc_map_timeout */ #include "util/hist.h" /* perf_hist_config */ #include "util/llvm-utils.h" /* perf_llvm_config */ +#include "util/stat.h" /* perf_stat__set_big_num */ #include "build-id.h" #include "debug.h" #include "config.h" @@ -452,6 +453,15 @@ static int perf_ui_config(const char *var, const char *value)return 0 ; } +static int perf_stat_config (const char *var,const char *value) +{ +if (!strcmp (var,"stat.big-num" )) +perf_stat__set_big_num (perf_config_bool (var, value)); + +/* Add other config variables here. */ +return 0 ; +} +int perf_default_config (const char *var,const char *value,void *dummy__maybe_unused ) {@@ -473,6 +483,9 @@ int perf_default_config(const char *var, const char *value,if (strstarts (var,"buildid." ))return perf_buildid_config (var, value); +if (strstarts (var,"stat." )) +return perf_stat_config (var, value); +/* Add other config variables here. */ return 0 ; }tools/perf/util/stat.h +2
-0@@ -132,6 +132,8 @@ struct perf_stat_config {struct rblist metric_events; }; +void perf_stat__set_big_num (int set); +void update_stats (struct stats *stats,u64 val);double avg_stats (struct stats *stats);double stddev_stats (struct stats *stats);Signature · 1 line
2.18.2
Signature · 1 line
- Arnaldo