iommu/iova: Free global iova rcache on iova alloc failure
Subsystems (2)
PATCH 1/1 iommu/iova: Free global iova rcache on iova alloc failure
From: Vijayanand Jitta <[email protected]>
When ever an iova alloc request fails we free the iova ranges present in the percpu iova rcaches and then retry but the global iova rcache is not freed as a result we could still see iova alloc failure even after retry as global rcache is still holding the iova's which can cause fragmentation. So, free the global iova rcache as well and then go for the retry.
Signed-off-by Vijayanand Jitta <[email protected]>
--- drivers/iommu/iova.c | 22 ++++++++++++++++++++++ include/linux/iova.h | 6 ++++++ 2 files changed, 28 insertions(+)
drivers/iommu/iova.c +22 -0
@@ -431,6 +431,7 @@ struct iova *find_iova(struct iova_domain *iovad, unsigned long pfn) flush_rcache = false;for_each_online_cpu (cpu)free_cpu_cached_iovas (cpu, iovad); +free_global_cached_iovas (iovad); goto retry; }
@@ -1044,5 +1045,26 @@ void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) } } +/* +* free all the IOVA ranges of global cache +*/ +void free_global_cached_iovas (struct iova_domain *iovad) +{ +struct iova_rcache *rcache; +int i, j; + +for (i =0 ; i <IOVA_RANGE_CACHE_MAX_SIZE ; ++i) { + rcache = &iovad->rcaches[i]; +spin_lock (&rcache->lock); +for (j =0 ; j < rcache->depot_size; ++j) { +iova_magazine_free_pfns (rcache->depot[j], iovad); +iova_magazine_free (rcache->depot[j]); + rcache->depot[j] =NULL ; + } + rcache->depot_size =0 ; +spin_unlock (&rcache->lock); + } +} +MODULE_AUTHOR ("Anil S Keshavamurthy <[email protected]>" );MODULE_LICENSE ("GPL" );
include/linux/iova.h +6 -0
@@ -163,6 +163,7 @@ int init_iova_flush_queue(struct iova_domain *iovad,struct iova *split_and_remove_iova (struct iova_domain *iovad,struct iova *iova,unsigned long pfn_lo,unsigned long pfn_hi);void free_cpu_cached_iovas (unsigned int cpu,struct iova_domain *iovad); +void free_global_cached_iovas (struct iova_domain *iovad);#else static inline int iova_cache_get (void ) {
@@ -270,6 +271,11 @@ static inline void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) { } + +static inline void free_global_cached_iovas (struct iova_domain *iovad) +{ +} +#endif #endif
Signature · 5 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu