scsi: ufs: Don't update urgent bkops level when toggle auto bkops
PATCH 1/1 scsi: ufs: Don't update urgent bkops level when toggle auto bkops
Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime, but it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled.
--- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-)
drivers/scsi/ufs/ufshcd.c +0 -1
@@ -5133,7 +5133,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err =ufshcd_enable_auto_bkops (hba); else err =ufshcd_disable_auto_bkops (hba); - hba->urgent_bkops_lvl = curr_status; out:return err; }
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Quoted 18 lines · Can Guo
Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime, but it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled.
Fixes 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled")Signed-off-by Can Guo <[email protected]>--- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-)drivers/scsi/ufs/ufshcd.c +0
-0
drivers/scsi/ufs/ufshcd.c static int ufshcd_bkops_ctrl(struct ufs_hba *hba, · line 5138
Quoted 7 lines
drivers/scsi/ufs/ufshcd.c +0
-1@@ -5133,7 +5133,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err =ufshcd_enable_auto_bkops (hba); else err =ufshcd_disable_auto_bkops (hba); - hba->urgent_bkops_lvl = curr_status; out:return err; }
Martin K. Petersen
AppliedQuoted 6 lines · Can Guo
Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime, but it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ufs: Don't update urgent bkops level when toggling auto bkops
https://git.kernel.org/mkp/scsi/c/be32acff4380
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering